Change in ovirt-engine[master]: core: Use "parseXXX" in "GlusterVolumeDaoImpl"
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "parseXXX" in "GlusterVolumeDaoImpl"
......................................................................
core: Use "parseXXX" in "GlusterVolumeDaoImpl"
This is needed in order to avoid the following findbugs error:
Boxing/unboxing to parse a primitive
A boxed primitive is created from a String, just to extract the
unboxed primitive value. It is more efficient to just call the static
parseXXX method.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING
Change-Id: I49a516fb06cafef28e34ae3c24fcdea0428700f9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49a516fb06cafef28e34ae3c24fcdea0428700f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Use "parseXXX" in "TagDaoImpl"
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "parseXXX" in "TagDaoImpl"
......................................................................
core: Use "parseXXX" in "TagDaoImpl"
This is needed in order to avoid the following findbugs error:
Boxing/unboxing to parse a primitive
A boxed primitive is created from a String, just to extract the
unboxed primitive value. It is more efficient to just call the static
parseXXX method.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING
Change-Id: I8572cd6381aed07f14297ff5fcd30f731b5f6bf9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDaoImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46611
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8572cd6381aed07f14297ff5fcd30f731b5f6bf9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Check result of "listFiles" in "BrandingManager"
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Check result of "listFiles" in "BrandingManager"
......................................................................
core: Check result of "listFiles" in "BrandingManager"
This is needed in order to avoid the following fidnbugs warning:
Possible null pointer dereference due to return value of called method
The return value from a method is dereferenced without a null check,
and the return value of that method is one that should generally be
checked for null. This may lead to a NullPointerException when the
code is executed.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Change-Id: I1dfc5b158904727d1e4acb6b947a023c9d9a3d90
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingManager.java
1 file changed, 15 insertions(+), 15 deletions(-)
Approvals:
Juan Hernandez: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dfc5b158904727d1e4acb6b947a023c9d9a3d90
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Use "parseXXX" in "BrandingTheme"
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "parseXXX" in "BrandingTheme"
......................................................................
core: Use "parseXXX" in "BrandingTheme"
This is needed in order to avoid the following findbugs error:
Boxing/unboxing to parse a primitive
A boxed primitive is created from a String, just to extract the
unboxed primitive value. It is more efficient to just call the static
parseXXX method.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING
Change-Id: I9298d8c4aee3a0ce4f9d6aa0155d5c73877b25d9
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9298d8c4aee3a0ce4f9d6aa0155d5c73877b25d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: encode non-ASCII disk alias/description
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: encode non-ASCII disk alias/description
......................................................................
core: encode non-ASCII disk alias/description
Patch Ie2642ae7 causes the disk alias and description to be stored in
the disk's metadata. Since vdsm expects for ASCII characters only, and
since both fields can contain non-ASCII characters, the operation fails
on vdsm.
This patch encodes these fields if they contain non-ASCII characters
using HEX encoding (and decodes when reading them), so that vdsm can
handle these fields even if they contain non-ASCII characters.
Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e
Bug-Url: https://bugzilla.redhat.com/1249130
Bug-Url: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
3 files changed, 205 insertions(+), 34 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: limit disk alias and description for disk metadata
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: limit disk alias and description for disk metadata
......................................................................
core: limit disk alias and description for disk metadata
On block storage, the disk metadata is limited to 512 bytes.
Since we store its alias and description in the metadata, we should
limit their size or else they will be truncated by vdsm and we won't be
able to read them.
This patch limits the value of the metadata description field size to a
maximum of 210 bytes. We do it also for file storage in order to prevent
a truncation of the description field when moving a disk from file to
block storage.
Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Bug-Url: https://bugzilla.redhat.com/1258547
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 211 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: implement MetadataDiskDescriptionHandler as a singleton
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: implement MetadataDiskDescriptionHandler as a singleton
......................................................................
core: implement MetadataDiskDescriptionHandler as a singleton
This patch is re-implementing MetadataDiskDescriptionHandler to be a
singleton so that it would be easier to test it.
Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
5 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: create MetadataDiskDescriptionHandler
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: create MetadataDiskDescriptionHandler
......................................................................
core: create MetadataDiskDescriptionHandler
This patch moves the logic regarding reading and writing the disk
description in its metadata to a separate class.
Change-Id: I1fb296980a737dfdd279d73615c4943d84de588b
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
7 files changed, 88 insertions(+), 56 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fb296980a737dfdd279d73615c4943d84de588b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: improve disk description encode/decode API
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: improve disk description encode/decode API
......................................................................
core: improve disk description encode/decode API
This patch changes the methods that encode and decode the disk
description to json to get the disk itself instead of its values.
Change-Id: I49aaaf07fe5be36bd9708c1860db7417b8e0efa0
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
5 files changed, 26 insertions(+), 20 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45922
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49aaaf07fe5be36bd9708c1860db7417b8e0efa0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.5]: core: remove duplicate code from tests in ImagesHandlerTest
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove duplicate code from tests in ImagesHandlerTest
......................................................................
core: remove duplicate code from tests in ImagesHandlerTest
Change-Id: If0fbb1d7c5e72103ba6df8869bdc2c2415fca180
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1261387
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
1 file changed, 12 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0fbb1d7c5e72103ba6df8869bdc2c2415fca180
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month