September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message
by masayag＠redhat.com 22 Sep '15

22 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message ...................................................................... engine: Fix NETWORK_ATTACHMENTS_NOT_EXISTS message Fix NETWORK_ATTACHMENTS_NOT_EXISTS message: * Fix the network attachment IDs replacement * Fix typo Change-Id: Id3266920ecabe8120a1224487c861020f8b6008d Bug-Url: https://bugzilla.redhat.com/1264959 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/46477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3266920ecabe8120a1224487c861020f8b6008d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: webadmin: fix numa x icon close button
by piotr.kliczewski＠gmail.com 22 Sep '15

22 Sep '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: fix numa x icon close button ...................................................................... webadmin: fix numa x icon close button Change-Id: Ia9bb1245a58d328cb7815e092c553a6a19f8a362 Bug-Url: https://bugzilla.redhat.com/1196095 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Tomer Saban: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9bb1245a58d328cb7815e092c553a6a19f8a362 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix script number
by masayag＠redhat.com 22 Sep '15

22 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: fix script number ...................................................................... engine: fix script number Change-Id: I133f6189a2dc33ae6611076695082d291bdc73be Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- R packaging/dbscripts/upgrade/03_06_1860_remove_custom_properties_from_vds_interface.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133f6189a2dc33ae6611076695082d291bdc73be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:remove customProperties from nic
by alkaplan＠redhat.com 22 Sep '15

22 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core:remove customProperties from nic ...................................................................... core:remove customProperties from nic Change-Id: I7f1fa4d03d10dda7209232d294c032eee5cf640e Bug-Url: https://bugzilla.redhat.com/1246060 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageLabeledNetworksParametersBuilderImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UserConfiguredNetworkData.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersister.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkAttachmentsPersisterTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/03_06_1850_remove_custom_properties_from_vds_interface.sql 20 files changed, 237 insertions(+), 151 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f1fa4d03d10dda7209232d294c032eee5cf640e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: remove customProperties from nic
by alkaplan＠redhat.com 22 Sep '15

22 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: remove customProperties from nic ...................................................................... restapi: remove customProperties from nic Change-Id: I8effb67c2137e8f6732ba8b4e00365e539864f61 Bug-Url: https://bugzilla.redhat.com/1246060 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CustomPropertiesForVdsNetworkInterface.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostNicMapperTest.java 5 files changed, 93 insertions(+), 27 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8effb67c2137e8f6732ba8b4e00365e539864f61 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin:remove customProperties from nic
by alkaplan＠redhat.com 22 Sep '15

22 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin:remove customProperties from nic ...................................................................... webadmin:remove customProperties from nic Change-Id: Icc367e3d11f2731237d2b52049d39f33364f1e84 Bug-Url: https://bugzilla.redhat.com/1246060 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java 4 files changed, 43 insertions(+), 25 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc367e3d11f2731237d2b52049d39f33364f1e84 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: fix find bugs error- changing & to &&
by alkaplan＠redhat.com 22 Sep '15

22 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: fix find bugs error- changing & to && ...................................................................... engine: fix find bugs error- changing & to && Change-Id: If6da059711cca4ca77a29a9901e2118c40d05454 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46487 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6da059711cca4ca77a29a9901e2118c40d05454 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: REVERT&FIX of: core: Remove deprecated and unused VdcO...
by emesika＠redhat.com 22 Sep '15

22 Sep '15

Eli Mesika has submitted this change and it was merged. Change subject: core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db ...................................................................... core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db reverted-Change-Id: I51d7ce9359a9ad38a034d656fb4ac1c5bab2ff43 in given patch there's problem with applying upgrade scripts. In one of upgrade scripts, values is read from vdc_options table and stored elsewhere, rendering this vdc_options row useless. However, if we remove this value from vdc_options table in 0000_config.sql, upgrade script won't find it and won't persist it elsewhere. Therefore we need to remove these values only after it's useless, ie. in upgrade script. migration of ranges data from Vdc_options table to mac_pool_ranges was don in 03_06_0090_add_mac_pool_ranges_to_storage_pool.sql Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/03_06_1850_remove_deprecated_vdc_options.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, approved; Passed CI tests Martin Mucha: Verified -- To view, visit https://gerrit.ovirt.org/46464 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: Added check-merged.sh script with ovirt_build_quick option
by sbonazzo＠redhat.com 21 Sep '15

21 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Added check-merged.sh script with ovirt_build_quick option ...................................................................... Added check-merged.sh script with ovirt_build_quick option Copied check-patch script to check-merged.sh script. Change-Id: I55554479faea7f91755b5fc0abb6f4654e75abbc Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/check-merged.packages A automation/check-merged.repos A automation/check-merged.sh 3 files changed, 92 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55554479faea7f91755b5fc0abb6f4654e75abbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Permission based icon filtering: backend part
by ofrenkel＠redhat.com 21 Sep '15

21 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Permission based icon filtering: backend part ...................................................................... core: Permission based icon filtering: backend part I allows to non-admin user to list icons using REST. Returned icons are union of predefined icons and icons that are associated with some entity the user has permission to (vm or tempate). Change-Id: I09aecac8c8265cf687ecf4edc2305421a2feb61b Bug-Url: https://bugzilla.redhat.com/1263758 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmIconsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmIconDaoImpl.java 4 files changed, 29 insertions(+), 7 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09aecac8c8265cf687ecf4edc2305421a2feb61b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0