September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add disk check specific LUN visibility
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Add disk check specific LUN visibility ...................................................................... engine: Add disk check specific LUN visibility When adding a new direct LUN disk, the engine tests the visibility of the LUN if a host has been specified. In order to improve performance, the visibility test done via GetDeviceList will be performed only on the specific LUN. Change-Id: I39d0267fffd7e96c0d5297ac4792f632201ecdf1 Bug-Url: https://bugzilla.redhat.com/1217401 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 3 files changed, 17 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/45770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39d0267fffd7e96c0d5297ac4792f632201ecdf1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: GetDeviceList without check status
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: GetDeviceList without check status ...................................................................... engine: GetDeviceList without check status When a user opens the Storage Domain or Disk dialog for block storage, a GetDeviceList verb is called on VDSM. In order to populate the 'status' field, the getDeviceList verb perform a create PV test. This operation is expensive, and in setups with large number of devices it will cause performance problem and even timeouts. The flow before this patch was: - Engine calls getDeviceList, VDSM performs status check for each device, possibly times out - User selects a few devices (typically one) to add/extend a SD or create a new LUN disk - GUI warns user about used devices The flow with this patch: - Engine calls getDeviceList, skipping status check - User selects a few devices (typically one) to add/extend a SD or create a new LUN disk - Engine calls getDeviceList, checking status only for selected - Engine warns user about used devices Change-Id: Ib4484307e3d4ac66a4370bcef3ac015ad0f2d084 Bug-Url: https://bugzilla.redhat.com/1217401 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshLunsSizeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LunStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDeviceListQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 20 files changed, 238 insertions(+), 38 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/45673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4484307e3d4ac66a4370bcef3ac015ad0f2d084 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: core: Remove BackwardCompatibilityTaskCreationTest
by tnisan＠redhat.com 20 Sep '15

20 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove BackwardCompatibilityTaskCreationTest ...................................................................... core: Remove BackwardCompatibilityTaskCreationTest This test was added in order to future-proof the code against accidentally changing the behavior of concreteCreateTask() as part of the development of the SEAT framework. As this framework is now deprecated in favor of Command Coordination, and this method does nothing but delegate to CommandCoordinationUtil, there really is no reason to keep this test. Especially in light of the occasional failures it displayed in the CI environment. Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Bug-Url: https://bugzilla.redhat.com/1227310 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 0 insertions(+), 209 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/46424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove BackwardCompatibilityTaskCreationTest
by tnisan＠redhat.com 20 Sep '15

20 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove BackwardCompatibilityTaskCreationTest ...................................................................... core: Remove BackwardCompatibilityTaskCreationTest This test was added in order to future-proof the code against accidentally changing the behavior of concreteCreateTask() as part of the development of the SEAT framework. As this framework is now deprecated in favor of Command Coordination, and this method does nothing but delegate to CommandCoordinationUtil, there really is no reason to keep this test. Especially in light of the occasional failures it displayed in the CI environment. Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Bug-Url: https://bugzilla.redhat.com/1227310 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 0 insertions(+), 204 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/46423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: column checkboxes
by gshereme＠redhat.com 20 Sep '15

20 Sep '15

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: column checkboxes ...................................................................... webadmin: column checkboxes - Column check boxes were not working as they would never update the underlying model due to not handling the 'change' event. This patch fixes the issue. Change-Id: I4b38428b8fe7cda349f0c2f420ff35e243930523 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1264041 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b38428b8fe7cda349f0c2f420ff35e243930523 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Filter out external VMs for OVF_SOTRE disk.
by mlipchuk＠redhat.com 20 Sep '15

20 Sep '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Filter out external VMs for OVF_SOTRE disk. ...................................................................... core: Filter out external VMs for OVF_SOTRE disk. Filter out external VMs when we store VMs to the OVF_STORE disk in the Storage Domain. External VMs represent processes which run on the Host and does not reflect entities which the user will want to preserve for disaster, therefore there is no need to preserve also external VMs in the OVF_STORE disk. Change-Id: I253bfb974f78d0e7441da020d4bfe46c8aa5ac10 Bug-Url: https://bugzilla.redhat.com/1259467 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253bfb974f78d0e7441da020d4bfe46c8aa5ac10 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest DAO mocks
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest DAO mocks ...................................................................... core: GetLunsByVgIdQueryTest DAO mocks Standardized the way DAOs are mocked and used so the class has a single pattern (which complies to the patterns of the other query tests) instead of three different ways to handle three different DAOs. Change-Id: I52ac07b7420de9b0d978bc909ec303667d21777b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 14 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46409 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52ac07b7420de9b0d978bc909ec303667d21777b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest array initializers
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest array initializers ...................................................................... core: GetLunsByVgIdQueryTest array initializers Removed redundant array initializers to improve code readability. Change-Id: Id386fd0939965f57d00b9962e88a2e531f902bbf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46408 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id386fd0939965f57d00b9962e88a2e531f902bbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdTest->GetLunsByVgIdQueryTest
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdTest->GetLunsByVgIdQueryTest ...................................................................... core: GetLunsByVgIdTest->GetLunsByVgIdQueryTest Renamed test class to represent the class it is testing, as per JUnit's best practices. Change-Id: I7b2208195ba173b4778307600919db0786aea81c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b2208195ba173b4778307600919db0786aea81c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest pointless assertion
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest pointless assertion ...................................................................... core: GetLunsByVgIdQueryTest pointless assertion Remove a pointless assertion on the query's return value type. Anything that can be validated in compile time needn't be asserted in runtime. Change-Id: If46db1d0b4bfd6d72a7e553a615495e6119b689e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46414 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If46db1d0b4bfd6d72a7e553a615495e6119b689e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0