September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest#GUIDS
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest#GUIDS ...................................................................... core: GetLunsByVgIdQueryTest#GUIDS Changed GUIDs to be a String, as it's always referenced by its toString() anyway. Change-Id: I1ebd7d1481008ad23861a55a22d3f6a286b34428 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46415 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ebd7d1481008ad23861a55a22d3f6a286b34428 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest#checkReturnValue()
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest#checkReturnValue() ...................................................................... core: GetLunsByVgIdQueryTest#checkReturnValue() Stop passing the query as an argument, as it's available by calling a simple getter - getQuery(). Change-Id: Ifd0e4512b642526c9ac78a7bac43103c2a3f2355 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd0e4512b642526c9ac78a7bac43103c2a3f2355 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest generics
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest generics ...................................................................... core: GetLunsByVgIdQueryTest generics Updated the use of generics to Java 7's diamond syntax to clear up the code. Change-Id: I52e3265252c393a432dffe49e9b45289bcdfde53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e3265252c393a432dffe49e9b45289bcdfde53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest modifiers
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest modifiers ...................................................................... core: GetLunsByVgIdQueryTest modifiers Fixed helper method modifiers as per Java best practices. Change-Id: I4200dff1a058527cc57ed758b42e741d24e349f1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4200dff1a058527cc57ed758b42e741d24e349f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: GetLunsByVgIdQueryTest: enhanced for loops
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetLunsByVgIdQueryTest: enhanced for loops ...................................................................... core: GetLunsByVgIdQueryTest: enhanced for loops Use Java 5's enhanced for loops instead of the traditional for loops to improve the code's readability. Change-Id: I601e33fda06c027ded11558b826ff44dc23d5ae2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdQueryTest.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601e33fda06c027ded11558b826ff44dc23d5ae2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Remove BackwardCompatibilityTaskCreationTest
by amureini＠redhat.com 20 Sep '15

20 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove BackwardCompatibilityTaskCreationTest ...................................................................... core: Remove BackwardCompatibilityTaskCreationTest This test was added in order to future-proof the code against accidentally changing the behavior of concreteCreateTask() as part of the development of the SEAT framework. As this framework is now deprecated in favor of Command Coordination, and this method does nothing but delegate to CommandCoordinationUtil, there really is no reason to keep this test. Especially in light of the occasional failures it displayed in the CI environment. Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Bug-Url: https://bugzilla.redhat.com/1227310 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 1 file changed, 0 insertions(+), 202 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/46418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b1f6378d3b9e6df9cfaaefc1d2bad260bffaf9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: added proper watchdog CAD checks
by tnisan＠redhat.com 20 Sep '15

20 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: added proper watchdog CAD checks ...................................................................... core: added proper watchdog CAD checks The type and action was checked only on one place - added to generic validator and used everywhere. Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8 Bug-Url: https://bugzilla.redhat.com/1261015 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidatorTest.java 9 files changed, 103 insertions(+), 48 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: optimized view dwh_vm_configuration_history_view
by emesika＠redhat.com 20 Sep '15

20 Sep '15

Eli Mesika has submitted this change and it was merged. Change subject: optimized view dwh_vm_configuration_history_view ...................................................................... optimized view dwh_vm_configuration_history_view In where clause, the same query was called 3 times. I moved that query to the from clause and verified the date using the greatest function instead of 3 OR statements. Change-Id: I0d3fe0d57d88c49775e33d753fc7df4169552b96 Signed-off-by: Sim Zacks <szacks(a)redhat.com> --- M packaging/dbscripts/create_dwh_views.sql 1 file changed, 4 insertions(+), 19 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Yaniv Dary: Looks good to me, but someone else must approve Sim Zacks: Verified -- To view, visit https://gerrit.ovirt.org/44275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d3fe0d57d88c49775e33d753fc7df4169552b96 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sim Zacks <szacks(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sim Zacks <szacks(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Support detach of local Storage Domain
by tnisan＠redhat.com 20 Sep '15

20 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Support detach of local Storage Domain ...................................................................... core: Support detach of local Storage Domain When detaching a local Storage Domain, the engine will automatically try to remove it. The remove process in the engine, checks if local Storage Domain is already attached to a Data Center so the Host will not fail during the remove process. This validation is meanningless for local Storage Domain since the local Storage Domain will first get detached and only after it will be removed as part of the Remove process. The detach operation should remove its storage pool metadata, and that is why the local Storage Domain should not be obligated to this validation. Change-Id: I9e4e603301a3ec893e6de5804a11d136dd1965ec Bug-Url: https://bugzilla.redhat.com/1263589 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/46295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e4e603301a3ec893e6de5804a11d136dd1965ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Correct error for illegal data domain action
by tnisan＠redhat.com 20 Sep '15

20 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Correct error for illegal data domain action ...................................................................... core: Correct error for illegal data domain action Change-Id: I337d7914c3700ffecc4e0a5b8d362fb0d8950769 Bug-Url: https://bugzilla.redhat.com/1221190 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Vered Volansky: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I337d7914c3700ffecc4e0a5b8d362fb0d8950769 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0