September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: don't set watchdog action to null
by tnisan＠redhat.com 21 Sep '15

21 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: don't set watchdog action to null ...................................................................... webadmin: don't set watchdog action to null It is not correct to set it to null - it renders as an empty value which is not correct - better just to disable the field. Change-Id: I2792c7b4b50d402fa6cb9622f5d3174b2653853b Bug-Url: https://bugzilla.redhat.com/1261015 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Jakub Niedermertl: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2792c7b4b50d402fa6cb9622f5d3174b2653853b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: watchdog action edit template not always filled
by tnisan＠redhat.com 21 Sep '15

21 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: watchdog action edit template not always filled ...................................................................... webadmin: watchdog action edit template not always filled The updateWatchdogItems cleared the selected watchDogModel which caused the watchdog action to be set to null in watchdogModelSelectedItemChanged Change-Id: I000fc7ef8a61be34d67993c405a3bb2ff7136d3b Bug-Url: https://bugzilla.redhat.com/1261015 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests Martin Betak: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000fc7ef8a61be34d67993c405a3bb2ff7136d3b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Filter out external VMs for OVF_SOTRE disk.
by tnisan＠redhat.com 21 Sep '15

21 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Filter out external VMs for OVF_SOTRE disk. ...................................................................... core: Filter out external VMs for OVF_SOTRE disk. Filter out external VMs when we store VMs to the OVF_STORE disk in the Storage Domain. External VMs represent processes which run on the Host and does not reflect entities which the user will want to preserve for disaster, therefore there is no need to preserve also external VMs in the OVF_STORE disk. Change-Id: I253bfb974f78d0e7441da020d4bfe46c8aa5ac10 Bug-Url: https://bugzilla.redhat.com/1259467 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/vms_sp.sql 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/46429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I253bfb974f78d0e7441da020d4bfe46c8aa5ac10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: cleanup: drop fc20 references
by sbonazzo＠redhat.com 21 Sep '15

21 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: cleanup: drop fc20 references ...................................................................... cleanup: drop fc20 references dropping fc20 references since fc20 gone EOL Change-Id: Iacdd47fefc244879acaba645033de67968f97b34 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/mock_run.sh M jobs/confs/shell-scripts/standard_build_artifacts.sh M jobs/confs/shell-scripts/standard_check_merged.sh M jobs/confs/shell-scripts/standard_check_patch.sh D mock_configs/fedora-20-i386.cfg D mock_configs/fedora-20-x86_64.cfg D mock_configs/fedora-20-x86_64_proxied.cfg M mock_configs/mock_runner.sh 8 files changed, 10 insertions(+), 201 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacdd47fefc244879acaba645033de67968f97b34 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[ovirt-image-uploader-3.6]: ovirt-image-uploader: show informative msg if OVF data not f...
by sbonazzo＠redhat.com 21 Sep '15

21 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: show informative msg if OVF data not found ...................................................................... ovirt-image-uploader: show informative msg if OVF data not found This patch improves user experience without changing current behavior. Change-Id: Ib5b4fc629acc2a4e754f0ae53d7b628bd172ad6e Bug-Url: https://bugzilla.redhat.com/1258758 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> (cherry picked from commit 342ec2f0901d30e7804d0b482c0ef4c9e2254392) --- M src/__main__.py 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/46371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b4fc629acc2a4e754f0ae53d7b628bd172ad6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: ovirt-image-uploader-3.6 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: tools: better check of deploy status and fixing messages
by sbonazzo＠redhat.com 21 Sep '15

21 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: better check of deploy status and fixing messages ...................................................................... tools: better check of deploy status and fixing messages If the host was correctly deployed but, for any reasons, the tool wasn't able to find vm.conf it was complaining about being still not deployed. Fixing it. Bug-Url: https://bugzilla.redhat.com/1263295 Change-Id: Iec9d1ad17331f73f541d477b288d75373b35bdea Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 49 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec9d1ad17331f73f541d477b288d75373b35bdea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: tools: better check of deploy status and fixing messages
by sbonazzo＠redhat.com 21 Sep '15

21 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: tools: better check of deploy status and fixing messages ...................................................................... tools: better check of deploy status and fixing messages If the host was correctly deployed but, for any reasons, the tool wasn't able to find vm.conf it was complaining about being still not deployed. Fixing it. Bug-Url: https://bugzilla.redhat.com/1263295 Change-Id: Iec9d1ad17331f73f541d477b288d75373b35bdea Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/bin/hosted-engine.in 1 file changed, 49 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec9d1ad17331f73f541d477b288d75373b35bdea Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: add warning when taking a snapshot with memory
by ahadas＠redhat.com 21 Sep '15

21 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: frontend: add warning when taking a snapshot with memory ...................................................................... frontend: add warning when taking a snapshot with memory Currently when taking a live snapshot of a VM the memory saving is not "live", i.e the VM is paused for the duration of dumping the memory. Therefore, adding a warning that is going to be presented when asked to take a live snapshot with memory which says that the VM is going to be paused while saving the memory. Change-Id: Id436f462b56099c1d5e9f10d99b5647a95119a9a Bug-Url: https://bugzilla.redhat.com/1057009 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmSnapshotCreatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmSnapshotCreatePopupView.java 5 files changed, 21 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id436f462b56099c1d5e9f10d99b5647a95119a9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: frontend: minor refactroing in snapshot dialogs
by ahadas＠redhat.com 21 Sep '15

21 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: frontend: minor refactroing in snapshot dialogs ...................................................................... frontend: minor refactroing in snapshot dialogs 1. Remove redundant casting 2. Remove 'is' prefix from variable names Change-Id: I599a57b84c6ed6fbc77ca25ce0de236c0780b4a0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCreatePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotCustomPreviewPopupWidget.java 2 files changed, 10 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I599a57b84c6ed6fbc77ca25ce0de236c0780b4a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Add event for host low memory
by oourfali＠redhat.com 21 Sep '15

21 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Add event for host low memory ...................................................................... webadmin: Add event for host low memory Change-Id: I0ed2b9ca9e93a3d92a147a3552ee911842d01baf Bug-Url: https://bugzilla.redhat.com/1264109 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 3 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ed2b9ca9e93a3d92a147a3552ee911842d01baf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0