Change in ovirt-engine[master]: webadmin: Add hints to affinity group dialog
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Add hints to affinity group dialog
......................................................................
webadmin: Add hints to affinity group dialog
Added hints for positive and enforcing checkboxes.
Change-Id: I348dfa1351477d3d894d53b83b76d17d0f872949
Bug-Url: https://bugzilla.redhat.com/1057480
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/AffinityGroupPopupView.ui.xml
3 files changed, 39 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/46002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I348dfa1351477d3d894d53b83b76d17d0f872949
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: webadmin: watchdog action edit template not always filled
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: watchdog action edit template not always filled
......................................................................
webadmin: watchdog action edit template not always filled
The updateWatchdogItems cleared the selected watchDogModel which caused the
watchdog action to be set to null in watchdogModelSelectedItemChanged
Change-Id: I000fc7ef8a61be34d67993c405a3bb2ff7136d3b
Bug-Url: https://bugzilla.redhat.com/1261015
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46319
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I000fc7ef8a61be34d67993c405a3bb2ff7136d3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in jenkins[master]: Yamlizing the ovirt appliance build
by tlitovsk@redhat.com
Anatoly Litovsky has submitted this change and it was merged.
Change subject: Yamlizing the ovirt appliance build
......................................................................
Yamlizing the ovirt appliance build
Change-Id: Idd19d1762fd7c38d93aca9bada12036ab4b9bea2
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
A jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml
A jobs/confs/yaml/scms/ovirt-appliance-scm.yaml
2 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me
Jenkins CI: Passed CI tests
Anatoly Litovsky: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/46333
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd19d1762fd7c38d93aca9bada12036ab4b9bea2
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[master]: core: added proper watchdog CAD checks
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: added proper watchdog CAD checks
......................................................................
core: added proper watchdog CAD checks
The type and action was checked only on one place - added to generic validator
and used everywhere.
Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8
Bug-Url: https://bugzilla.redhat.com/1261015
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidatorTest.java
9 files changed, 103 insertions(+), 48 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46318
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Adjust websockify to the new 0.6.0 API
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: Adjust websockify to the new 0.6.0 API
......................................................................
core: Adjust websockify to the new 0.6.0 API
python-websockify v0.6.0 changed the client API and this
patch addresses these things.
Upgrading to websockify 0.6.0 improves 2 things:
1, Logging - library uses standard python logging facilities.
2, Killing zombies - library takes care of killling zombie processes (we
had to handle it ourselves).
Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1092611
Bug-Url: https://bugzilla.redhat.com/1098574
---
M ovirt-engine.spec.in
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py
2 files changed, 59 insertions(+), 73 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/32138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: uutils: OpenSSHUtils: enable multi-key validation
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: uutils: OpenSSHUtils: enable multi-key validation
......................................................................
uutils: OpenSSHUtils: enable multi-key validation
for single key the current implementation is not good as it ignores
everything after the 2nd field, ignoring new line terminator of key.
as we already support multiple keys, we just need to verify each line as
a key.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671
Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java
3 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: make NetworkSriovSupported eligible for user-portal
by piotr.kliczewski@gmail.com
Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: make NetworkSriovSupported eligible for user-portal
......................................................................
engine: make NetworkSriovSupported eligible for user-portal
Make NetworkSriovSupported eligible for user-portal.
Change-Id: Ic395ce78e1d99d16d8c6305d1488993ccfa89fdb
Bug-Url: https://bugzilla.redhat.com/1247966
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/46308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic395ce78e1d99d16d8c6305d1488993ccfa89fdb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: remove redundant join for next-run config
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove redundant join for next-run config
......................................................................
core: remove redundant join for next-run config
The view vms_with_tags is based on vms view that already
contains whether or not the VM contains next-run configuration.
Therefore, instead of doing another join with the snapshots
table, this information is now fetched from the vms view.
Change-Id: Ieaf53e247afd79dad6179a04ece7510f4bff78a0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/45778
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf53e247afd79dad6179a04ece7510f4bff78a0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: engine: make NetworkSriovSupported eligible for user-portal
by emesika@redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: make NetworkSriovSupported eligible for user-portal
......................................................................
engine: make NetworkSriovSupported eligible for user-portal
Make NetworkSriovSupported eligible for user-portal.
Change-Id: Ic395ce78e1d99d16d8c6305d1488993ccfa89fdb
Bug-Url: https://bugzilla.redhat.com/1247966
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/46305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic395ce78e1d99d16d8c6305d1488993ccfa89fdb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: webadmin: VM-like dialogs cleanup
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: VM-like dialogs cleanup
......................................................................
webadmin: VM-like dialogs cleanup
Aligning widgets of VM, Templete and VM Pool dialog, tabs General,
System, Initial Run, Console.
Bug-Url: https://bugzilla.redhat.com/1231159
Change-Id: I51db16d7d89fa9eeca2ea0778192c8d9b42d4430
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/EntityModelWidgetWithInfo.ui.xml
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/GenericWidgetWithLabel.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/GenericWidgetWithLabel.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidget.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelDetachableWidgetWithLabel.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
8 files changed, 143 insertions(+), 33 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46252
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51db16d7d89fa9eeca2ea0778192c8d9b42d4430
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month