September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: replaced deprecated check for 'allowedDuplicates'.
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: replaced deprecated check for 'allowedDuplicates'. ...................................................................... core: replaced deprecated check for 'allowedDuplicates'. allowed duplicates setting were read from engine config, which was [the allowed duplicates option] deprecated in 3.6, and MAC pool property should be consulted instead. Change-Id: Ie9d54afbeb424d6a13a853b9e4d5f4878c8bcc1a Bug-Url: https://bugzilla.redhat.com/1212461 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerRanges.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerStrategy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MacAddressValidator.java 7 files changed, 75 insertions(+), 60 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9d54afbeb424d6a13a853b9e4d5f4878c8bcc1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: added NetworkImplementationDetailsUtilsTest also for b...
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: added NetworkImplementationDetailsUtilsTest also for base nic. ...................................................................... core: added NetworkImplementationDetailsUtilsTest also for base nic. Bug-Url: https://bugzilla.redhat.com/1136329 Change-Id: I87895ceeb3e415f4ea9544f8dfbf4870391a3fe2 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsTest.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsTestForBaseNic.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsTestForVlanNic.java 4 files changed, 367 insertions(+), 289 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87895ceeb3e415f4ea9544f8dfbf4870391a3fe2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: instantiation of validator moved out from class
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: instantiation of validator moved out from class ...................................................................... core: instantiation of validator moved out from class also removed duplicities of assigning slaves to bond Bug-Url: https://bugzilla.redhat.com/1136329 Change-Id: Iab3586aab896045ba9ce8af264f08a10f7c42743 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ValidationResultMatchers.java 2 files changed, 76 insertions(+), 75 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Mucha: Verified Alona Kaplan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab3586aab896045ba9ce8af264f08a10f7c42743 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: simplified HostSetupNetworksValidatorTest
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: simplified HostSetupNetworksValidatorTest ...................................................................... core: simplified HostSetupNetworksValidatorTest Bug-Url: https://bugzilla.redhat.com/1136329 Change-Id: Ibe8725284043b6e7c6117d7b553d75a0374e147b Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 1 file changed, 317 insertions(+), 307 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe8725284043b6e7c6117d7b553d75a0374e147b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Release mom-0.5.1
by msivak＠redhat.com 17 Sep '15

17 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: Release mom-0.5.1 ...................................................................... Release mom-0.5.1 Change-Id: I1430f1cda292aad2e85f954dd3f8c66c47ff602b Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/46312 Continuous-Integration: Jenkins CI --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1430f1cda292aad2e85f954dd3f8c66c47ff602b Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in mom[master]: Handle missing balloonInfo properly
by msivak＠redhat.com 17 Sep '15

17 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: Handle missing balloonInfo properly ...................................................................... Handle missing balloonInfo properly Change-Id: Id048ee0c646c00c788de80dbc20e661654589144 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1264095 Signed-off-by: Martin Sivak <msivak(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/46307 Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com> Continuous-Integration: Jenkins CI --- M mom/HypervisorInterfaces/vdsmxmlrpcInterface.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/46307 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id048ee0c646c00c788de80dbc20e661654589144 Gerrit-PatchSet: 2 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: uutils: OpenSSHUtils: enable multi-key validation
by ofrenkel＠redhat.com 17 Sep '15

17 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: uutils: OpenSSHUtils: enable multi-key validation ...................................................................... uutils: OpenSSHUtils: enable multi-key validation for single key the current implementation is not good as it ignores everything after the 2nd field, ignoring new line terminator of key. as we already support multiple keys, we just need to verify each line as a key. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1223671 Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java 3 files changed, 25 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e84dd1a686e32b9d27a229361ae71c66c3e5c4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Remove deprecated and unused VdcOptions from db
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove deprecated and unused VdcOptions from db ...................................................................... core: Remove deprecated and unused VdcOptions from db Change-Id: Ic43b35dde5a1cb740735484198ed3ebec1f7f30d Bug-Url: https://bugzilla.redhat.com/1254961 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved; Passed CI tests Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic43b35dde5a1cb740735484198ed3ebec1f7f30d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix CDA message of import vm using virt-v2v
by ahadas＠redhat.com 17 Sep '15

17 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: core: fix CDA message of import vm using virt-v2v ...................................................................... core: fix CDA message of import vm using virt-v2v Set the action type and entity type of import-vm using virt-v2v commands (from external provider and from ova file) so their can do action messages will be displayed properly. Change-Id: I0351778addc4a5368b83726660e82b5377d658a0 Bug-Url: https://bugzilla.redhat.com/1252759 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/46273 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0351778addc4a5368b83726660e82b5377d658a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: replaced deprecated check for 'allowedDuplicates'.
by alkaplan＠redhat.com 17 Sep '15

17 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: replaced deprecated check for 'allowedDuplicates'. ...................................................................... core: replaced deprecated check for 'allowedDuplicates'. allowed duplicates setting were read from engine config, which was [the allowed duplicates option] deprecated in 3.6, and MAC pool property should be consulted instead. Change-Id: Ia384509b16b8547194ff1b0532bea3c256928f4f Bug-Url: https://bugzilla.redhat.com/1212461 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerRanges.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacPoolManagerStrategy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MacAddressValidator.java 7 files changed, 75 insertions(+), 60 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/40052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia384509b16b8547194ff1b0532bea3c256928f4f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0