September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: floating disk dialog - ensure Data Center select-box
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: floating disk dialog - ensure Data Center select-box ...................................................................... webadmin: floating disk dialog - ensure Data Center select-box Ensured 'Data Center' select-box is enabled on floating disk dialog, to allow changing a DC in case the selected one got the form being disabled - e.g. due to no available Cinder storage domains. Change-Id: I363d3692158febc2c7c4f7c8225919bc09e8ef7a Bug-Url: https://bugzilla.redhat.com/1264009 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/46293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363d3692158febc2c7c4f7c8225919bc09e8ef7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: override getConsumedEvents of CheckboxCell
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: override getConsumedEvents of CheckboxCell ...................................................................... webadmin: override getConsumedEvents of CheckboxCell SanStorageLunToTargetList -> addSelectAllButton: update method on the custom ValueUpdater isn't get invoked since CheckboxCell's parent events are overridden on CheckboxCell -> getConsumedEvents (see [1]). Hence, adding parent's consumedEvents on SanStorageLunToTargetList. [1] https://gerrit.ovirt.org/#/c/45444/ Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8 Bug-Url: https://bugzilla.redhat.com/1215416 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/CheckboxCell.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageLunToTargetList.java 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/46267 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea76bc58689d608e83554072e871487dc33fb4d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.0_beta6
by sbonazzo＠redhat.com 17 Sep '15

17 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.0_beta6 ...................................................................... build: ovirt-live-3.6.0_beta6 Change-Id: I922e599b358fcefeb12492792547c55482199907 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I922e599b358fcefeb12492792547c55482199907 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: SchedulingManager - Lower visibiliy of inner helper me...
by rgolan＠redhat.com 17 Sep '15

17 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: SchedulingManager - Lower visibiliy of inner helper methods ...................................................................... core: SchedulingManager - Lower visibiliy of inner helper methods Change-Id: Ia1356a7eeaef1f1c824417e4c7d055af9e4f789c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45687 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1356a7eeaef1f1c824417e4c7d055af9e4f789c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Support detach of local Storage Domain.
by mlipchuk＠redhat.com 17 Sep '15

17 Sep '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support detach of local Storage Domain. ...................................................................... core: Support detach of local Storage Domain. When detaching a local Storage Domain, the engine will automatically try to remove it. The remove process in the engine, checks if local Storage Domain is already attached to a Data Center so the Host will not fail during the remove process. This validation is meanningless for local Storage Domain since the local Storage Domain will first get detached and only after it will be removed as part of the Remove process. The detach operation should remove its storage pool metadata, and that is why the local Storage Domain should not be obligated to this validation. Change-Id: I9e4e603301a3ec893e6de5804a11d136dd1965ec Bug-Url: https://bugzilla.redhat.com/1263589 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/46216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e4e603301a3ec893e6de5804a11d136dd1965ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine, webadmin: Fix serial console error messages
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine, webadmin: Fix serial console error messages ...................................................................... engine, webadmin: Fix serial console error messages Add missing vmconsole messages to frontend. Fix vmconsole message typos. Change-Id: I6c111bca340972a1e7722bec10350ed19ff212fc Bug-Url: https://bugzilla.redhat.com/1223671 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 10 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46290 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c111bca340972a1e7722bec10350ed19ff212fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: HA reservation needs to take the full VM's memory into account
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: HA reservation needs to take the full VM's memory into account ...................................................................... HA reservation needs to take the full VM's memory into account The current HA reservation code only counted the used memory of HA VMs. But the engine will refuse to migrate the VM when there is not enough memory when compared to the minimum guaranteed settings. This patch updates the computation and uses the minimum guaranteed memory size or the currently used amount of memory whichever is higher. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1220134 Change-Id: Ib3af7e370f004f7c22335c507e4e191b90166f6d Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 4711d1fdf22265a6c970dc4b2fa3b2eb84646342) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3af7e370f004f7c22335c507e4e191b90166f6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: floating disk dialog - ensure Data Center select-box
by tnisan＠redhat.com 17 Sep '15

17 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: floating disk dialog - ensure Data Center select-box ...................................................................... webadmin: floating disk dialog - ensure Data Center select-box Ensured 'Data Center' select-box is enabled on floating disk dialog, to allow changing a DC in case the selected one got the form being disabled - e.g. due to no available Cinder storage domains. Change-Id: I363d3692158febc2c7c4f7c8225919bc09e8ef7a Bug-Url: https://bugzilla.redhat.com/1264009 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/46287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I363d3692158febc2c7c4f7c8225919bc09e8ef7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: remove redundant lines
by rgolan＠redhat.com 17 Sep '15

17 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: remove redundant lines ...................................................................... core: remove redundant lines Change-Id: I37eb2a6a440dcf42024d6eb710b1e4376e2e3552 Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43564 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37eb2a6a440dcf42024d6eb710b1e4376e2e3552 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add missing audit log on migration failure
by ahadas＠redhat.com 17 Sep '15

17 Sep '15

Arik Hadas has submitted this change and it was merged. Change subject: core: add missing audit log on migration failure ...................................................................... core: add missing audit log on migration failure In the following scenario: 1. Migrate VM 2. VM fails to migrate to the first host 3. There are no other hosts to migrate to Assuming the number of retries for a VM migration is not set to 1, the audit log VM_MIGRATION_FAILED was not generated but VM_MIGRATION_FAILED_NO_VDS_TO_RUN_ON was generated instead. This patch fixes it by changing the audit log VM_MIGRATION_FAILED_NO_VDS_TO_RUN_ON to be a warning that only specifies that no host was found and after it VM_MIGRATION_FAILED is generated to summarize that the migration failed. Change-Id: I8aaa2004102269fed78eb737a0c1806821e711ef Bug-Url: https://bugzilla.redhat.com/1193025 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8aaa2004102269fed78eb737a0c1806821e711ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0