September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Host sort not working
by tnisan＠redhat.com 16 Sep '15

16 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Host sort not working ...................................................................... webadmin: Host sort not working - The code that unifies the fence agents on the hosts would not preserver the order in which the hosts were returned from the query, which resulted in the sorting not working properly. This patch simplies the mechanism to unify the fence agents while preserving the order. Change-Id: I1bda06931812ed0dca4ecab8dd956e5b5c1e9686 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1249607 Signed-off-by: Alexander Wels <awels(a)redhat.com> (cherry picked from commit bbb72545ce7b0263f7dcdf3632d73fd894138bad) --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java 1 file changed, 21 insertions(+), 25 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bda06931812ed0dca4ecab8dd956e5b5c1e9686 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Correct grammar in LockProperties comments
by tnisan＠redhat.com 16 Sep '15

16 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Correct grammar in LockProperties comments ...................................................................... core: Correct grammar in LockProperties comments Change-Id: I295d57375445a39235a39a76dd4469455fe40204 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LockProperties.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I295d57375445a39235a39a76dd4469455fe40204 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Re-support repeated audit-log messages
by tnisan＠redhat.com 16 Sep '15

16 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Re-support repeated audit-log messages ...................................................................... engine: Re-support repeated audit-log messages Commit f3ae843f73cf3349b707ffb870c135992075c223 broke the support of repeatable audit log messages and this patch fixes the issue. Change-Id: Ic33240f534949a89b039c65412d4b0adfb870d9d Bug-Url: https://bugzilla.redhat.com/1142904 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic33240f534949a89b039c65412d4b0adfb870d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Re-support repeated audit-log messages
by masayag＠redhat.com 16 Sep '15

16 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine: Re-support repeated audit-log messages ...................................................................... engine: Re-support repeated audit-log messages Commit f3ae843f73cf3349b707ffb870c135992075c223 broke the support of repeatable audit log messages. This patch fixes the issue. Change-Id: Ic33240f534949a89b039c65412d4b0adfb870d9d Bug-Url: https://bugzilla.redhat.com/1142904 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic33240f534949a89b039c65412d4b0adfb870d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine, userportal, webadmin: Move set VM console key to opt...
by masayag＠redhat.com 16 Sep '15

16 Sep '15

Moti Asayag has submitted this change and it was merged. Change subject: engine, userportal, webadmin: Move set VM console key to options menu ...................................................................... engine, userportal, webadmin: Move set VM console key to options menu Move Set Vm Console key from VM tab to User->Options menu item. Change-Id: I9045b42d3eaf235055e11f3b61596e5df183be69 Bug-Url: https://bugzilla.redhat.com/1223671 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BasePresenterModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUiCommonModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/section/main/presenter/OptionsPopupPresenterWidget.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/OptionsProvider.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractHeaderView.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.ui.xml D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PublicKeyPopupWidget.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/PublicKeyPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EditOptionsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/OptionsModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/PublicKeyModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UiCommonModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/HeaderPresenterWidget.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/PublicKeyPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/OptionsPopupView.ui.xml D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/PublicKeyPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/vm/PublicKeyPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/PublicKeyPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 35 files changed, 173 insertions(+), 436 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9045b42d3eaf235055e11f3b61596e5df183be69 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use @Parameter instead of @Component in JBoss modules ...
by juan.hernandez＠redhat.com 16 Sep '15

16 Sep '15

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use @Parameter instead of @Component in JBoss modules plugin ...................................................................... core: Use @Parameter instead of @Component in JBoss modules plugin This is required in order to fix the following warning generated by recent versions of Maven: [WARNING] Deprecated @Component annotation for 'project' field in org.ovirt.engine.build.ModulesMojo: replace with @Parameter( default-value = "${project}", readonly = true ) Change-Id: Id9aaf0dc43ad0ede2e07d8cabaaad8997b6af597 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M build-tools-root/jboss-modules-maven-plugin/src/main/java/org/ovirt/engine/build/ModulesMojo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9aaf0dc43ad0ede2e07d8cabaaad8997b6af597 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: host install current version
by awels＠redhat.com 16 Sep '15

16 Sep '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: host install current version ...................................................................... webadmin: host install current version - The curren version was too narrow to contain all the text. Made the dialog a little wider and also made the field take up more space in the dialog. - Updated the layout to be patternfly based. Change-Id: Ie6cf8f0dbd7b7be7e80c9dc8ad9bb795433c6cb6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1191158 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml 4 files changed, 88 insertions(+), 42 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6cf8f0dbd7b7be7e80c9dc8ad9bb795433c6cb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Fix order of DB operations in RefreshHostDevicesCommand
by ofrenkel＠redhat.com 16 Sep '15

16 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: Fix order of DB operations in RefreshHostDevicesCommand ...................................................................... core: Fix order of DB operations in RefreshHostDevicesCommand We need to first * Add new devices * Update existing (with new parent) * Remove disappeared devices safely (since no one points its parent on it) To prevent foreign key violation on parent column. Change-Id: Ie85680d02632e2ff45fbabee654ba7cfb66d6e99 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261877 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie85680d02632e2ff45fbabee654ba7cfb66d6e99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Host sort not working
by oourfali＠redhat.com 16 Sep '15

16 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Host sort not working ...................................................................... webadmin: Host sort not working - The code that unifies the fence agents on the hosts would not preserver the order in which the hosts were returned from the query, which resulted in the sorting not working properly. This patch simplies the mechanism to unify the fence agents while preserving the order. Change-Id: I1bda06931812ed0dca4ecab8dd956e5b5c1e9686 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1249607 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java 1 file changed, 21 insertions(+), 25 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bda06931812ed0dca4ecab8dd956e5b5c1e9686 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Use only public schema in engine db infra
by oourfali＠redhat.com 16 Sep '15

16 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Use only public schema in engine db infra ...................................................................... core: Use only public schema in engine db infra Uses only public schema in engine database infrastructure to prevent name collisions with objects in custom schemas. Change-Id: I63960963615b5b8d9d435c84bf8cde8e84f0b5e0 Bug-Url: https://bugzilla.redhat.com/1262831 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/create_functions.sql M packaging/dbscripts/upgrade/03_04_0090_move_quota_id.sql M packaging/dbscripts/upgrade/03_04_0540_remove_storage_pool_type.sql M packaging/dbscripts/upgrade/03_06_1780_create_storage_server_connection_extension_table.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/upgrade/pre_upgrade/0020_add_materialized_views_table.sql 7 files changed, 14 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63960963615b5b8d9d435c84bf8cde8e84f0b5e0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0