Change in ovirt-hosted-engine-ha[master]: brokerlink: ensuring that makefile is working in blocking mode
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: brokerlink: ensuring that makefile is working in blocking mode
......................................................................
brokerlink: ensuring that makefile is working in blocking mode
socket.makefile() requires a socket in blocking mode.
Enforcing it.
Change-Id: I8379d0be600efb1e50b9e291ccfba5fc61143f20
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/brokerlink.py
M ovirt_hosted_engine_ha/lib/util.py
3 files changed, 15 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8379d0be600efb1e50b9e291ccfba5fc61143f20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: frontend: Show all pinned hosts in general model forms
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Show all pinned hosts in general model forms
......................................................................
frontend: Show all pinned hosts in general model forms
A vm can be pinned to multiple VMs. Only one of them was shown. Show
them as a comma separated list of all host names, including a tooltip.
Affected locations are:
* General overview tab for VMs (AdminPortal)
* General overview tab for VMs (UserPortal)
* General overview tab for Pools (AdminPortal)
* General overview tab for Pools (UserPortal)
Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999
Bug-Url: https://bugzilla.redhat.com/1256683
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
(cherry picked from commit 63e0045341b55b2ca0d506a09837a35302f3ab5c)
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java
6 files changed, 29 insertions(+), 7 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Roman Mohr: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45849
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e9b8e5288efb5ea5f612e93e6361685b7f32999
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Initialize volume for volume classification.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Initialize volume for volume classification.
......................................................................
core: Initialize volume for volume classification.
Cloned Cinder disk should have volume classification specified as volume.
Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee
Bug-Url: https://bugzilla.redhat.com/1255221
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CloneSingleCinderDiskCommand.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/45901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76094a8220e93ce26d109d6a10834d58f8d6acee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: Ensure a role network has an IP
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Ensure a role network has an IP
......................................................................
engine: Ensure a role network has an IP
Add validation that ensures that a role bearing network has IP on all
NICs it's attached to.
Change-Id: I6ba52ba7d60307c40584a1b3e5e55be6cef43350
Bug-Url: https://bugzilla.redhat.com/1163365
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AddClusterNetworkClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AddClusterNetworkClusterValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkClusterValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTestBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateClusterNetworkClusterValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkClusterValidatorTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
26 files changed, 337 insertions(+), 133 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ba52ba7d60307c40584a1b3e5e55be6cef43350
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-hosted-engine-ha[master]: Do not start services, let systemd take care of that
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Do not start services, let systemd take care of that
......................................................................
Do not start services, let systemd take care of that
RHEL 6 did not have any proper service monitoring and so we did
it by ourselves. RHEL 7 is the only supported system now and we
have systemd available so now we have two programs that are trying
to monitor and restart vdsmd and sanlock (us and systemd).
This causes trouble when there is a valid reason for keeping them
down - like during upgrade - and so this patch changes the behaviour
to just monitor and wait.
No services will be started by the agent, the fact that something
is not running will be logged and the agent will try later. This
won't increment the FSM error counters either so the agent won't
ever quit while waiting (unless stopped properly or killed by
other error).
Change-Id: I1178aff984d68739e3d42b582589d376b56f45c1
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M initscripts/ovirt-ha-agent.service
M ovirt_hosted_engine_ha/agent/hosted_engine.py
2 files changed, 41 insertions(+), 22 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45842
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1178aff984d68739e3d42b582589d376b56f45c1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: webadmin: races in pool edit
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: races in pool edit
......................................................................
webadmin: races in pool edit
2 bugs:
1 if the pool was not based on the latest template the model was not properly
inited
2 initTemplate() was called in init - but it triggered (async) the
templateWithVersion_SelectedItemChanged and in parallel the clusters are
loaded. If the clusters were set up before the
templateWithVersion_SelectedItemChanged was called, it was ok. If the opposite
way around, NPE was thrown
Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7
Bug-Url: https://bugzilla.redhat.com/1260917
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for next development iteration
......................................................................
sdk: Prepare for next development iteration
In preparation for the next development iteration this patch increases
the version number, adds the SNAPSHOT suffix to the maven version and
sets the RPM release number to 0.1.
Change-Id: Idf05b518efd5f8aec75590619184c25db624a21e
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/Makefile
M sdk/pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idf05b518efd5f8aec75590619184c25db624a21e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Release 3.6.0.1
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Release 3.6.0.1
......................................................................
sdk: Release 3.6.0.1
Change-Id: I74be67700b3fabd8c2f1ce79b8ce12fb6864e747
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/Makefile
M sdk/pom.xml
M sdk/spec.el6.in
M sdk/spec.el7.in
M sdk/spec.fc20.in
M sdk/spec.fc21.in
M sdk/spec.fc22.in
7 files changed, 32 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74be67700b3fabd8c2f1ce79b8ce12fb6864e747
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Regenerate against the latest API
......................................................................
sdk: Regenerate against the latest API
This patch regenerates the SDK using the latest API obtained from
the engine built from commit bcc44ff, tag ovirt-engine-3.6.0_beta5.
Change-Id: I3860cbc2eb13aed6679f7cefe9c7535080c99b05
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/src/main/resources/api.xsd
M generator/src/main/resources/rsdl.xml
M sdk/Makefile
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQoS.java
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQoSs.java
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/ExternalHostProvider.java
M sdk/src/main/java/org/ovirt/engine/sdk/decorators/OpenStackImageProvider.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/Action.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/HostNIC.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/Network.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/NetworkAttachment.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/QoS.java
M sdk/src/main/java/org/ovirt/engine/sdk/entities/ReportedConfiguration.java
13 files changed, 369 insertions(+), 53 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3860cbc2eb13aed6679f7cefe9c7535080c99b05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine-sdk[sdk_3.6]: sdk: Prepare for next development iteration
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for next development iteration
......................................................................
sdk: Prepare for next development iteration
In preparation for the next development iteration this patch
increases the version number and sets the RPM relase number to 0.1.
Change-Id: Ifce78a4559724dfe68fabbc69ac6118c5c5b5373
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M setup.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/45914
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifce78a4559724dfe68fabbc69ac6118c5c5b5373
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month