Change in ovirt-engine[master]: pki: remove ssh-keygen hacks
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: pki: remove ssh-keygen hacks
......................................................................
pki: remove ssh-keygen hacks
ssh-keygen hacks were introduced to bridge the gap of el6 old and
patched ssh-keygen.
we no longer support el6 so these hacks can be removed in favor of
standard ssh-keygen.
Change-Id: I9d50ae2f654175e6eae03fc89266c46b2a265501
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
M packaging/bin/pki-enroll-openssh-cert.sh
D packaging/bin/pki-ssh-keygen.py
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py
6 files changed, 45 insertions(+), 127 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d50ae2f654175e6eae03fc89266c46b2a265501
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: encode non-ASCII disk alias/description
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: encode non-ASCII disk alias/description
......................................................................
core: encode non-ASCII disk alias/description
Patch Ie2642ae7 causes the disk alias and description to be stored in
the disk's metadata. Since vdsm expects for ASCII characters only, and
since both fields can contain non-ASCII characters, the operation fails
on vdsm.
This patch encodes these fields if they contain non-ASCII characters
using HEX encoding (and decodes when reading them), so that vdsm can
handle these fields even if they contain non-ASCII characters.
Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e
Bug-Url: https://bugzilla.redhat.com/1249130
Bug-Url: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
3 files changed, 205 insertions(+), 34 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3180ea2458ca9bd426513108e741dd0f56c8b96e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup:avoid asking cluster name on automatic depl...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup:avoid asking cluster name on automatic deployment
......................................................................
packaging: setup:avoid asking cluster name on automatic deployment
If the user selected to automatically execute engine-setup on the
appliace for sure we have just the Default cluster so asking is
just a waste of time.
Bug-Url: https://bugzilla.redhat.com/1260161
Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 7133664b357516b9cc85af303e7badd583ae06e9)
---
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45902
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: limit disk alias and description for disk metadata
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: limit disk alias and description for disk metadata
......................................................................
core: limit disk alias and description for disk metadata
On block storage, the disk metadata is limited to 512 bytes.
Since we store its alias and description in the metadata, we should
limit their size or else they will be truncated by vdsm and we won't be
able to read them.
This patch limits the value of the metadata description field size to a
maximum of 210 bytes. We do it also for file storage in order to prevent
a truncation of the description field when moving a disk from file to
block storage.
Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Bug-Url: https://bugzilla.redhat.com/1258547
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 218 insertions(+), 18 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45899
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d04291bbaacb5e642d8658ab752b1a8d32c0ac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: implement MetadataDiskDescriptionHandler as a singleton
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: implement MetadataDiskDescriptionHandler as a singleton
......................................................................
core: implement MetadataDiskDescriptionHandler as a singleton
This patch is re-implementing MetadataDiskDescriptionHandler to be a
singleton so that it would be easier to test it.
Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
5 files changed, 15 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2832b4803d9a2b96a0e63973e0571c1b46892d3e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: create MetadataDiskDescriptionHandler
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: create MetadataDiskDescriptionHandler
......................................................................
core: create MetadataDiskDescriptionHandler
This patch moves the logic regarding reading and writing the disk
description in its metadata to a separate class.
Change-Id: I1fb296980a737dfdd279d73615c4943d84de588b
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MetadataDiskDescriptionHandlerTest.java
7 files changed, 89 insertions(+), 59 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45897
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fb296980a737dfdd279d73615c4943d84de588b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: improve disk description encode/decode API
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: improve disk description encode/decode API
......................................................................
core: improve disk description encode/decode API
This patch changes the methods that encode and decode the disk
description to json to get the disk itself instead of its values.
Change-Id: I49aaaf07fe5be36bd9708c1860db7417b8e0efa0
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUnregisteredDiskQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
7 files changed, 31 insertions(+), 27 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49aaaf07fe5be36bd9708c1860db7417b8e0efa0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: remove duplicate code from tests in ImagesHandlerTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove duplicate code from tests in ImagesHandlerTest
......................................................................
core: remove duplicate code from tests in ImagesHandlerTest
Change-Id: If0fbb1d7c5e72103ba6df8869bdc2c2415fca180
Related-To: https://bugzilla.redhat.com/1249130
Related-To: https://bugzilla.redhat.com/1219680
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
1 file changed, 11 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/45895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0fbb1d7c5e72103ba6df8869bdc2c2415fca180
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
9 years, 1 month
Change in ovirt-hosted-engine-setup[master]: packaging: setup:avoid asking cluster name on automatic depl...
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup:avoid asking cluster name on automatic deployment
......................................................................
packaging: setup:avoid asking cluster name on automatic deployment
If the user selected to automatically execute engine-setup on the
appliace for sure we have just the Default cluster so asking is
just a waste of time.
Bug-Url: https://bugzilla.redhat.com/1260161
Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/44733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0fa01648069ad356a427b8517060a69ee64868b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in jenkins[master]: some more fixes to bash script
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: some more fixes to bash script
......................................................................
some more fixes to bash script
Change-Id: I80895ff67f749905b5b8b8a7c3f1d589c30d1366
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/45884
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80895ff67f749905b5b8b8a7c3f1d589c30d1366
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
9 years, 1 month
