Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Refactor AffinityRulesEnforcementManager
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Refactor AffinityRulesEnforcementManager
......................................................................
scheduler: Refactor AffinityRulesEnforcementManager
* Fix check if a VM is still migrating.
* Trigger one migration per cluster instead of one migration per
datacenter.
* Split unit tests in AffinityRulesEnforcementManager tests and
AffinityRulesEnforcementPerCluster tests.
* Remove old tests and added more new ones.
* Remove not fully implemented features:
- lower wakeup frequency when everything is satisfied
- temporary suspension of clusters when too many migration failures occur
They will be added later.
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/MigrationEntryDS.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java
5 files changed, 329 insertions(+), 574 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roman Mohr: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45844
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Add possibility to query for VMs with specific status
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add possibility to query for VMs with specific status
......................................................................
core: Add possibility to query for VMs with specific status
Add a DAO method which allows to query for any VM within a specific
status. For instance query for all VMs which are currently migrating
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: Ief02ac7e5891c556665cd526a975a850634f738a
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDaoTest.java
M packaging/dbscripts/vms_sp.sql
4 files changed, 43 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roman Mohr: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief02ac7e5891c556665cd526a975a850634f738a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Formatter treatment for AffinityRulesEnforcementM...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Formatter treatment for AffinityRulesEnforcementManager
......................................................................
scheduler: Formatter treatment for AffinityRulesEnforcementManager
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: I9829971bdd387a83b526c5b7306fdba25d03a3e1
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcementPerCluster.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
3 files changed, 54 insertions(+), 58 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Roman Mohr: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9829971bdd387a83b526c5b7306fdba25d03a3e1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Let AffinityGroup always return empty lists
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Let AffinityGroup always return empty lists
......................................................................
scheduler: Let AffinityGroup always return empty lists
Sometimes an AffinityGroup is created without VMs in it. Make sure that
all lists it returns are never null for safer usage.
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
(cherry picked from commit 0bc6473e435804c1eff10eb7ee512db3c204d447)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/AffinityGroup.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AffinityGroupDaoTest.java
3 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45741
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b504d99ab0cbe0f37b2eb3429d871aa207584ad
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: engine: old SetupNetworks, NPE when attaching network to hos...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: old SetupNetworks, NPE when attaching network to host NIC
......................................................................
engine: old SetupNetworks, NPE when attaching network to host NIC
NPE in the follwing cases-
1. Just the name of the attached network is passed (not the id).
2. Just the name of the nic is passed.
3. The 'vdsId' is not set on the passed host nic.
Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d
Bug-Url: https://bugzilla.redhat.com/1260430
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
3 files changed, 51 insertions(+), 17 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: new host prefilter dc.
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: new host prefilter dc.
......................................................................
webadmin: new host prefilter dc.
- When selecting a Data Center in the system tree the
available datacenters in the drop down were not being
properly filtered. This patch applies the filtering.
Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1248674
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
1 file changed, 20 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8929ada6590d1d22e9c01f9391889728840892
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in jenkins[master]: fixing script to properly parse params with email and dry-run
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: fixing script to properly parse params with email and dry-run
......................................................................
fixing script to properly parse params with email and dry-run
Change-Id: I74dd2607844344d7ba45727f1abc0f59f6456ec1
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/45883
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74dd2607844344d7ba45727f1abc0f59f6456ec1
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
9 years, 1 month
Change in jenkins[master]: aligning to new git scm template, requiring new param
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: aligning to new git scm template, requiring new param
......................................................................
aligning to new git scm template, requiring new param
- added 'git-server' param
Change-Id: I74cc2de89d1e2d55a1541d5bb1bd7f8af8b6a1df
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74cc2de89d1e2d55a1541d5bb1bd7f8af8b6a1df
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
9 years, 1 month
Change in jenkins[master]: Various Updates to yaml file for abandoning old patches
by eedri@redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Various Updates to yaml file for abandoning old patches
......................................................................
Various Updates to yaml file for abandoning old patches
Fixed hanging indentation.
Updated the job name.
Connect to gerrit server as user jenkins_ro.
Use ssh-agent-credentials wrapper for authentication.
Added scm for jenkins repo inside job defenition.
Fixed syntax errors in scm defenition.
Updated the schedule to run at random minutes after 00:00.
Email dcaro, eedir , iheim and vissree on build failure.
Use 600 days warning and 300 days abandon limits by default.
Pass warning limit and abandon limit as strings.
Add warning limit, abandon limit, test email and dry-run as parameters to the job.
Signed-off-by: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com>
Change-Id: I8fc6ac30b1865e7c389bf5929c73dcb6ba8954ea
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
A jobs/confs/yaml/jobs/system/system_gerrit-alert-old-patches.yaml
1 file changed, 51 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/39357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc6ac30b1865e7c389bf5929c73dcb6ba8954ea
Gerrit-PatchSet: 18
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vishnu Sreekumar <vishnu.srkmr(a)gmail.com>
9 years, 1 month
Change in ovirt-engine[master]: webadmin: Fence agent duplicate ip
by awels@redhat.com
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Fence agent duplicate ip
......................................................................
webadmin: Fence agent duplicate ip
- The code was allowing the user to enter a duplicate
management ip, compared to the existing fence agents.
This would allow one to create duplicate entries that
a lot of the code was not able to handle. This patch
now checks if the management ip address of a new fence
agent is already there.
- Also check the list of existing fence agents when loading
and will remove duplicate management ips from the list.
Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1257575
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
3 files changed, 47 insertions(+), 9 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I419d7acdf98c1cbeec3c18b0c0eb339e9cf25ba7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month