Change in ovirt-engine[master]: core: fix events handling after host reboot
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fix events handling after host reboot
......................................................................
core: fix events handling after host reboot
The engine filters events if it processed newer events already.
It compares the timestamp on each events with the timestamp of
the latest event that came from the same host and has been
processed.
VDSM uses monotonic time for the timestamp on the status
events. The engine relay on the timestamp being monotonic.
However, the timestamp is not monotonic after the host reboots.
The solution is to clear the last host-id that the latest event
that has been processed came from if that host has been
rebooted. That way, we won't use timestamp that has been
received before the host has been rebooted and the next event
will be processed.
Change-Id: Iba99b28312e1b729cd48dda80bac464f32ba7828
Bug-Url: https://bugzilla.redhat.com/1255033
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
3 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/45804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba99b28312e1b729cd48dda80bac464f32ba7828
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: check if pause status is error instead of audit log
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: check if pause status is error instead of audit log
......................................................................
core: check if pause status is error instead of audit log
currently it is decided if to audit log paused vm according to the audit
log value, instead, using the new isError() method in pauseStatus enum.
Change-Id: Ie7e79bb2a1041f7204aa007a80b6eb21ba662bf7
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7e79bb2a1041f7204aa007a80b6eb21ba662bf7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: add audit log for vm that recovered from paused
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add audit log for vm that recovered from paused
......................................................................
core: add audit log for vm that recovered from paused
when vm moves to pause because of error, there is an audit log for it.
added an audit log for the case vm moves to up from paused (because of
error).
Change-Id: I342925c97fadb56999b32c45c321b161459b587e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1171459
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPauseStatus.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
4 files changed, 22 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I342925c97fadb56999b32c45c321b161459b587e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core:fix NPE on edit empty cluster version
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core:fix NPE on edit empty cluster version
......................................................................
core:fix NPE on edit empty cluster version
This patch fixes a NPE when the compatibility version of an empty
cluster is changed
Change-Id: I87434bc41621d8bbf338c28ba5803a3197600e43
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EmulatedMachineClusterEditChecker.java
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45803
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87434bc41621d8bbf338c28ba5803a3197600e43
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: core: Avoid NPEs on illegal LUN disk operations
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Avoid NPEs on illegal LUN disk operations
......................................................................
core: Avoid NPEs on illegal LUN disk operations
Move, copy and export of LUN disks, either attached to a VM or not is not
possible. Using REST, lack of image id and source storage domain resulted in
NPEs. These are now checked before being sent to the engine, while the
appropriate commands check that the disk is not of type LUN (which
applies for all above null scenarios).
Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8
Bug-Url: https://bugzilla.redhat.com/1147861
Bug-Url: https://bugzilla.redhat.com/1147863
Bug-Url: https://bugzilla.redhat.com/1147870
Bug-Url: https://bugzilla.redhat.com/1147873
Bug-Url: https://bugzilla.redhat.com/1147874
Bug-Url: https://bugzilla.redhat.com/1126425
Bug-Url: https://bugzilla.redhat.com/1147860
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MoveDiskModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
16 files changed, 195 insertions(+), 41 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Vered Volansky: Verified
--
To view, visit https://gerrit.ovirt.org/45776
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6de6615cd8f154b9c348055e65d153c9da0f12e8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[ovirt-engine-3.6]: frontend: Localize ArchitectureType.undefined
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Localize ArchitectureType.undefined
......................................................................
frontend: Localize ArchitectureType.undefined
Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1089607
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
3 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/45798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0ab3ed150e4a09f8f96e204e7ea43c4a418a124
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: core: Added sorting to AREM
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Added sorting to AREM
......................................................................
core: Added sorting to AREM
- Affinity Rules Enforcement manager need to make sure that affinity
groups are sorted first by affinity group's size (From largest to
smallest) and then by first VM's Guid. That's why we use GuidComparator
to sort the affinity groups.
- Added unit tests to check correct sorting.
Change-Id: Id9908810a7f373a8098a6765e1c8f95e53af1a0a
Bug-Url: https://bugzilla.redhat.com/1254627
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java
3 files changed, 69 insertions(+), 9 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/42633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id9908810a7f373a8098a6765e1c8f95e53af1a0a
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: scheduler: Refactor AffinityRulesEnforcementManager
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduler: Refactor AffinityRulesEnforcementManager
......................................................................
scheduler: Refactor AffinityRulesEnforcementManager
* Fix check if a VM is still migrating.
* Trigger one migration per cluster instead of one migration per
datacenter.
* Split unit tests in AffinityRulesEnforcementManager tests and
AffinityRulesEnforcementPerCluster tests.
* Remove old tests and added more new ones.
* Remove not fully implemented features:
- lower wakeup frequency when everything is satisfied
- temporary suspension of clusters when too many migration failures occur
They will be added later.
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/MigrationEntryDS.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java
5 files changed, 332 insertions(+), 575 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/44804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8921baa3b5335103d8dc0cd31eed094eb025cba1
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
Change in ovirt-engine[master]: webadmin: not possible to create a VM from userportal
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: not possible to create a VM from userportal
......................................................................
webadmin: not possible to create a VM from userportal
The problem was that the MaxIoThreadsPerVm was not a user query but was needed
in user portal
Change-Id: Ieaf6bb391eb9a0248f6a31bc75ec8d417d05f23a
Bug-Url: https://bugzilla.redhat.com/1259776
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf6bb391eb9a0248f6a31bc75ec8d417d05f23a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 1 month
