September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Introduce PersistentHostSetupNetworksParameters
by alkaplan＠redhat.com 03 Sep '15

03 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Introduce PersistentHostSetupNetworksParameters ...................................................................... engine: Introduce PersistentHostSetupNetworksParameters Needed for proper logging of the modified networks. Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e Bug-Url: https://bugzilla.redhat.com/11942971 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllHostNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentHostSetupNetworksParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 85 insertions(+), 7 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Introduce NetworkNameFromNetworkAttachmentTransformati...
by alkaplan＠redhat.com 03 Sep '15

03 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: Introduce NetworkNameFromNetworkAttachmentTransformationFunction ...................................................................... core: Introduce NetworkNameFromNetworkAttachmentTransformationFunction Will transform a network name from a given NetworkAttachment in case it exist, otherwise, will tranform to the given NetworkAttachment id. Change-Id: I16f0696e1fb5ff9b4a293e7ad03935f97ab88d10 Bug-Url: https://bugzilla.redhat.com/11942971 Signed-off-by: Eliraz Levi <elevi(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunction.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunctionTest.java 2 files changed, 83 insertions(+), 0 deletions(-) Approvals: Eliraz Levi: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16f0696e1fb5ff9b4a293e7ad03935f97ab88d10 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: vdsm: fix prefix issues
by sbonazzo＠redhat.com 03 Sep '15

03 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: fix prefix issues ...................................................................... vdsm: fix prefix issues fix prefix issues while building vdsm rpms. Change-Id: I57a94137bfefd9f8cdba5c2a9af90d162d231dd9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1259282 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_create-rpms.yaml M jobs/confs/projects/vdsm/vdsm_create_libgfapi-rpms.yaml 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Anton Marchukov: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57a94137bfefd9f8cdba5c2a9af90d162d231dd9 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in jenkins[master]: Fixed option passing to ./configure by extra_configure_options
by sbonazzo＠redhat.com 03 Sep '15

03 Sep '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fixed option passing to ./configure by extra_configure_options ...................................................................... Fixed option passing to ./configure by extra_configure_options During debugging it was found that we pass all options essentially like one large option due to exra quotes. E.g. this break vdsm prefix patch: https://gerrit.ovirt.org/#/c/45079/ Change-Id: I38cf752fe5b4ee9613a37a7a665eb6cb25c55a8a Signed-off-by: Anton Marchukov <amarchuk(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh M jobs/confs/shell-scripts/build_mock_srcrpm.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Anton Marchukov: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38cf752fe5b4ee9613a37a7a665eb6cb25c55a8a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: renaming methods to match java standard
by oourfali＠redhat.com 03 Sep '15

03 Sep '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: renaming methods to match java standard ...................................................................... core: renaming methods to match java standard Change-Id: I59e63d3a81c4a65032a362e0fffe114db7fb09d7 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AddVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/IsVmDuringInitiatingVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RemoveVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVmStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/HttpImageTaskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CancelMigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 26 files changed, 87 insertions(+), 82 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e63d3a81c4a65032a362e0fffe114db7fb09d7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Fixed Total Cpus in "NUMA Topology".
by rgolan＠redhat.com 03 Sep '15

03 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Fixed Total Cpus in "NUMA Topology". ...................................................................... webadmin: Fixed Total Cpus in "NUMA Topology". In the NUMA Topology windows, The Total Cpus was calculated without taking into account the number of sockets. So now it is multiplied with the number of sockets. Change-Id: I616a31182fb8cccdfa946e51ea92f0196ae388aa Bug-Url: https://bugzilla.redhat.com/1226896 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/45608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I616a31182fb8cccdfa946e51ea92f0196ae388aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: add ssh_public_key_id
by ofrenkel＠redhat.com 02 Sep '15

02 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: add ssh_public_key_id ...................................................................... core: add ssh_public_key_id Next patch wants to expose SSH key configurations to REST API. To properly support this, we need to have per-key GUID, so this patch add the field to UserProfile, until we split out proper SSH public key entity. Noteworthy addition: SSH Public Key and its ID must always be updated together. Change-Id: I02ed638971c2aa45edb48fc7d3a6942f061356f5 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UserProfileParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/03_06_1810_add_ssh_public_key_id_to_user_profiles_table.sql M packaging/dbscripts/user_profiles_sp.sql 9 files changed, 46 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02ed638971c2aa45edb48fc7d3a6942f061356f5 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Fill VDSM volumes with zeros before using them for the first...
by msivak＠redhat.com 02 Sep '15

02 Sep '15

Martin Sivák has submitted this change and it was merged. Change subject: Fill VDSM volumes with zeros before using them for the first time ...................................................................... Fill VDSM volumes with zeros before using them for the first time VDSM does not initialize iSCSI volumes to clean state and that causes issues when trying to read the metadata from it. The agent fails to parse random blocks since there are some random data and the checksum does not match. Change-Id: Ifa35e575c7e9405474562813aaa56d71b27791d6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1238823 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/storage_backends.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa35e575c7e9405474562813aaa56d71b27791d6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.2 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Adding ovirt node iso 3.6 build
by tlitovsk＠redhat.com 02 Sep '15

02 Sep '15

Anatoly Litovsky has submitted this change and it was merged. Change subject: Adding ovirt node iso 3.6 build ...................................................................... Adding ovirt node iso 3.6 build Fixing the publishers to pick the correct jobs for 3.6 Fixing the iso builder to use the 3.6 branch Change-Id: I5b3a5c56499855ab7edf672c178ef43a4ed40210 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt-node/ovirt-node-job.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Fabian Deutsch: Looks good to me Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/45655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b3a5c56499855ab7edf672c178ef43a4ed40210 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI

1 0

Change in ovirt-engine[master]: core: simplify RemoveUserProfileCommand
by ofrenkel＠redhat.com 02 Sep '15

02 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: simplify RemoveUserProfileCommand ...................................................................... core: simplify RemoveUserProfileCommand RemoveUserProfileCommand had too complex check logic which never triggered. The problem is that client code always use UserID as key, and it may not know (and care about) the profile ID. This patch simplifies the code without making the command less correct: like the other UserProfileCommands, any logged user can only change its own profile. Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Bug-Url: https://bugzilla.redhat.com/1254445 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java 4 files changed, 17 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie08dd783be8e60207ef49bf98fd991b357391fd7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0