Change in ovirt-engine[master]: core: userprofile: handle guid != userid
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: userprofile: handle guid != userid
......................................................................
core: userprofile: handle guid != userid
frontend never fills the userId into UserProfileParameters,
relying on two facts:
- user is logged and implicit in every webadmin/userportal session
- that backend will always and only manipulate the profile of the
current user, discarding any value is passed.
A future patch will add RESTAPI support for key manipulation,
and RESTAPI can transparently pass any guid, and backend must
explicitely return error if user is not allowed to make changes.
This patch enhances userprofile support to accomodate both frontend
and RESTAPI needs.
Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f
Bug-Url: https://bugzilla.redhat.com/1254445
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
1 file changed, 11 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: add query to support restapi
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add query to support restapi
......................................................................
core: add query to support restapi
RESTAPI will expose ssh public key as collection - not as single
instance, to be future compatible.
However, backend knows there is at most one key, embedded inside the
UserProfile.
This patch fills the gap, returning a list of UserProfiles to fit
restapi needs.
The most correct approach would be to return a list of backend'
SSHPublicKeys, but backend has not this Class yet.
Change-Id: Ie39404e9eccb15480f79e4438489b8aa0e0895df
Bug-Url: https://bugzilla.redhat.com/1254445
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserProfileAsListQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie39404e9eccb15480f79e4438489b8aa0e0895df
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: update power8 model name to correct one
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: update power8 model name to correct one
......................................................................
core: update power8 model name to correct one
libvirt expects model_POWER8 instead of model_power8
Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1256021
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Martin Polednik: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/45251
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-reports[master]: build: after build reports for 3.6.0 beta4
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.0 beta4
......................................................................
build: after build reports for 3.6.0 beta4
Change-Id: Ib41b6604f3ae9c6bac87ec5f9af5cfbb48761193
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45669
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41b6604f3ae9c6bac87ec5f9af5cfbb48761193
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-reports[master]: build: build reports for 3.6.0 beta4
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: build reports for 3.6.0 beta4
......................................................................
build: build reports for 3.6.0 beta4
Change-Id: I14f9631ca93b6641f95c362748cd6d72e870142d
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M ovirt-engine-reports.spec.in
M version.mak
2 files changed, 7 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14f9631ca93b6641f95c362748cd6d72e870142d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: Remove redundant code at Cinder call back
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Remove redundant code at Cinder call back
......................................................................
core: Remove redundant code at Cinder call back
Remove unused dao APIs at RemoveCinderSnapshotCommandCallback.
Change-Id: I2b1a61575d324aa7c529b2f7c32e0fae03147142
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderSnapshotCommandCallback.java
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/45628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b1a61575d324aa7c529b2f7c32e0fae03147142
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[master]: core: Add possibility to query for VMs with specific status
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Add possibility to query for VMs with specific status
......................................................................
core: Add possibility to query for VMs with specific status
Add a DAO method which allows to query for any VM within a specific
status. For instance query for all VMs which are currently migrating.
Change-Id: I8a38e60ceafe649b0de0312e1121b746b4289b8a
Bug-Url: https://bugzilla.redhat.com/1251742
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java
M packaging/dbscripts/vms_sp.sql
4 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a38e60ceafe649b0de0312e1121b746b4289b8a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-dwh[master]: build: after dwh for 3.6 beta4
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: after dwh for 3.6 beta4
......................................................................
build: after dwh for 3.6 beta4
Change-Id: I15c22b2baefdcd917c06f1ef53484ce82d9e7072
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M version.mak
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15c22b2baefdcd917c06f1ef53484ce82d9e7072
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-dwh[master]: build: dwh build for 3.6 beta4
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: build: dwh build for 3.6 beta4
......................................................................
build: dwh build for 3.6 beta4
Change-Id: I6884c33213feb8a6f3fb57f4bee4fb27695938ab
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M ovirt-engine-dwh.spec.in
M version.mak
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45662
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6884c33213feb8a6f3fb57f4bee4fb27695938ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-reports[ovirt-engine-reports-3.5]: reports: fixed issues with network interfaces chart in br2a
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed issues with network interfaces chart in br2a
......................................................................
reports: fixed issues with network interfaces chart in br2a
Also fixed disk\nics charts in br10a
Change-Id: Iad4661c419a3247396ac490599107dc3d220bcba
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1209999
---
M packaging/ovirt-reports/resources/Reports/Trend/Hosts/single_host_resource_br2a_files/single_host_resource_br2a_jrxml.data
M packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data
2 files changed, 74 insertions(+), 46 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad4661c419a3247396ac490599107dc3d220bcba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: ovirt-engine-reports-3.5
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months