Change in ovirt-hosted-engine-ha[master]: hosted-engine: hosted-engine client, with storage connection...
by msivak@redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: hosted-engine: hosted-engine client, with storage connection timeout
......................................................................
hosted-engine: hosted-engine client, with storage connection timeout
When a hosted-engine client (cli or broker) is requesting status from hosted engine vm and there is
no connection to storage domain. The client is hanging indefinalty, waiting
for response.
The fix is
1. Added timeout using socket's select, In lib.util.socket_readline
2. Modified lib.brokerlink._communicate() to use timed read requestes.
3. Add OSError exception trap on storage connection. Trapping mounting errors.
Assuring the broker caller recieves applicative errors response.
Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d
Bug-Url: http://bugzilla.redhat.com/1208489
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M ovirt_hosted_engine_ha/broker/storage_broker.py
M ovirt_hosted_engine_ha/env/constants.py.in
M ovirt_hosted_engine_ha/lib/brokerlink.py
M ovirt_hosted_engine_ha/lib/brokerlink_test.py
M ovirt_hosted_engine_ha/lib/util.py
5 files changed, 33 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Dudi Maroshi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/40392
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: core: update power8 model name to correct one
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: update power8 model name to correct one
......................................................................
core: update power8 model name to correct one
libvirt expects model_POWER8 instead of model_power8
Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1256021
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4df9d697e086511822e34d1a250528e1e0ec9734
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce PersistentHostSetupNetworksParameters
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Introduce PersistentHostSetupNetworksParameters
......................................................................
engine: Introduce PersistentHostSetupNetworksParameters
Needed for proper logging of the modified networks.
Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e
Bug-Url: https://bugzilla.redhat.com/1194297
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllHostNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentHostSetupNetworksParameters.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 85 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0387b64f89e02f2e0e3561e6322c0a5cdbbdba5e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Introduce NetworkNameFromNetworkAttachmentTransformati...
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Introduce NetworkNameFromNetworkAttachmentTransformationFunction
......................................................................
core: Introduce NetworkNameFromNetworkAttachmentTransformationFunction
Will transform a network name from a given
NetworkAttachment in case it exist, otherwise,
will tranform to the given NetworkAttachment id.
Change-Id: I16f0696e1fb5ff9b4a293e7ad03935f97ab88d10
Bug-Url: https://bugzilla.redhat.com/11942971
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunction.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunctionTest.java
2 files changed, 83 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16f0696e1fb5ff9b4a293e7ad03935f97ab88d10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: adding sync all networks button
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: adding sync all networks button
......................................................................
webadmin: adding sync all networks button
Adding new button to SubTabHostInterface. The
button will allow to sync all host's networks at
once by calling SyncAllHostNetworks Vdc command
Change-Id: Ic8ade04016cfe0cec9cb8190637dac7983ec262a
Bug-Url: https://bugzilla.redhat.com/1194297
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/help/HelpTag.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
5 files changed, 83 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8ade04016cfe0cec9cb8190637dac7983ec262a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce syncAllHostNetwork command
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Introduce syncAllHostNetwork command
......................................................................
engine: Introduce syncAllHostNetwork command
the command will sync all host's networks using
PersistentHostSetupCommand
Change-Id: I200bd53d77d15a11a3279d2aa147b92fc8791b95
Bug-Url: https://bugzilla.redhat.com/1194297
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllHostNetworksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/predicate/NetworkNotInSyncPredicate.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/predicate/NetworkNotInSyncPredicateTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
6 files changed, 126 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I200bd53d77d15a11a3279d2aa147b92fc8791b95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Introduce PersistentHostSetupNetworks command
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Introduce PersistentHostSetupNetworks command
......................................................................
engine: Introduce PersistentHostSetupNetworks command
A replacement to the old
PersistentSetupNetworkCommand.
Change-Id: I659e432be1e2e1e1883811d59badf08558982944
Bug-Url: https://bugzilla.redhat.com/1194297
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
(cherry picked from commit 39d270a3bfc88dfae97587179f3aca17d4e4674e)
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 68 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45642
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I659e432be1e2e1e1883811d59badf08558982944
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: adding CTOR for GetNetworkAttachmentsByHostIdQuery
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: adding CTOR for GetNetworkAttachmentsByHostIdQuery
......................................................................
engine: adding CTOR for GetNetworkAttachmentsByHostIdQuery
Change-Id: Ie267270e69964248a5ca8fcb479eaa97a75bfd95
Bug-Url: https://bugzilla.redhat.com/1194297
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
(cherry picked from commit 5a3878513f7f70e7757a56372c90bc4f1d319b64)
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/45641
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie267270e69964248a5ca8fcb479eaa97a75bfd95
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: exttool: aaa: add key filter and format
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: exttool: aaa: add key filter and format
......................................................................
exttool: aaa: add key filter and format
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762
Change-Id: I02b52c633406006c0d71b809477076b61c1fc655
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java
M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/aaa/arguments.properties
2 files changed, 71 insertions(+), 34 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45697
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02b52c633406006c0d71b809477076b61c1fc655
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months
Change in ovirt-engine[ovirt-engine-3.6]: exttool: info: support output format
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: exttool: info: support output format
......................................................................
exttool: info: support output format
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1177762
Change-Id: I8494ee7c03f6a5072335415d8558cf3cc4a1b7a7
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java
M backend/manager/extensions-tool/src/main/resources/org/ovirt/engine/exttool/core/info.properties
2 files changed, 23 insertions(+), 6 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45696
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8494ee7c03f6a5072335415d8558cf3cc4a1b7a7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 8 months