January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-java[sdk_3.6]: sdk: Send version header
by juan.hernandez＠redhat.com 20 Jan '16

20 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Send version header ...................................................................... sdk: Send version header This patch changes the SDK so that all requests indicate explicitly the requested version of the API, using the "Version" header. Version: 3 Change-Id: I2e2c810f6c750b1dc2c9870065b4a4d514824a9f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52510 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2c810f6c750b1dc2c9870065b4a4d514824a9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Send version header
by juan.hernandez＠redhat.com 20 Jan '16

20 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Send version header ...................................................................... sdk: Send version header This patch changes the SDK so that all requests indicate explicitly the requested version of the API, using the "Version" header: Version: 3 Change-Id: I0185c41eea040c3a90eae03408a14e6eb9c68d54 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0185c41eea040c3a90eae03408a14e6eb9c68d54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix of merging of VmDynamics form DB and VDSM
by ahadas＠redhat.com 20 Jan '16

20 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Fix of merging of VmDynamics form DB and VDSM ...................................................................... core: Fix of merging of VmDynamics form DB and VDSM Method VM.updateRunTimeDynamicData() only added new elemnts of property graphicsInfos instead of completely accepting new value. This caused inconsistency between vm_device (type graphics) and vm_dynamic (spice_*, vnc_*) tables. Now runtime info (`this`) is updated according to VDSM info (method parameter `vm`). It allows to remove graphicsInfo entry. E.g. if runtime info contains 'SPICE+VNC' and VDSM reports only 'VNC', the runtime info is updated to 'VNC' whereas previous code erroneously kept 'SPICE+VNC'. Graphics info upgrade script doesn't update vm_dynamic content table any more. Proper values will be automaticall inserted during first VDSM poll. Removed updated queries could introduce wrong grapnics info in vm_dynamic table if VM was started using 'Run Once' with changed graphics protocol. Change-Id: If835f2502bc37d1d94ceea92879d2b3e7bf5f95f Bug-Url: https://bugzilla.redhat.com/1297404 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M packaging/dbscripts/upgrade/03_06_0590_add_graphics_info_columns.sql 2 files changed, 1 insertion(+), 14 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51870 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If835f2502bc37d1d94ceea92879d2b3e7bf5f95f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: Send version header
by juan.hernandez＠redhat.com 20 Jan '16

20 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Send version header ...................................................................... sdk: Send version header This patch changes the SDK so that all requests indicate explicitly the requested version of the API, using the "Version" header. Version: 4 Change-Id: I2e2c810f6c750b1dc2c9870065b4a4d514824a9f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e2c810f6c750b1dc2c9870065b4a4d514824a9f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: sdk: Send version header
by juan.hernandez＠redhat.com 20 Jan '16

20 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Send version header ...................................................................... sdk: Send version header This patch changes the SDK so that all requests indicate explicitly the requested version of the API, using the "Version" header: Version: 4 Change-Id: I0185c41eea040c3a90eae03408a14e6eb9c68d54 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/connectionspool.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0185c41eea040c3a90eae03408a14e6eb9c68d54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Added fontend null checks
by vszocs＠redhat.com 20 Jan '16

20 Jan '16

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Added fontend null checks ...................................................................... webadmin: Added fontend null checks * Null check added into TagModelProvider.initializeModelHandlers() to prevent NPE. * Null check added into VmSnapshotListModel.updateIsCloneVmSupported() to prevent NPE. Change-Id: I1b5688555ca2cdb95f4dc91ba5494d90709fa4b8 Bug-Url: https://bugzilla.redhat.com/1293269 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TagModelProvider.java 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b5688555ca2cdb95f4dc91ba5494d90709fa4b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Prevent host device copy on pinned host mismatch
by mperina＠redhat.com 20 Jan '16

20 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Prevent host device copy on pinned host mismatch ...................................................................... core: Prevent host device copy on pinned host mismatch When user is creating a VM from pre-existing configuration (Template/Snapshot/Import) and has the ability to override the "pinned-to-host" value, it results in a VM being created with inconsistent host devices attached (device name from old host, but with new host id). Most cases were covered by VmDeviceUtils#copyVmDevices and import by VmDeviceUtils#addImportedOtherDevices. Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281428 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 47 insertions(+), 9 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa99737928d1111b994d7827fd6aade0d249ff28 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: jsonrpc: bump version
by oourfali＠redhat.com 20 Jan '16

20 Jan '16

Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: bump version ...................................................................... jsonrpc: bump version Change-Id: I70d9f274a2d61b324624c19a1b50c8e31b3cd11a Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> Bug-Url: https://bugzilla.redhat.com/1299232 --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70d9f274a2d61b324624c19a1b50c8e31b3cd11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update RPM spec to build alpha 4
by juan.hernandez＠redhat.com 20 Jan '16

20 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update RPM spec to build alpha 4 ...................................................................... Update RPM spec to build alpha 4 This patch updates the RPM build script so that it builds by default the latest released version: alpha 4. Change-Id: I3479b1205fdd86a908bedcfc42d787c58832a7b4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/build.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3479b1205fdd86a908bedcfc42d787c58832a7b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: utils: Remove extra parameters in copyVmDevices
by mperina＠redhat.com 20 Jan '16

20 Jan '16

Martin Peřina has submitted this change and it was merged. Change subject: utils: Remove extra parameters in copyVmDevices ...................................................................... utils: Remove extra parameters in copyVmDevices Passed `dstVm` was only used to getStaticData() which was always the same as another parameter `dstVmBase`. Additionally the dstIsVm parameter value can simply be obtained by checking the type of passed dstVmBase. This will simplify consequent patches. Change-Id: Ida90a2cca906a42b86136840a430765c9ae0b7b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1281428 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 5 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified Shmuel Leib Melamud: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida90a2cca906a42b86136840a430765c9ae0b7b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0