January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userprotal: UserPortalTemplateListModel local var
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: userprotal: UserPortalTemplateListModel local var ...................................................................... userprotal: UserPortalTemplateListModel local var Inline useless local variable. Change-Id: I17679115c5390f19d457264c1681d5b06dcc8200 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17679115c5390f19d457264c1681d5b06dcc8200 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: rename: fixes for vmconsole proxy helper
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: rename: fixes for vmconsole proxy helper ...................................................................... packaging: rename: fixes for vmconsole proxy helper Change-Id: Ia6ed40d6b31dfe891650f6b3b7a648e638b58b3e Bug-Url: https://bugzilla.redhat.com/1290088 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A packaging/setup/plugins/ovirt-engine-rename/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-rename/vmconsole_proxy_helper/config.py 2 files changed, 130 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/51035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6ed40d6b31dfe891650f6b3b7a648e638b58b3e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: cloud_init: local variable 'address' referenced before assig...
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: cloud_init: local variable 'address' referenced before assignment ...................................................................... cloud_init: local variable 'address' referenced before assignment Assign var address to None before trying to manage it. Change-Id: I47358e9686b50bb4057306092a33d29438bce2b7 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> (cherry picked from commit 85c666ccce01dd6bd40ba58a77ceb883bca258d3) --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47358e9686b50bb4057306092a33d29438bce2b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[master]: packaging: rename: Do not fail if reports is not set up
by sradco＠redhat.com 19 Jan '16

19 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: rename: Do not fail if reports is not set up ...................................................................... packaging: rename: Do not fail if reports is not set up Bug-Url: https://bugzilla.redhat.com/1299431 Change-Id: I3f55e531b210d0b14dd68158986eadbef33a6833 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine-reports/engine.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52337 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f55e531b210d0b14dd68158986eadbef33a6833 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: post ovirt-engine-reports-3.5.8
by sradco＠redhat.com 19 Jan '16

19 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-reports-3.5.8 ...................................................................... build: post ovirt-engine-reports-3.5.8 Change-Id: I4d318418f6ac37b3c0ef44572923a2255651ba57 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d318418f6ac37b3c0ef44572923a2255651ba57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[ovirt-engine-reports-3.5]: build: ovirt-engine-reports-3.5.8
by sradco＠redhat.com 19 Jan '16

19 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-reports-3.5.8 ...................................................................... build: ovirt-engine-reports-3.5.8 Change-Id: I87e01aed7f680621c366553a45569613a0cb2e47 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e01aed7f680621c366553a45569613a0cb2e47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.5 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetUnregisteredDisksQueryTest asserts
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetUnregisteredDisksQueryTest asserts ...................................................................... core: GetUnregisteredDisksQueryTest asserts Fixed assertEquals' argument order to get a proper error message in the case of a test failure. Change-Id: Id318adb9a054892715cc8c4fbfc5098ab8ac0680 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52276 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id318adb9a054892715cc8c4fbfc5098ab8ac0680 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetGlusterVolumeRemoveBricksStatusQueryTest members
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetGlusterVolumeRemoveBricksStatusQueryTest members ...................................................................... core: GetGlusterVolumeRemoveBricksStatusQueryTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: Ice4f57f346e1fecd7f6513b1e788b4497c1ed7ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQueryTest.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice4f57f346e1fecd7f6513b1e788b4497c1ed7ae Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetAddedGlusterServersQueryTest members
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetAddedGlusterServersQueryTest members ...................................................................... core: GetAddedGlusterServersQueryTest members Converted members to local variables where possible in order to improve readability and reduce memory footprint. Change-Id: Ie8258adbcb045066db40730f77cba665630863fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetAddedGlusterServersQueryTest.java 1 file changed, 5 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8258adbcb045066db40730f77cba665630863fc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: TemplateGeneralModel getEntity()
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: TemplateGeneralModel getEntity() ...................................................................... webadmin: TemplateGeneralModel getEntity() Since commit 7431bdff introduced a generic specification to TemplateGeneralModel, it is guaranteed in compilation time that the entity type is a VmTemplate, making the current implementation of getEntity() redundant, and safe to simply remove it and rely on the super's implementation. Change-Id: Ibb5a51f51ad31c6820241d91729bb817dc5f264c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb5a51f51ad31c6820241d91729bb817dc5f264c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0