January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: both null and empty gateway should be considered as ...
by oourfali＠redhat.com 19 Jan '16

19 Jan '16

Oved Ourfali has submitted this change and it was merged. Change subject: engine: both null and empty gateway should be considered as no gateway ...................................................................... engine: both null and empty gateway should be considered as no gateway Change-Id: I0442c36bdd6cb30ce880cb5813e2393ace9c009a Bug-Url: https://bugzilla.redhat.com/1298534 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0442c36bdd6cb30ce880cb5813e2393ace9c009a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: both null and empty gateway should be considered as ...
by alkaplan＠redhat.com 19 Jan '16

19 Jan '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: both null and empty gateway should be considered as no gateway ...................................................................... engine: both null and empty gateway should be considered as no gateway Change-Id: I0442c36bdd6cb30ce880cb5813e2393ace9c009a Bug-Url: https://bugzilla.redhat.com/1298534 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52395 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0442c36bdd6cb30ce880cb5813e2393ace9c009a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: make temporary directory default to /var/tmp
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: make temporary directory default to /var/tmp ...................................................................... packaging: setup: make temporary directory default to /var/tmp Change-Id: I9f7fe315cf3aaa24de5fbf85ee3762923bf3768c Bug-Url: https://bugzilla.redhat.com/1251965 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> (cherry picked from commit ea03acffbeb2cb77121799660f4dec287563a753) --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7fe315cf3aaa24de5fbf85ee3762923bf3768c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: host-deploy: attemptConnection() should not throw exceptions
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: host-deploy: attemptConnection() should not throw exceptions ...................................................................... host-deploy: attemptConnection() should not throw exceptions The expected return value of ProtocolDetector.attemptConnection() is a boolean on which the installation process relies. The installation process does not expect this method to throw an exception if the attempt to connect to the host has failed. Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Bug-Url: https://bugzilla.redhat.com/1299232 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: auto-scroll SetupNetworks interfaces list during d...
by tnisan＠redhat.com 19 Jan '16

19 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: auto-scroll SetupNetworks interfaces list during drag-and-drop ...................................................................... webadmin: auto-scroll SetupNetworks interfaces list during drag-and-drop When a host has more the 6 network interfaces, the Setup Host Networks popup dialog needs to scroll to access all of the interfaces. During a drag-and-drop of a logical network or network label, the interface list did not allow scrolling. This patch adds auto-scroll handling so a user can access all of the host's available interfaces. To auto-scroll the interfaces list: 1. start a drag operation on a logical network, label or interface 2. move the mouse pointer close to the top of the interface list to auto scroll the list down 3. move the mouse pointer close to the bottom of the interface list to auto scroll the list up Scroll will stop when the drag operation is complete or the mouse is moved outside the autoscroll zone. Change-Id: I2c6fe977f014309659d5559d4609d9361a43274e Bug-Url: https://bugzilla.redhat.com/1249895 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollAdapter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollDisableEvent.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollEnableEvent.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/AutoScrollOverEvent.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java 6 files changed, 315 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/52390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c6fe977f014309659d5559d4609d9361a43274e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: make temporary directory default to /var/tmp
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: make temporary directory default to /var/tmp ...................................................................... packaging: setup: make temporary directory default to /var/tmp Change-Id: I9f7fe315cf3aaa24de5fbf85ee3762923bf3768c Bug-Url: https://bugzilla.redhat.com/1251965 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/51804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7fe315cf3aaa24de5fbf85ee3762923bf3768c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: resetting spUUID to a random value only if really n...
by sbonazzo＠redhat.com 19 Jan '16

19 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: resetting spUUID to a random value only if really needed ...................................................................... storage: resetting spUUID to a random value only if really needed hosted-engine-setup generates answer file with a blank SP UUID for additional hosts cause it correctly disconnected its SD from the boostrap storage pool. If we want to use the answerfile for not-interactively replaing the scenario we need a valid spUUID value otherwise we are not able to create the bootstrap storage pool. On the other side, passing an answerfile via CLI is a valid alternative instead of download it from another host via scp. And in that case we should honour the BLANK UUID. So resetting spUUID to blank only if really needed to create a new boostrap storage pool. Change-Id: I67569bc6902a176565269f2bcbec569b51549181 Bug-Url: https://bugzilla.redhat.com/1277010 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67569bc6902a176565269f2bcbec569b51549181 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: host-deploy: attemptConnection() should not throw exceptions
by oourfali＠redhat.com 19 Jan '16

19 Jan '16

Oved Ourfali has submitted this change and it was merged. Change subject: host-deploy: attemptConnection() should not throw exceptions ...................................................................... host-deploy: attemptConnection() should not throw exceptions The expected return value of ProtocolDetector.attemptConnection() is a boolean on which the installation process relies. The installation process does not expect this method to throw an exception if the attempt to connect to the host has failed. Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Bug-Url: https://bugzilla.redhat.com/1299232 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f581e973b01d33458e5f6d37830704f3e508b6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: RoleListModel commented out block
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: RoleListModel commented out block ...................................................................... webadmin: RoleListModel commented out block Removed an outdated comment out block of code. Change-Id: I35739378d76446e9cd9cb265ff11b3ec3743b081 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35739378d76446e9cd9cb265ff11b3ec3743b081 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: HostInterfacesListModel boolean logic
by amureini＠redhat.com 19 Jan '16

19 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: HostInterfacesListModel boolean logic ...................................................................... webadmin: HostInterfacesListModel boolean logic Simplify boolean logic to stop using the unreadable idiom of (val == true or val == false). Change-Id: I7ff2c1875d8a3b07d2e52b21c7ad8ea5e79967e9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ff2c1875d8a3b07d2e52b21c7ad8ea5e79967e9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0