Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: Lock the sd import exclusively
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: hosted-engine: Lock the sd import exclusively
......................................................................
core: hosted-engine: Lock the sd import exclusively
Add an exclusive lock on the hosted engine domain import to prevent it
from interleaving. There is a race where the domain might be added but
the TX isn't closed yet and another import can enter and pass the
command validation.
Change-Id: I2b67db78433f3c0847e118ccb279d63a65986b34
Bug-Url: https://bugzilla.redhat.com/1293928
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNFSStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainManagementCommandBase.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommandTest.java
8 files changed, 137 insertions(+), 44 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/51417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b67db78433f3c0847e118ccb279d63a65986b34
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Add the StorageDomainIsMemberOfPool error
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Add the StorageDomainIsMemberOfPool error
......................................................................
engine: Add the StorageDomainIsMemberOfPool error
The StorageDomainIsMemberOfPool error was added to VDSM in commit
418e08fb2ac316d4a664bb151386274bbb2e5774. This patch finishes the job by
adding a mapping in the engine.
Change-Id: Ie7498c034b89d0f0028ebc8b46bc61c938a9375a
Bug-Url: https://bugzilla.redhat.com/1191514
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
4 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/51787
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7498c034b89d0f0028ebc8b46bc61c938a9375a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in jenkins[master]: Move ovirt-node-ng builders to the node-fc21 builder'
by dcaro＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Move ovirt-node-ng builders to the node-fc21 builder'
......................................................................
Move ovirt-node-ng builders to the node-fc21 builder'
Until the issues with nested virt on some hosts are investigated/
resolved, use a dedicated builder label
Change-Id: I162d107db1888b3ee24c281860a2b9e203f85c04
Signed-off-by: Ryan Barry <rbarry(a)redhat.com>
---
M jobs/confs/projects/ovirt-node-ng/ovirt-node-ng.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Fabian Deutsch: Looks good to me
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for merge
Ryan Barry: Looks good to me; Ready for review
--
To view, visit https://gerrit.ovirt.org/51561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I162d107db1888b3ee24c281860a2b9e203f85c04
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: simplify graphics devices handling on update vm
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: simplify graphics devices handling on update vm
......................................................................
core: simplify graphics devices handling on update vm
Change-Id: I1620935611ddae77cb53e6543ad324cf8ce2c9a0
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 16 insertions(+), 38 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1620935611ddae77cb53e6543ad324cf8ce2c9a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in samples-uiplugins[master]: doc update
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: doc update
......................................................................
doc update
Change-Id: Idecb0cdda27b1c30d77996b188253cee655c8ad0
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M foreman-plugin/README
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved; Passed CI tests
Oved Ourfali: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51785
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idecb0cdda27b1c30d77996b188253cee655c8ad0
Gerrit-PatchSet: 2
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
8 years, 11 months
Change in ovirt-engine[master]: engine: Add the StorageDomainIsMemberOfPool error
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Add the StorageDomainIsMemberOfPool error
......................................................................
engine: Add the StorageDomainIsMemberOfPool error
The StorageDomainIsMemberOfPool error was added to VDSM in commit
418e08fb2ac316d4a664bb151386274bbb2e5774. This patch finishes the job by
adding a mapping in the engine.
Change-Id: Ie7498c034b89d0f0028ebc8b46bc61c938a9375a
Bug-Url: https://bugzilla.redhat.com/1191514
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
4 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/51362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7498c034b89d0f0028ebc8b46bc61c938a9375a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: delete Cinder snapshot failover.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: delete Cinder snapshot failover.
......................................................................
core: delete Cinder snapshot failover.
When deleting a Cinder snapshot there is no need to update the active
flag on failure, Cinder snapshot works differently than images so the
active volume with Cinder disk will always be the active one.
Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361
Bug-Url: https://bugzilla.redhat.com/1297842
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveCinderSnapshotDiskCommand.java
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Add TODO once fix will be backported
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add TODO once fix will be backported
......................................................................
core: Add TODO once fix will be backported
Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e5
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1297312
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 11 months
Change in ovirt-engine[master]: core: fixing a problem in upgrade
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing a problem in upgrade
......................................................................
core: fixing a problem in upgrade
The last rename of "vds group" to cluster caused a problem in schema.py
on upgrade, at that point, the script looking for cluster versions does
not have the cluster table and need to use vds_groups.
Solution was adding in an upgrade script a view named vds_groups that
only selects the original cluster table records and revert schema.py to
relate to vds_groups.
This is done in an upgrade script and not in create_views.sql since
eventually when this code will be squashed to the base DB, we will drop
this vds_groups view.
The reason why this error was not found by CI tests is that upgrade jobs
are using schema.sh script directly and not engine-setup which seems to
be problematic.
Change-Id: If230d3cd397c314a27cc78d3837b637b671ba706
Signed-off-by: emesika <emesika(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0210_add_vds_group_view.sql
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Passed CI tests
Daniel Erez: Verified; Looks good to me, approved
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/51784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If230d3cd397c314a27cc78d3837b637b671ba706
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: fetch vm nic statistics from vm analyzers
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fetch vm nic statistics from vm analyzers
......................................................................
core: fetch vm nic statistics from vm analyzers
Change the way VmsMonitoring fetches nic statistics from VM
analyzers: iterate the analyzers using the stream API and get
the statistics instead of the statistics being set inside
VmsMonitoring by the analyzers.
Change-Id: Iedcf057619ce6812442c376f8c3eca948a1b4e5f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
2 files changed, 16 insertions(+), 12 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51628
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedcf057619ce6812442c376f8c3eca948a1b4e5f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
