Change in ovirt-engine[master]: core: Losing graphical protocol fix
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Losing graphical protocol fix
......................................................................
core: Losing graphical protocol fix
The problem was that changing graphical protocol (SPICE, VNC) in setups
with ConfigValues.MultipleGraphicsSupported set to false might cause
to attempt to have multiple graphics devices for a while.
Causes:
1. Operations of adding and removing graphics devices were not ordered.
Now devices are first removed then added.
2. Methods CommandBase#canDoAction()/validate() are by default called
in separate DB transaction. This causes AddGraphicsDeviceCommand
validation method to not being aware of previous device removals.
Fixed by @CanDoActionSupportsTransaction/ValidateSupportsTransaction.
Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac
Bug-Url: https://bugzilla.redhat.com/1297751
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
2 files changed, 36 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Update to latest released versions of model and metamodel
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Update to latest released versions of model and metamodel
......................................................................
Update to latest released versions of model and metamodel
This patch updates the SDK so that it uses the latest released versions
of the model, 4.0.1, and metamodel, 1.0.2.
Change-Id: I7713c1dcb3d051f989f2b95e31d61cb1f775b084
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7713c1dcb3d051f989f2b95e31d61cb1f775b084
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: fetch vm statistics from vm analyzers
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: fetch vm statistics from vm analyzers
......................................................................
core: fetch vm statistics from vm analyzers
Change the way VmsMonitoring fetches VM statistics from VM
analyzers: iterate the analyzers using the stream API and get
the statistics instead of the statistics being set inside
VmsMonitoring by the analyzers.
Change-Id: I028248258e8bfed14ba518bb9970a613abe3cb19
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java
3 files changed, 19 insertions(+), 20 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/51627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I028248258e8bfed14ba518bb9970a613abe3cb19
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Support revert of new Cinder snapshot.
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Support revert of new Cinder snapshot.
......................................................................
core: Support revert of new Cinder snapshot.
Adding revert task when creating Cinder snapshot so the volumes which
were created based on this snapshot will be removed.
Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4
Bug-Url: https://bugzilla.redhat.com/1297312
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CreateCinderSnapshotCommand.java
1 file changed, 28 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51723
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Video RAM size settings reworked
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Video RAM size settings reworked
......................................................................
core: Video RAM size settings reworked
Video RAM sizes are currently set in a wrong way. Especially one of the
most important parameters, `vgamem', is not set at all. That may
prevent setups with high resolution monitors from working.
This patch tries to set more reasonable video RAM sizes. It replaces
the old video RAM size computation (including removal of some unused
related code) with a new one, based on guest OS. The guest OS specifics
are set in osinfo.
We try to keep the computation as simple as possible, for the following
reasons:
1. Nobody can say what the perfect values are.
2. Things are likely to change in QEMU in future.
3. We try to be reasonably conservative not to break current setups.
Note that recent VDSM version is needed to set `vgamem' value (it's
ignored in older versions).
As we can't be sure about all older versions of VDSM, libvirt and QEMU,
we send the same values as before to clusters of older versions. These
may be not the best values but it's the safest approach. We may provide
means to override the memory values via osinfo in a followup patch.
Change-Id: I96ab9d40621ad12ec2505a2de75e3ff5af2f59d0
Bug-Url: https://bugzilla.redhat.com/1275539
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java
M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M packaging/conf/osinfo-defaults.properties
9 files changed, 152 insertions(+), 48 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/51660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96ab9d40621ad12ec2505a2de75e3ff5af2f59d0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: engine: fix find bug error
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: fix find bug error
......................................................................
engine: fix find bug error
Introduced in- Ia8ba807900f15410f3ab43831b5cf965621dd0ef
Change-Id: I8a4c195919683b0614e53433157195f3a1afdf1d
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java
1 file changed, 13 insertions(+), 10 deletions(-)
Approvals:
Alona Kaplan: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51761
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a4c195919683b0614e53433157195f3a1afdf1d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: delete Cinder snapshot failover.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: delete Cinder snapshot failover.
......................................................................
core: delete Cinder snapshot failover.
When deleting a Cinder snapshot there is no need to update the active
flag on failure, Cinder snapshot works differently than images so the
active volume with Cinder disk will always be the active one.
Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361
Bug-Url: https://bugzilla.redhat.com/1297842
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotDiskCommand.java
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If15d65c6db19446aaf50e1fdd846ec6fc57f3361
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: hosted-engine: Add connection details explicitly for NFS
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: hosted-engine: Add connection details explicitly for NFS
......................................................................
core: hosted-engine: Add connection details explicitly for NFS
It is not reliable to assume AddExistingFileStorageDomain command
will create the connection details internally, thus the import HE domain
command calls is prior to importing the domain.
Change-Id: I790d1d22ffe5358b8a0daeb85b004d5a484a4745
Bug-Url: https://bugzilla.redhat.com/1293928
Bug-Url: https://bugzilla.redhat.com/1290518
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java
2 files changed, 42 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I790d1d22ffe5358b8a0daeb85b004d5a484a4745
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: storage: make storagServerConnectin compensatable
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: storage: make storagServerConnectin compensatable
......................................................................
core: storage: make storagServerConnectin compensatable
In order to properly use it in complex flow and use proper rollback
by conpensation, this entity is now compensation ready.
Change-Id: I6d93f4a758cc96d89165dcd29d4df9e31d32ae9a
Bug-Url: https://bugzilla.redhat.com/1293928
Bug-Url: https://bugzilla.redhat.com/1290518
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDao.java
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/51488
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d93f4a758cc96d89165dcd29d4df9e31d32ae9a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months
Change in ovirt-engine[master]: core: stop upgrade when shell script fail
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: stop upgrade when shell script fail
......................................................................
core: stop upgrade when shell script fail
This patch fixes a bug that occurs when we have a shell upgrade script
that fails to execute.
Current behaviour is that the script fails and upgrade process continues
and even generates a SUCCESS result on CI tests.
This patch adds a missing check on the result of running the script and
terminates upgrade procedure if shell script fails with a proper
message.
Change-Id: Ic18a8a567945c4d3e709d28b85691f0e3b67e2e5
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/dbfunc-common.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic18a8a567945c4d3e709d28b85691f0e3b67e2e5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 11 months