Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.3.7
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-1.3.3.7
......................................................................
build: ovirt-hosted-engine-ha-1.3.3.7
Change-Id: Ie897d643c4de866504da207d7ccbcdecad9fc7d6
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51713
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie897d643c4de866504da207d7ccbcdecad9fc7d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: upgrade: fixing for iSCSI additional hosts
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: fixing for iSCSI additional hosts
......................................................................
upgrade: fixing for iSCSI additional hosts
On 3.5 -> 3.6 we need to call getVolumesList to
scan all the available volumes and check if some other
host already created the configuration volume.
After a reboot ovirt-ha-agent calls prepareImage
only on metadata, lockspace and if available on
the configuration image but not on the engine image.
So, only after a reboot and only on iSCSI, getVolumesList
will report an error regarding the engine image.
filtering out know images from the scan,
using metadata image to check the images path,
avoid breaking on getVolumesList errors
Change-Id: I724835de6498fc7098d03499b246fa69b5bf09fe
Bug-Url: https://bugzilla.redhat.com/1297457
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 57 insertions(+), 26 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/51722
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I724835de6498fc7098d03499b246fa69b5bf09fe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-hosted-engine-ha[master]: upgrade: fixing for iSCSI additional hosts
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: upgrade: fixing for iSCSI additional hosts
......................................................................
upgrade: fixing for iSCSI additional hosts
On 3.5 -> 3.6 we need to call getVolumesList to
scan all the available volumes and check if some other
host already created the configuration volume.
After a reboot ovirt-ha-agent calls prepareImage
only on metadata, lockspace and if available on
the configuration image but not on the engine image.
So, only after a reboot and only on iSCSI, getVolumesList
will report an error regarding the engine image.
filtering out know images from the scan,
using metadata image to check the images path,
avoid breaking on getVolumesList errors
Change-Id: I724835de6498fc7098d03499b246fa69b5bf09fe
Bug-Url: https://bugzilla.redhat.com/1297457
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/upgrade.py
1 file changed, 57 insertions(+), 26 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved; Passed CI tests
Simone Tiraboschi: Verified
--
To view, visit https://gerrit.ovirt.org/51658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I724835de6498fc7098d03499b246fa69b5bf09fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: hosted-engine: import the domain only when DC is UP
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: hosted-engine: import the domain only when DC is UP
......................................................................
core: hosted-engine: import the domain only when DC is UP
Most of the setups will be concluded by an engine restart
(configurable). At that stage the import may have already kicked in, and
this race causes -
1) a reboot during the import - may lead to failed
rollback, so we're left with junk in DB
2) An attemt to Attach before we
have an UP host. This leads to a rollback which may lead to closure 1.
As long as we don't attempt to add a data domain during HE setup, this
approch will keep us safe and will import the domain while there isn't a
restart planned.
Change-Id: I2710be830cdb234fbb38456234219389e9299833
Bug-Url: https://bugzilla.redhat.com/1293928
Bug-Url: https://bugzilla.redhat.com/1290518
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java
2 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Passed CI tests
Maor Lipchuk: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/51126
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2710be830cdb234fbb38456234219389e9299833
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: scheduler: Add cpu pinning policy unit
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: scheduler: Add cpu pinning policy unit
......................................................................
scheduler: Add cpu pinning policy unit
Check if a host has all CPUs up and running which are required to
satisfy the pinning requirements of a VM.
Bug-Url: https://bugzilla.redhat.com/1279375
Change-Id: I31f3d41acbd2c0119bc406988650aef3d5879edf
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SlaValidator.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnit.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/CpuPinningHelper.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/CpuPinningValidator.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/utils/CpuPinningHelperTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/CpuPinningValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
18 files changed, 645 insertions(+), 263 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I31f3d41acbd2c0119bc406988650aef3d5879edf
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: Support revert of new Cinder snapshot.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support revert of new Cinder snapshot.
......................................................................
core: Support revert of new Cinder snapshot.
Adding revert task when creating Cinder snapshot so the volumes which
were created based on this snapshot will be removed.
Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4
Bug-Url: https://bugzilla.redhat.com/1297312
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommand.java
1 file changed, 28 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/51606
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6ac83f1df6d149d52870e933de403a7e2f579e4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: core: simplify representation of nic stats in monitoring
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: simplify representation of nic stats in monitoring
......................................................................
core: simplify representation of nic stats in monitoring
Store the VM network interface statistics as a List of statistics intead
of a List of Lists of the network interface in VmsMonitoring simplifies
the code that persists it.
Change-Id: If1980bcf2ee6025861a8c736a1cc4ff9dbe21dde
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
1 file changed, 4 insertions(+), 15 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51626
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1980bcf2ee6025861a8c736a1cc4ff9dbe21dde
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webadmin, userportal: Fix SplitTable double-click on selectio...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix SplitTable double-click on selection column
......................................................................
webadmin,userportal: Fix SplitTable double-click on selection column
Double-clicking item selection (checkbox) column in any of the two
tables (excluded, included) wrapped by SplitTable widget no longer
moves the item, since such double-click is most likely accidental.
Change-Id: Ib13aba78a736ba8198bb59277549ae37cfb207d6
Bug-Url: https://bugzilla.redhat.com/1277209
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
2 files changed, 29 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Verified
--
To view, visit https://gerrit.ovirt.org/48454
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib13aba78a736ba8198bb59277549ae37cfb207d6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-reports[master]: build: after build reports for 3.6.2.3
by sradco＠redhat.com
Shirly Radco has submitted this change and it was merged.
Change subject: build: after build reports for 3.6.2.3
......................................................................
build: after build reports for 3.6.2.3
Change-Id: I891c2121e02b47f09ce97640f2da938f9102c3e4
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M version.mak
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/51700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I891c2121e02b47f09ce97640f2da938f9102c3e4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months
Change in ovirt-engine[master]: webui: Fix numa pinning dialog cancel button
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webui: Fix numa pinning dialog cancel button
......................................................................
webui: Fix numa pinning dialog cancel button
When opening the numa pinning dialog through the VM edit screen, the
pinning changes were persisted when you hit the cancel button. They
should only be persisted when the OK button is pressed.
Instead of directly manipulationg the numa nodes associated with the VM,
a numa node model is moved around. When hitting the OK button the model
is converted to numa node objects and set on the VM.
Bug-Url: https://bugzilla.redhat.com/1284784
Change-Id: Ifc7ac4cdb0f7887bf74de5cdba2ca35b7bc92dfc
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/UnassignedVNumaNodesPanelPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/AssignedVNumaNodesPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DraggableVirtualNumaPanel.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/VirtualNumaPanel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
11 files changed, 176 insertions(+), 103 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/49517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc7ac4cdb0f7887bf74de5cdba2ca35b7bc92dfc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 5 months