Change in ovirt-engine[master]: core: Remove redundant space from comment.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove redundant space from comment.
......................................................................
core: Remove redundant space from comment.
Change-Id: I7efb92df42ef223513fe00a275d9ddb0e780646f
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/65898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7efb92df42ef223513fe00a275d9ddb0e780646f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: upload: drop persist call after scheduling a disk creation.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: upload: drop persist call after scheduling a disk creation.
......................................................................
upload: drop persist call after scheduling a disk creation.
When executing an image upload without supplying a disk, A disk creation
is called using CoCo, which automatically causing the command to be
persisted. This patch drops the redundant "persistCommand" call after
the disk creation call.
Change-Id: Ic735cd9114032eeeef7ddf26acc39db5a3050048
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Amit Aviram: Verified
Allon Mureinik: Looks good to me, but someone else must approve; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic735cd9114032eeeef7ddf26acc39db5a3050048
Gerrit-PatchSet: 26
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: upload: Indent switch case blocks
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: upload: Indent switch case blocks
......................................................................
upload: Indent switch case blocks
Indent them!
Change-Id: I5174990b806ceac51e1337a6e6d832313fab932c
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 43 insertions(+), 43 deletions(-)
Approvals:
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5174990b806ceac51e1337a6e6d832313fab932c
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Add a multi argument constructor in DiskImagesValidator.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Add a multi argument constructor in DiskImagesValidator.
......................................................................
core: Add a multi argument constructor in DiskImagesValidator.
Currently many clients of DiskImagesValidator use it for a single
DiskImage, manipulating the disk image sent to a List in order to use
it.
Add a multi argument constructor to DiskImagesValidator, so it can be
used for a small amount of disk images, or a single one.
Change-Id: Id8562b7a00386c5180cb8b4499de0f7e33c72de9
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java
5 files changed, 10 insertions(+), 6 deletions(-)
Approvals:
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8562b7a00386c5180cb8b4499de0f7e33c72de9
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: restapi: Add image transfer support.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: Add image transfer support.
......................................................................
restapi: Add image transfer support.
Add image transfer support.
Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369
Bug-Url: https://bugzilla.redhat.com/1337077
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransferResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ApiOutAdapter.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ImageTransferMapper.java
A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ImageTransferMapperTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskUploadImageProgressColumn.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
18 files changed, 285 insertions(+), 8 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, but someone else must approve
Allon Mureinik: Looks good to me, approved; Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/63257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: upload: Add queries for image transfer entity
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: upload: Add queries for image transfer entity
......................................................................
upload: Add queries for image transfer entity
Add:
* GetImageTransferByIdQuery
* GetAllImageTransfersQuery
Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07
Bug-Url: https://bugzilla.redhat.com/1337077
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllImageTransfersQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetImageTransferByIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java
8 files changed, 68 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96752e1b6caa19d45a40561c2455dd90a4010f07
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: upload: Support supplied image for an image transfer.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: upload: Support supplied image for an image transfer.
......................................................................
upload: Support supplied image for an image transfer.
For REST API support, we want to be able to execute the upload
command with a supplied image. Currently when executing the command,
the image is created. This patch will create the image only if no
image was supplied, otherwise, set needed parameters for the command
according to the supplied image.
Add tests for the upload command, verifying this change.
Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258
Bug-Url: https://bugzilla.redhat.com/1337077
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageParameters.java
5 files changed, 383 insertions(+), 22 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41066d1b8d2d7b18e4ceb12e1754b99189b3b258
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: image upload: don't expose resource ID to entity updates.
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: image upload: don't expose resource ID to entity updates.
......................................................................
image upload: don't expose resource ID to entity updates.
Resource ID is used for identifying the upload tickets. once the
ability of clearing it is exposed for the frontend/REST, it can
potentially cause loss of a transfer session, opening up security risks.
Remove this member from the image transfer updates entity, and set it as
a parameter for the backend ImageTransferUpdater class.
Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransferUpdates.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
7 files changed, 24 insertions(+), 79 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: Introduce DiskValidatior#isAttachedToAnyVM
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Introduce DiskValidatior#isAttachedToAnyVM
......................................................................
core: Introduce DiskValidatior#isAttachedToAnyVM
Add a validation to check if a disk is connected to any VM.
Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808
Bug-Url: https://bugzilla.redhat.com/1337077
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 45 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: cleanup unnecessary modifiers in IOvfBuilder
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: cleanup unnecessary modifiers in IOvfBuilder
......................................................................
core: cleanup unnecessary modifiers in IOvfBuilder
Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5
Bug-Url: https://bugzilla.redhat.com/1358383
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64958
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months