Change in ovirt-engine[master]: core: AddExistingBlockStorageDomainCommandTest vdsId
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: AddExistingBlockStorageDomainCommandTest vdsId
......................................................................
core: AddExistingBlockStorageDomainCommandTest vdsId
Remove redundant vdsId notion from the test. It adds nothing to it, and
just draws attention, causing confusion.
Change-Id: I36da02ff6f4ce1218b9e316d70da7c86999c919b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/…
[View More]manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64737
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36da02ff6f4ce1218b9e316d70da7c86999c919b
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: ActivateStorageDomainCommandTest @Spy annotation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: ActivateStorageDomainCommandTest @Spy annotation
......................................................................
core: ActivateStorageDomainCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Change-Id: Iebcce98f0f88f8cb06a5161caf25eebd2cfe7927
Signed-off-by: Allon …
[View More]Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ActivateStorageDomainCommandTest.java
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebcce98f0f88f8cb06a5161caf25eebd2cfe7927
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: StorageHandlingCommandBaseTes @Spy annotation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: StorageHandlingCommandBaseTes @Spy annotation
......................................................................
core: StorageHandlingCommandBaseTes @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Change-Id: Iec4de17c6a747b023f0deee35bfe80384dccce1d
Signed-off-by: Allon Mureinik …
[View More]<amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java
1 file changed, 8 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec4de17c6a747b023f0deee35bfe80384dccce1d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: LiveMigrateVmDisksCommandTest @Spy annotation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: LiveMigrateVmDisksCommandTest @Spy annotation
......................................................................
core: LiveMigrateVmDisksCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Change-Id: Iffdca1635bc0465aec9487c7facce53673a2b52d
Signed-off-by: Allon Mureinik …
[View More]<amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommandTest.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffdca1635bc0465aec9487c7facce53673a2b52d
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: GetDiskAlignmentCommandTest @Spy annotation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: GetDiskAlignmentCommandTest @Spy annotation
......................................................................
core: GetDiskAlignmentCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Change-Id: Ice6b10055a10944d212dd0983168e218a6788fb8
Signed-off-by: Allon Mureinik <…
[View More]amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommandTest.java
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice6b10055a10944d212dd0983168e218a6788fb8
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest: use single
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateVmDiskCommandTest: use single
......................................................................
core: UpdateVmDiskCommandTest: use single
The entire test's structure set up List<VM> (see, e.g.,
initializeCommand). However, these lists always contained only a
single VM, which made very little sense.
This patch attempts to rationalize the test by changing the semantics to
use a single VM in all the …
[View More]method signatures.
Change-Id: I0976b1363ea009ba150c05c1fb5714b010fbe174
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 22 insertions(+), 45 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0976b1363ea009ba150c05c1fb5714b010fbe174
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest DbFacade mock
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateVmDiskCommandTest DbFacade mock
......................................................................
core: UpdateVmDiskCommandTest DbFacade mock
Removed redundant mock.
Change-Id: I3064322db7cd38ea26bfa35e5a3a5962bf4c1061
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file …
[View More]changed, 0 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/64726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3064322db7cd38ea26bfa35e5a3a5962bf4c1061
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest#mockCtorRelatedDaoCalls
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateVmDiskCommandTest#mockCtorRelatedDaoCalls
......................................................................
core: UpdateVmDiskCommandTest#mockCtorRelatedDaoCalls
Removed this useless method, as the two mock calls can just be called
individually, and its name is just misleading, as these calls [no
longer] have anything to do with the constructor.
Change-Id: I73617bb4f25d47f44d6cbe15b2f21a176122a02e
…
[View More]Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I73617bb4f25d47f44d6cbe15b2f21a176122a02e
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest stubbing
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateVmDiskCommandTest stubbing
......................................................................
core: UpdateVmDiskCommandTest stubbing
Removed the command's stubbing that's no longer needed as the
constructor no longer has any dao calls.
Change-Id: Ib99b2aa23f3cef9c875cda9e25f6e6ec0d32f039
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/…
[View More]engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java
1 file changed, 1 insertion(+), 15 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64723
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib99b2aa23f3cef9c875cda9e25f6e6ec0d32f039
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months
Change in ovirt-engine[master]: core: RemoveDiskCommandTest @Spy annotation
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: RemoveDiskCommandTest @Spy annotation
......................................................................
core: RemoveDiskCommandTest @Spy annotation
Spy the command with the @Spy annotation instead of explicitly calling
Mockito.spy in order to set the ground for using injected mocks in
these tests in the future.
Change-Id: Ib894a9f96aa7e943cdb4b4e523c8ae6df2c3b57e
Signed-off-by: Allon Mureinik <amureini(a)…
[View More]redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java
1 file changed, 11 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64722
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib894a9f96aa7e943cdb4b4e523c8ae6df2c3b57e
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 3 months