October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AddExistingFileStorageDomainCommandTest params
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddExistingFileStorageDomainCommandTest params ...................................................................... core: AddExistingFileStorageDomainCommandTest params Remove redundant vdsId and spId notions from the test. They add nothing to it, and just draw attention, causing confusion. Change-Id: I0e4fdf6deca4726aa062c51fc89ac19d9730b7fd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommandTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e4fdf6deca4726aa062c51fc89ac19d9730b7fd Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddExistingBlockStorageDomainCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddExistingBlockStorageDomainCommandTest @Spy annotation ...................................................................... core: AddExistingBlockStorageDomainCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I5fbeff3498cb1bb17b2038b34639170d349aeb6e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddExistingBlockStorageDomainCommandTest.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fbeff3498cb1bb17b2038b34639170d349aeb6e Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddStorageDomainCommonTest local variable
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: AddStorageDomainCommonTest local variable ...................................................................... core: AddStorageDomainCommonTest local variable Converted vds to a local variable to make the code cleaner and more concise. Change-Id: Idc3aeaa76d4187cde1401a594a11764561af80d6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc3aeaa76d4187cde1401a594a11764561af80d6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommandTest @Spy annotation ...................................................................... core: UpdateVmDiskCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I8ad4edf82f1d0c48c200540296ad27fc86c47aee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 1 file changed, 67 insertions(+), 92 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64725 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad4edf82f1d0c48c200540296ad27fc86c47aee Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveImageCommandTest mocking
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RemoveImageCommandTest mocking ...................................................................... core: RemoveImageCommandTest mocking Remove redundant mocks. Change-Id: I9f3b41917c12d3c070afc618bd50d39e24bade41 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f3b41917c12d3c070afc618bd50d39e24bade41 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBaseTest mocking
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBaseTest mocking ...................................................................... core: StorageHandlingCommandBaseTest mocking Remove redundant mocks. Change-Id: I1a5b820bbcc819756ea466c425b184cb43311c3f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a5b820bbcc819756ea466c425b184cb43311c3f Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshLunsSizeCommandTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RefreshLunsSizeCommandTest @Spy annotation ...................................................................... core: RefreshLunsSizeCommandTest @Spy annotation Spy the command with the @Spy annotation instead of explicitly calling Mockito.spy in order to set the ground for using injected mocks in these tests in the future. Change-Id: I744446e9a23fc31198d8ce591c4ac7e7a4bbcf90 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommandTest.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/64752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744446e9a23fc31198d8ce591c4ac7e7a4bbcf90 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshLunsSizeCommandTest collections
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RefreshLunsSizeCommandTest collections ...................................................................... core: RefreshLunsSizeCommandTest collections Use the specialized Arrays.asList list instead of the general purpose ArrayList. Change-Id: Ie4f733290ed68d242afb8237b8b9de3193e46651 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommandTest.java 1 file changed, 6 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4f733290ed68d242afb8237b8b9de3193e46651 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RefreshLunsSizeCommandTest local variables
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: RefreshLunsSizeCommandTest local variables ...................................................................... core: RefreshLunsSizeCommandTest local variables Convert redundant members to local variables to improve the code's readability and maintainability. Change-Id: I8f176f974f31cd7d347d35233198d31e4c8a1fd4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommandTest.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f176f974f31cd7d347d35233198d31e4c8a1fd4 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageDomainCommandBaseTest @Spy annotation
by tnisan＠redhat.com 19 Oct '16

19 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: StorageDomainCommandBaseTest @Spy annotation ...................................................................... core: StorageDomainCommandBaseTest @Spy annotation Use the standard @Spy annotation instead of calling Mockito.spy explicitly. Change-Id: I02d3e7d0117899d0fd4135ea301c52b3aed7cd6a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/64749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d3e7d0117899d0fd4135ea301c52b3aed7cd6a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0