Change in ovirt-engine[master]: core: Enable virtio-scsi by default
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Enable virtio-scsi by default
......................................................................
core: Enable virtio-scsi by default
Non-cluster entities: Blank templates & built-in instance types will now have a
virtio-scsi controller configured.
Change-Id: I46eb47e2e3f96a8b2ef9f507af5de54a6c74c271
Bug-Url: https://bugzilla.redhat.com/1399142
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_01_0550_add_virtio_scsi_controller_to_non_cluster_entities.sql
1 file changed, 47 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Martin Betak: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46eb47e2e3f96a8b2ef9f507af5de54a6c74c271
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: frontend: Make VirtioScsiUtil respect Blank tmpl setting
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: frontend: Make VirtioScsiUtil respect Blank tmpl setting
......................................................................
frontend: Make VirtioScsiUtil respect Blank tmpl setting
Removed special case handling that always overrode virtio-scsi setting of blank
template to true.
Change-Id: Ib16b8b26ed3ab46103a08507f7de781e65f6bcd7
Bug-Url: https://bugzilla.redhat.com/1399142
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VirtioScsiUtil.java
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/67527
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib16b8b26ed3ab46103a08507f7de781e65f6bcd7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: ovirt-node should wait for restart after upgrade
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: ovirt-node should wait for restart after upgrade
......................................................................
engine: ovirt-node should wait for restart after upgrade
The SSH host reboot command changed as follow:
1. Set the host to 'Reboot' status: status is set to reboot once the reboot
command was successfully invoked on the host.
2. Added a sleep: Instead of setting the host's status immediately to its
previous status, there should be a delay to allow the host to start the
reboot and to prevent from the host monitoring to grab the host and attempt
to move it to up.
3. Fixed a bug in which the initial host status was ignored.
4. Set the default status after reboot is 'non-responsive'. This align
the behavior of the command with the host installation flow.
5. Support upgrading host or checking for hosts upgrade in Maintenance
mode.
In addition, the ovirt-node upgrade process will be reported as a
failed one if the expected reboot step didn't start properly.
Change-Id: If2e3b4fcafb98fa6e14da54c1c42f9d20e4d1278
Bug-Url: https://bugzilla.redhat.com/1382691
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
3 files changed, 22 insertions(+), 13 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Moti Asayag: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2e3b4fcafb98fa6e14da54c1c42f9d20e4d1278
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: adjust vms monitoring for post copy migration
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: adjust vms monitoring for post copy migration
......................................................................
core: adjust vms monitoring for post copy migration
Two changes are need in order to support post-copy migrations:
1. When a VM is switched from MigratingFrom to Paused there
should be a hand-over to the destination host.
2. After the hand-over the VM in paused status on the source
host should be ignored (as MigratingFrom status in pre-copy).
Change-Id: Iea660981b0e784a6aab9ec0d54624e0c96e410ca
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/64381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea660981b0e784a6aab9ec0d54624e0c96e410ca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: Project file for ovirt-provider-ovn
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Project file for ovirt-provider-ovn
......................................................................
Project file for ovirt-provider-ovn
Change-Id: I217d0f4ef46a2f17812a48aa369157a8a6131f30
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
---
A jobs/confs/projects/ovirt-provider-ovn/ovirt-provider-ovn.yaml
A jobs/confs/yaml/scms/ovirt-provider-ovn.yaml
2 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
--
To view, visit https://gerrit.ovirt.org/66839
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I217d0f4ef46a2f17812a48aa369157a8a6131f30
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Mor Kalfon <mkalfon(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <sharonaftaly(a)gmail.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[master]: OVF_STORE: provide more explicative error messages
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: OVF_STORE: provide more explicative error messages
......................................................................
OVF_STORE: provide more explicative error messages
Provide more explicative error messages when it
fails extracting vm.conf from the OVF_STORE.
Bug-Url: https://bugzilla.redhat.com/1374317
Change-Id: I7d92f0def0280fdcf31fb77757feda716ce9233a
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 18 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67549
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d92f0def0280fdcf31fb77757feda716ce9233a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.0]: core: missing overriding method.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: missing overriding method.
......................................................................
core: missing overriding method.
this method must be also overriden, otherwise it will be invoked on
parent, while it need to be called on decorator.
Change-Id: I2841ed59f91dc35cc7c3a0c7d00bed0b746f08df
Bug-Url: https://bugzilla.redhat.com/1395462
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2841ed59f91dc35cc7c3a0c7d00bed0b746f08df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Insufficient thread synchronization
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Insufficient thread synchronization
......................................................................
core: Insufficient thread synchronization
Usage of ConcurrentHashMap is insufficient here, there still could be
race.
Change-Id: Ia993af9be9c7d15cec7e9c7deddc8e6d8866fac7
Bug-Url: https://bugzilla.redhat.com/1395462
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67137
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia993af9be9c7d15cec7e9c7deddc8e6d8866fac7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.0]: core: locking proxy must lock pool and not decorator.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: locking proxy must lock pool and not decorator.
......................................................................
core: locking proxy must lock pool and not decorator.
it occured to me, that we must block concurrent access into
decorators, however opposite is true. Concurrent access in decorators
is not a problem in current implementation, however having locking
proxy on top means, that decorators have extra access into the pool
bypassing synchronization, which does cause a problem.
Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f
Bug-Url: https://bugzilla.redhat.com/1395462
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/DecoratedMacPoolFactoryTest.java
3 files changed, 65 insertions(+), 79 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e25394f00cbb6fe5dbc61886c2955f953db455f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in gerrit-admin[master]: Retype classification message
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Retype classification message
......................................................................
Retype classification message
The current message isn't consistent in all hooks.
The fix applied on the following hooks:
- check_product
- check_target_milestone
- set_post
- update_tracker
Change-Id: I4a3c85522c2aeaf63d935f1592135a692bb3f21a
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/check_product
M hooks/custom_hooks/check_target_milestone
M hooks/custom_hooks/set_post
M hooks/custom_hooks/update_tracker
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66653
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a3c85522c2aeaf63d935f1592135a692bb3f21a
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 11 months