November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: removed csh INFO messages
by Code Review 21 Nov '16

21 Nov '16

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: engine: removed csh INFO messages ...................................................................... engine: removed csh INFO messages Removed some context-sensitive help related INFO messages that weren't very helpful, were noisy. Change-Id: I9df3c6fce77445772f796c6d19ca3cb5aa7afbdf Bug-Url: https://bugzilla.redhat.com/1396483 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/ContextSensitiveHelpMappingServlet.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/67142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9df3c6fce77445772f796c6d19ca3cb5aa7afbdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine, webadmin: Add manual execution of 'Check for upgrades'
by Code Review 21 Nov '16

21 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine, webadmin: Add manual execution of 'Check for upgrades' ...................................................................... engine, webadmin: Add manual execution of 'Check for upgrades' Add a manual check for upgrades in webadmin. Add a new Installation menu item "Check For Upgrade" to trigger checking for host upgrade packages from the webadmin. If an upgrade check is already in progress an error AuditLog message is created. Change-Id: I12ef5a3163bffdaf8f2a73054735ba8dbeca08c3 Bug-Url: https://bugzilla.redhat.com/1279378 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/AvailableUpdatesFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/OvirtNodeUpgradeManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/UpdateAvailable.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCheckCallback.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCheckCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCheckInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/HostUpgradeManagerResult.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostUpgradeCheckConfirmationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 26 files changed, 472 insertions(+), 31 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12ef5a3163bffdaf8f2a73054735ba8dbeca08c3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add examples of how to work with affinity labels
by Code Review 21 Nov '16

21 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add examples of how to work with affinity labels ...................................................................... Add examples of how to work with affinity labels This patch adds examples of how to work with affinity lables. This patch consist of following examples: - AddAffinityLabel.java - Create new affinity label - AssignAffinityLabelToVm.java - Assign affinity label to VM - ListAffinityLabels.java - List all affinity labels and its VMs Change-Id: I760789ef96d5cfcd07c82c8dcb67429cb89a185a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 80cfcdd8e954ead7eba71d21b4fdda4a8b66d55b) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddAffinityLabel.java A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignAffinityLabelToVm.java A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListAffinityLabels.java 3 files changed, 186 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I760789ef96d5cfcd07c82c8dcb67429cb89a185a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: aaa: sso: add additional data to token-info servlet
by Code Review 21 Nov '16

21 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: aaa: sso: add additional data to token-info servlet ...................................................................... aaa: sso: add additional data to token-info servlet This patch adds new parameters to token-info JSON output, and it's following paramters: first_name, last_name, namespace. This attributes needs to be passed to the login paramers, because we need to sync users table with latest external provider data. Change-Id: Ib64b07b9e85e3ad559037736f6f12b3f940454a9 Bug-Url: https://bugzilla.redhat.com/1392487 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java 6 files changed, 85 insertions(+), 13 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64b07b9e85e3ad559037736f6f12b3f940454a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add examples of how to work with affinity labels
by Code Review 21 Nov '16

21 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add examples of how to work with affinity labels ...................................................................... Add examples of how to work with affinity labels This patch adds examples of how to work with affinity lables. This patch consist of following examples: - AddAffinityLabel.java - Create new affinity label - AssignAffinityLabelToVm.java - Assign affinity label to VM - ListAffinityLabels.java - List all affinity labels and its VMs Change-Id: I760789ef96d5cfcd07c82c8dcb67429cb89a185a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddAffinityLabel.java A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignAffinityLabelToVm.java A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListAffinityLabels.java 3 files changed, 186 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I760789ef96d5cfcd07c82c8dcb67429cb89a185a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: sso: add additional data to token-info servlet
by Code Review 21 Nov '16

21 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: aaa: sso: add additional data to token-info servlet ...................................................................... aaa: sso: add additional data to token-info servlet This patch adds new parameters to token-info JSON output, and it's following paramters: first_name, last_name, namespace. This attributes needs to be passed to the login paramers, because we need to sync users table with latest external provider data. Change-Id: Ib64b07b9e85e3ad559037736f6f12b3f940454a9 Bug-Url: https://bugzilla.redhat.com/1392487 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateUserSessionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java 6 files changed, 85 insertions(+), 13 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64b07b9e85e3ad559037736f6f12b3f940454a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Sort host selection when adding direct LUN alphabe...
by Code Review 21 Nov '16

21 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Sort host selection when adding direct LUN alphabetically ...................................................................... webadmin: Sort host selection when adding direct LUN alphabetically Change-Id: I9caf428243410b6f41547fd58dea44fffe793255 Bug-Url: https://bugzilla.redhat.com/1357882 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9caf428243410b6f41547fd58dea44fffe793255 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add examples of how to work with affinity labels
by Code Review 21 Nov '16

21 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add examples of how to work with affinity labels ...................................................................... Add examples of how to work with affinity labels This patch adds examples of how to work with affinity lables. This patch consist of following examples: - add_affinity_label.py - Create new affinity label - assign_affinity_label_to_vm.py - Assign affinity label to VM - list_affinity_labels.py - List all affinity labels and its VMs Change-Id: I0abd9474cde59c9ff5e7ef59a963b28e85f6d9ab Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 5548b7d8c7a9478311fd107b0b3c3846dedf0b80) --- A sdk/examples/add_affinity_label.py A sdk/examples/assign_affinity_label_to_vm.py A sdk/examples/list_affinity_labels.py 3 files changed, 176 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0abd9474cde59c9ff5e7ef59a963b28e85f6d9ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add examples of how to work with affinity labels
by Code Review 21 Nov '16

21 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add examples of how to work with affinity labels ...................................................................... Add examples of how to work with affinity labels This patch adds examples of how to work with affinity lables. This patch consist of following examples: - add_affinity_label.py - Create new affinity label - assign_affinity_label_to_vm.py - Assign affinity label to VM - list_affinity_labels.py - List all affinity labels and its VMs Change-Id: I0abd9474cde59c9ff5e7ef59a963b28e85f6d9ab Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_affinity_label.py A sdk/examples/assign_affinity_label_to_vm.py A sdk/examples/list_affinity_labels.py 3 files changed, 176 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0abd9474cde59c9ff5e7ef59a963b28e85f6d9ab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add examples of how to work with affinity labels
by Code Review 21 Nov '16

21 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add examples of how to work with affinity labels ...................................................................... Add examples of how to work with affinity labels This patch adds examples of how to work with affinity lables. This patch consist of following examples: - add_affinity_label.rb - Create new affinity label - assign_affinity_label_to_vm.rb - Assign affinity label to VM - list_affinity_labels.rb - List all affinity labels and its VMs Change-Id: I72338fce07c59bdbd7b66a0e1027ad0b0a9beb20 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 232c2a6d4504a24cf8edb214ad0dc79f54f8d496) --- A sdk/examples/add_affinity_label.rb A sdk/examples/assign_affinity_label_to_vm.rb A sdk/examples/list_affinity_labels.rb 3 files changed, 162 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72338fce07c59bdbd7b66a0e1027ad0b0a9beb20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0