Change in ovirt-engine[master]: core: enable entity progress support for all steps
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: enable entity progress support for all steps
......................................................................
core: enable entity progress support for all steps
Currently entity progress report is supported for commands that
add a step by overriding getCommandStep() and getCommandStepSubjectEntities().
On flows adding steps using different infrastructures (like async task manager
based flows) it may be required to report progress on the entities as well.
The progress on the entity is a sum of the progress*entity weight
for all the steps "related" to the entity (we currently use that on jobs
that modifies an entity exclusively). Therefore In order to support
entity progress report for all the steps, we need a progress for each of
them and to support for adding the step subject entities.
This patch includes the following changes:
1. Add support to include StepSubjectEntity list when adding any step.
2. Move the StepSubjectEntity handling to the JobRepository
in order to reuse the code by all the callers.
3. Adding the step_progress view so that steps without progress report
will be considered with progress of 100 when they are finished.
4. Update to the entity_step_progress accordingly.
Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepSubjectEntity.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
12 files changed, 129 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66124
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: Move/Copy disk flow - weight infra and usage
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: Move/Copy disk flow - weight infra and usage
......................................................................
core: Move/Copy disk flow - weight infra and usage
When command is executed and defines a Job, its initial job weight
is 100. If that command is executing child commands, it can split
the job weight between them to represent the part of each command
in the job.
This patch adds the infra to calculate and pass the weight
of executed child commands and makes use of that infra in the
move/copy disk SDM flow.
In order to avoid handling double values, we use integer for
the weight of each commands - CommandsWeightsHelper.adjust()
can be used in order to round and split the weight of the child
commands according to the provided total weight.
Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/CommandsWeightsUtils.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/CommandsWeightsUtilsTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
12 files changed, 233 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Liron Aravot: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66126
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: cleanup in vm-analyzer
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in vm-analyzer
......................................................................
core: cleanup in vm-analyzer
Changes VmAnalyzer#handOverVm:
1. rename handOverVm#destinationHostId to dstHostId
2. keep only the infromative parts in comments within handOverVm
3. rename updateRepository to proceedVmReportedOnTheSameHost
4. other layout fixes
Change-Id: Ib5f4bb0b178611a498923ab007e5ce8ef24715f8
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 11 insertions(+), 14 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/66658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f4bb0b178611a498923ab007e5ce8ef24715f8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: remove incorrect logic in vm-analyzer
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove incorrect logic in vm-analyzer
......................................................................
core: remove incorrect logic in vm-analyzer
When we detect a VM that is running on a host that we did not
expect the VM to run on, we first examine the migration
statuses MigratingFrom and MigratingTo. Then, we used to have
the following logic: "if the VM is set as running on a
different host and it is not up on this host then it is being
migrated". This logic is obviously wrong - except for Down
state that is handled before, all other statuses should be
treated as the Up status.
Change-Id: Ib9cccca87b251810c6260ca14807e4c2d66d5b16
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9cccca87b251810c6260ca14807e4c2d66d5b16
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: remove redundant comparison in vm-analyzer
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove redundant comparison in vm-analyzer
......................................................................
core: remove redundant comparison in vm-analyzer
When we detect a VM that is running on a host that we
don't expect it to run on (not as part of migration),
we should update the VM so its runOnVds will point to
the new host. There is no point in comparing the VM's
runtime information we received from VDSM with the
information we have in the database.
Change-Id: I719571e35c08125eb73ff7dadcf85a4e9b5f7ba3
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/66656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I719571e35c08125eb73ff7dadcf85a4e9b5f7ba3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: remove unneeded values of vm statistics from the database
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: remove unneeded values of vm statistics from the database
......................................................................
core: remove unneeded values of vm statistics from the database
Saving VM statistics in a database is somewhat problematic since
it is expected to change on every statistics cycle and in large-scale
setups it leads to high amount of data being written to the database
very frequently. Unfortunately, we cannot eliminate it completely
since DWH and the dashboard get their information by querying the
database directly.
However, we can reduce the amount of data that is being written to
the database by removing the fields that no one queries (but are
taken from the cached VM statistics instead). There are currently
four such fields that are removed in this patch. Together with
If7206320, more than 50% of the fields that were written to
vm_statistics in 4.0 are no longer written to the database.
Change-Id: I1b7edbfebbb3bb83d1c1c6f08144dda269c83729
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_01_0470_remove_uneeded_fields_in_vm_statistics.sql
M packaging/dbscripts/vms_sp.sql
6 files changed, 14 insertions(+), 69 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b7edbfebbb3bb83d1c1c6f08144dda269c83729
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in jenkins[master]: disable compression of logs for standard ci mock logs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: disable compression of logs for standard ci mock logs
......................................................................
disable compression of logs for standard ci mock logs
Instead of tar gz the logs, just
move them to exported-artifacts
Change-Id: Ia3cebb8d8e95de22bf07956957af45fb25da4483
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/shell-scripts/mock_cleanup.sh
M mock_configs/site-defaults.cfg
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Barak Korren: Looks good to me
Eyal Edri: Verified; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66808
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3cebb8d8e95de22bf07956957af45fb25da4483
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <sharonaftaly(a)gmail.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0.6]: core: preserve maintenance status on reboot
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: preserve maintenance status on reboot
......................................................................
core: preserve maintenance status on reboot
Insure that in the case a NGN host is rebooted from Maintenance status it
will remain in this status after reboot
Change-Id: Ia6bdff5bcf07b063577b1e38bfc9965c7d75bd5f
Bug-Url: https://bugzilla.redhat.com/1394508
Signed-off-by: emesika <emesika(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
3 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67041
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6bdff5bcf07b063577b1e38bfc9965c7d75bd5f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0.6]: aaa: No error message is shown on login with missing username
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: No error message is shown on login with missing username
......................................................................
aaa: No error message is shown on login with missing username
Error message needs to be displayed
on login page if the username provided
on the login screen is empty
Change-Id: I70e3e8472d1233320245ad22095a22c416742a76
Bug-Url: https://bugzilla.redhat.com/1394184
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveAuthServlet.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I70e3e8472d1233320245ad22095a22c416742a76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[ovirt-engine-4.0.6]: aaa: The SSO token expiration date should be returned as Long
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: aaa: The SSO token expiration date should be returned as Long
......................................................................
aaa: The SSO token expiration date should be returned as Long
The SSO token expiration needs to returned as
a long value and should not be cast to int.
The token expiration is the Authorization
record expiration date returned from the
ldap server and should not be confused with
engine session expiration date.
Change-Id: I59af81778815e4b3c1de1920c397e9123ea01687
Bug-Url: https://bugzilla.redhat.com/1391643
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenInfoServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67037
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59af81778815e4b3c1de1920c397e9123ea01687
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months