November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: VM names leaking out of confirm windows
by Code Review 15 Nov '16

15 Nov '16

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: webadmin: VM names leaking out of confirm windows ...................................................................... webadmin: VM names leaking out of confirm windows Fixed by using the same dialog as used in the main vm list. Change-Id: Id360d585ff3a109248267256d34e9f7156128685 Bug-Url: https://bugzilla.redhat.com/1366022 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id360d585ff3a109248267256d34e9f7156128685 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: node: move email recipient to fabiand
by Code Review 15 Nov '16

15 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: node: move email recipient to fabiand ...................................................................... node: move email recipient to fabiand Tolik's address is not active anymore, moving to Fabian. Change-Id: Ie27b7855b81ac5fe0834b54cad2af6d472dbd4f4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/templates/ovirt-node-job-templates.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie27b7855b81ac5fe0834b54cad2af6d472dbd4f4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Deprecated legacy USB policy
by Code Review 15 Nov '16

15 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Deprecated legacy USB policy ...................................................................... restapi: Deprecated legacy USB policy If the LEGACY will be set, the NATIVE will be used instead. Change-Id: Icb19e55b217eeaa9113822f5b9d47fe19adeebdc Bug-Url: https://bugzilla.redhat.com/1333436 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtils.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/utils/UsbMapperUtilsTest.java 4 files changed, 2 insertions(+), 101 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb19e55b217eeaa9113822f5b9d47fe19adeebdc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: entity_step_progress view
by Code Review 15 Nov '16

15 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: db: entity_step_progress view ...................................................................... db: entity_step_progress view Currently the view query selects the steps that are on 'STARTED' status- if a job has few steps, to report the correct progress the steps that were ended should be selected as well. Instead, if the job was finished than no progress should be reported on the entity. Change-Id: I80c4bec6902b7354cedb2b0f6ca986ff050ca5d1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M packaging/dbscripts/create_views.sql 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80c4bec6902b7354cedb2b0f6ca986ff050ca5d1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AsyncTasks - use persisted context instead of generati...
by Code Review 15 Nov '16

15 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: AsyncTasks - use persisted context instead of generating one ...................................................................... core: AsyncTasks - use persisted context instead of generating one When all the async tasks of command ends, CommandAsyncTask executes the command endAction(). It uses ExecutionHandler.createFinalizingContext() to create the finalizing context for the command. For 'traditional' async task manager flows, this behavior worked fine - that's because the parent always executed the endAction() of the child commands by itself. On COCO flows the endAction() of a child commands might be executed when it ends by the ATM - that causes for the FINALIZING step to be added on that phase to the job instead of on the parent end. Currently we cache the command contexts, so there's no need to get the context from createFinalizingContext(), we can use the exact context the command was executed with and by that to avoid the problem. Change-Id: I065551ee471a314ffd84b0f72a7b6079156e7f7a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/AsyncCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCRUDOperations.java 6 files changed, 20 insertions(+), 18 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/62388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I065551ee471a314ffd84b0f72a7b6079156e7f7a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Better error message when deleting a job
by Code Review 15 Nov '16

15 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Better error message when deleting a job ...................................................................... Better error message when deleting a job When deleting a job, check-patch inspects whether you have removed this job also from nightly publisher jobs. With this patch, message will let you know what you are missing and what you need to do. Change-Id: I07508ede0b5a501f99e51c8f9cf7e3d324580d2d Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M automation/check_publishers_not_deleted.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07508ede0b5a501f99e51c8f9cf7e3d324580d2d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed build artifacts on fc24 with ppc64le
by Code Review 15 Nov '16

15 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Removed build artifacts on fc24 with ppc64le ...................................................................... Removed build artifacts on fc24 with ppc64le We are supporting only el7 ppc64le builds Change-Id: I6bba8d8e9727af1dca23ab93fed56e81764aa443 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 2 files changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bba8d8e9727af1dca23ab93fed56e81764aa443 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live 4.0.5
by Code Review 15 Nov '16

15 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live 4.0.5 ...................................................................... build: ovirt-live 4.0.5 Change-Id: I4a4f281e6bb9947ac28251121b6e018d28069d25 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a4f281e6bb9947ac28251121b6e018d28069d25 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Change mount point for maven repository
by Code Review 15 Nov '16

15 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Change mount point for maven repository ...................................................................... Change mount point for maven repository There are some jobs who are running on the slaves without mock and cannot use the default cache path /home/jenkins/.m2 because when mock jobs are mounting this path, they are copying artifacts to that path with root permissions. Change-Id: I4be0bc5e60f5d839b1977a9bf990e95b52e17681 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M automation/build-artifacts.mounts M automation/check-merged.mounts M automation/check-patch.mounts 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Eyal Edri: Looks good to me, approved Barak Korren: Looks good to me, but someone else must approve Gil Shinar: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4be0bc5e60f5d839b1977a9bf990e95b52e17681 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: inform user clearly, that OVS is experimental.
by Code Review 15 Nov '16

15 Nov '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: inform user clearly, that OVS is experimental. ...................................................................... core: inform user clearly, that OVS is experimental. Change-Id: Id28257ba6542e176d1fc364340c96b88c3ba6933 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66265 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id28257ba6542e176d1fc364340c96b88c3ba6933 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0