Change in ovirt-engine[master]: core: @Inject GetJobsByOffsetQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetJobsByOffsetQuery Daos
......................................................................
core: @Inject GetJobsByOffsetQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I2b2afd0854d950735a7c3c12ae6c5b2058a5e1a0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByOffsetQuery.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Betak: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b2afd0854d950735a7c3c12ae6c5b2058a5e1a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetHostsForStorageOperationQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetHostsForStorageOperationQuery Daos
......................................................................
core: @Inject GetHostsForStorageOperationQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: Ia95b155d71121e3e7741a3802050d68e8361ac4f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostsForStorageOperationQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostsForStorageOperationQueryTest.java
2 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66691
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia95b155d71121e3e7741a3802050d68e8361ac4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetHostsByClusterIdQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetHostsByClusterIdQuery Daos
......................................................................
core: @Inject GetHostsByClusterIdQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I11ccb238352f327b2ab1a8299c24751892cfe81d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostsByClusterIdQuery.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66690
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11ccb238352f327b2ab1a8299c24751892cfe81d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: do not instantiate vm-manager when not needed
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: do not instantiate vm-manager when not needed
......................................................................
core: do not instantiate vm-manager when not needed
Now that the instantiation of VmManager involves a query for
the static data of a VM from the database, we should be more
careful not to make redundant instantiations.
This patch adds a machanism to retrieve the manager object
of a specific VM only if it is already instantiated. This
mechanism is used by methods that query content that is
typically contained in VmManager, but when no such object
exists, should use default values.
Change-Id: I18e5ed3da7f1d5ee1b2a987f08eec4ba8965919a
Bug-Url: https://bugzilla.redhat.com/1392209
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
2 files changed, 18 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/65854
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18e5ed3da7f1d5ee1b2a987f08eec4ba8965919a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-guest-agent[master]: vio: Remove unused obsolete code
by Code Review
>From Vinzenz Feenstra <vfeenstr(a)redhat.com>:
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: vio: Remove unused obsolete code
......................................................................
vio: Remove unused obsolete code
Change-Id: Ie6aeb0b73bd7d7f7b838003602d19f67ea24b4c1
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/VirtIoChannel.py
1 file changed, 0 insertions(+), 31 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6aeb0b73bd7d7f7b838003602d19f67ea24b4c1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-guest-agent[master]: Add support for new VirtIO channel name
by Code Review
>From Vinzenz Feenstra <vfeenstr(a)redhat.com>:
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Add support for new VirtIO channel name
......................................................................
Add support for new VirtIO channel name
Bug-Url: https://bugzilla.redhat.com/1350334
Change-Id: Ibb5a6120317bf24ca750dde3c9913db24709774e
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M configurations/default.conf
M configurations/default.ini
M configurations/ovirt-guest-agent.conf
M configurations/ovirt-guest-agent.ini
M debian/postinst
M debian/postrm
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
M ovirt-guest-agent/OVirtAgentLogic.py
M ovirt-guest-agent/VirtIoChannel.py
M ovirt-guest-agent/WinFile.py
M ovirt-guest-agent/ovirt-guest-agent.el5.rules
M ovirt-guest-agent/ovirt-guest-agent.rules
M tests/guest_agent_test.py
14 files changed, 79 insertions(+), 21 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/65121
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb5a6120317bf24ca750dde3c9913db24709774e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetBookmarkByBookmarkNameQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetBookmarkByBookmarkNameQuery Daos
......................................................................
core: @Inject GetBookmarkByBookmarkNameQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I97baf97f91c595af9065de8d0fdc1c47827e5be2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetBookmarkByBookmarkNameQuery.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97baf97f91c595af9065de8d0fdc1c47827e5be2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetAuditLogByIdQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetAuditLogByIdQuery Daos
......................................................................
core: @Inject GetAuditLogByIdQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I9cbbc15bd4a33099b96d11280a433692001c4370
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuditLogByIdQuery.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66635
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cbbc15bd4a33099b96d11280a433692001c4370
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetAllVdsByStoragePoolQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetAllVdsByStoragePoolQuery Daos
......................................................................
core: @Inject GetAllVdsByStoragePoolQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: Id07f5a2446897938bd67e4756777060fe9eda2b0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVdsByStoragePoolQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVdsByStoragePoolQueryTest.java
2 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id07f5a2446897938bd67e4756777060fe9eda2b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in ovirt-engine[master]: core: @Inject GetAllUserProfilesQuery Daos
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: @Inject GetAllUserProfilesQuery Daos
......................................................................
core: @Inject GetAllUserProfilesQuery Daos
@Inject the DAOs instead of explicitly getting them from DbFacade.
Change-Id: I0fcc2ef78b513ecef25be59c1471b442307f7f91
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllUserProfilesQuery.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Roman Mohr: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/66632
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fcc2ef78b513ecef25be59c1471b442307f7f91
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months