Change in ovirt-engine[master]: packaging: setup: Remove engine yum group
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Remove engine yum group
......................................................................
packaging: setup: Remove engine yum group
Do keep the code, in case we ever want to handle yum groups, but do not
actually install packages from the yum group ovirt-engine-X.Y
Change-Id: I4140ff9ac64b73620e8562ec4acc5c4f8e656d8a
Related-To: https://bugzilla.redhat.com/1286558
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py
2 files changed, 0 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/65889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4140ff9ac64b73620e8562ec4acc5c4f8e656d8a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: packaging: engine-backup: Nicer message on failure
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Nicer message on failure
......................................................................
packaging: engine-backup: Nicer message on failure
Prefix all notifications to the engine with 'engine-backup:'.
Without this only backup start/end messages have 'Backup', but when
errors are sent, it might not be clear that engine-backup sent them.
Also include scope and log file location in the message.
Change-Id: Ic17382edc3e4cc1d119734973b26d07e6d055d8c
Related-To: https://bugzilla.redhat.com/1372320
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Rafael Martins: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/65981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic17382edc3e4cc1d119734973b26d07e6d055d8c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[master]: packaging: add experimental repo
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: add experimental repo
......................................................................
packaging: add experimental repo
Added experimental repo
Change-Id: I99ae34ca956a8f12116cbe83d50d7c6ecc645d7c
---
M Makefile.am
M configure.ac
A ovirt-experimental.repo.in
M ovirt-release-master.spec.in
4 files changed, 65 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Eyal Edri: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66422
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99ae34ca956a8f12116cbe83d50d7c6ecc645d7c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[master]: spec: add dist tag to release
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: spec: add dist tag to release
......................................................................
spec: add dist tag to release
This allows repoman to behave correctly when
adding the package to experimental repos
Change-Id: I82dd89b06087f6054c7a46bc386b1affd5f14334
---
M ovirt-release-master.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82dd89b06087f6054c7a46bc386b1affd5f14334
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: reveting back image tests to use fc23 chroot
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: reveting back image tests to use fc23 chroot
......................................................................
reveting back image tests to use fc23 chroot
- Mistakely changed it, we know it can
only work on fc23 for now, need to make
sure it works for fc24/fc25 soon.
Change-Id: I3e7110c22c721b1b2423b43b4a2836ec304460b4
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/66424
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e7110c22c721b1b2423b43b4a2836ec304460b4
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Fix insert_storage_domaon_static in upgrade
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix insert_storage_domaon_static in upgrade
......................................................................
core: Fix insert_storage_domaon_static in upgrade
Commits 6b13d8 and d504fd added parameters to
insert_storage_domaon_static, but neglected adding arguments to its
call in inst_sp.sql.
This patch rectifies this problem.
Change-Id: Ie88785b126f76dfbcf7feff4dc76de78a7aba870
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M packaging/dbscripts/inst_sp.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie88785b126f76dfbcf7feff4dc76de78a7aba870
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[master]: spec: fix invalid date in changelog
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: spec: fix invalid date in changelog
......................................................................
spec: fix invalid date in changelog
Change-Id: I1a015764560c97435902043d228a47295f396a0d
---
M ovirt-release-master.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66420
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a015764560c97435902043d228a47295f396a0d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use DiskAttachment.active explicitly
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use DiskAttachment.active explicitly
......................................................................
Use DiskAttachment.active explicitly
The 'DiskAttachment.active' attribute isn't mandatory when adding a disk
attachment to a virtual machine, but if it isn't provided the result is
undefined: the disk will be active in some situations, and won't in some
other situations. To avoid that uncertainty it is better to always
include it with the desired value. This patch changes the examples
accordingly.
Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483
Related-To: https://bugzilla.redhat.com/1390517
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 3c8488955185b383b6c537889e5cfb6d82c9d4b5)
---
M sdk/examples/add_vm_disk.rb
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine-sdk-ruby[master]: Use DiskAttachment.active explicitly
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Use DiskAttachment.active explicitly
......................................................................
Use DiskAttachment.active explicitly
The 'DiskAttachment.active' attribute isn't mandatory when adding a disk
attachment to a virtual machine, but if it isn't provided the result is
undefined: the disk will be active in some situations, and won't in some
other situations. To avoid that uncertainty it is better to always
include it with the desired value. This patch changes the examples
accordingly.
Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483
Related-To: https://bugzilla.redhat.com/1390517
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/examples/add_vm_disk.rb
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc5675b5174aab5ec1707dd677c8bf8f1fe77483
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Unbreak CorrelationIdValidationTest
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Unbreak CorrelationIdValidationTest
......................................................................
core: Unbreak CorrelationIdValidationTest
CorrelationIdValidationTest fails intermittently upstream. The root
cause seems to be the static member in CorrelationIdTracker which may or
may not get set in previous tests.
This patch assures that it's initialized per test run in order to make
the test reliable.
Change-Id: I8727447aefd5b7b203366faa3143440365f583c8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/CorrelationIdValidationTest.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66400
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8727447aefd5b7b203366faa3143440365f583c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months