Change in ovirt-engine[ovirt-engine-4.0.6]: imagetransfer: Expand permission checks for transfers.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: imagetransfer: Expand permission checks for transfers.
......................................................................
imagetransfer: Expand permission checks for transfers.
Currently, a permission check is being made only on the related storage domain.
This patch adds a permission check for the specific disk, in case it was
provided.
Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java
2 files changed, 29 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.6]: imagetransfer: isImageProvided() method addition.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: imagetransfer: isImageProvided() method addition.
......................................................................
imagetransfer: isImageProvided() method addition.
Add isImageProvided() to improve readability, making the code easier to
understand and maintain.
Change-Id: I1ef7263da324b0a5f84948c73ebc8ac7f0342df1
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef7263da324b0a5f84948c73ebc8ac7f0342df1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0.6]: core: Implement equals for PermissionSubject
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Implement equals for PermissionSubject
......................................................................
core: Implement equals for PermissionSubject
Change-Id: Ib86525a9320843723bb9c28d83fd0135e334fb1b
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67449
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib86525a9320843723bb9c28d83fd0135e334fb1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0.6
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: imagetransfer: Expand permission checks for transfers.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: imagetransfer: Expand permission checks for transfers.
......................................................................
imagetransfer: Expand permission checks for transfers.
Currently, a permission check is being made only on the related storage domain.
This patch adds a permission check for the specific disk, in case it was
provided.
Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/UploadDiskImageCommandTest.java
2 files changed, 29 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf28a9887dc2c01810490fd1b81f45930094a7fb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: imagetransfer: isImageProvided() method addition.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: imagetransfer: isImageProvided() method addition.
......................................................................
imagetransfer: isImageProvided() method addition.
Add isImageProvided() to improve readability, making the code easier to
understand and maintain.
Change-Id: I1ef7263da324b0a5f84948c73ebc8ac7f0342df1
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef7263da324b0a5f84948c73ebc8ac7f0342df1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Implement equals for PermissionSubject
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Implement equals for PermissionSubject
......................................................................
core: Implement equals for PermissionSubject
Change-Id: Ib86525a9320843723bb9c28d83fd0135e334fb1b
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/67445
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib86525a9320843723bb9c28d83fd0135e334fb1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
8 years, 3 months
Change in ovirt-engine[master]: frontend: Remove unused field from AbstractVmPopupWidget
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: frontend: Remove unused field from AbstractVmPopupWidget
......................................................................
frontend: Remove unused field from AbstractVmPopupWidget
Change-Id: I434719484b1c7d4de8db52b5783d065f6e359c06
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Martin Betak: Verified
--
To view, visit https://gerrit.ovirt.org/67491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I434719484b1c7d4de8db52b5783d065f6e359c06
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-release[master]: node: Include screen by default
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: node: Include screen by default
......................................................................
node: Include screen by default
Useful for the HE flow - and in general.
Change-Id: Iadc7ca705973fee93236d8086de0fe675d25bfd9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1379763
Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org>
---
M ovirt-release-master.spec.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadc7ca705973fee93236d8086de0fe675d25bfd9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: automation: moving build-artifacts to build minimal
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: moving build-artifacts to build minimal
......................................................................
automation: moving build-artifacts to build minimal
We don't need to run full matrix of
lang + browsers on each commit in CI,
it takes too long and steals valuable
resources, such as BM slaves.
It also delays the response / fix time
of any fix merged into engine to show
up on system jobs.
Change-Id: I7a4c56d40a5dbf95764dff7887792a0893d54145
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M automation/build-artifacts.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Eyal Edri: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67269
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a4c56d40a5dbf95764dff7887792a0893d54145
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: Test host connectivity after upgrade
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Test host connectivity after upgrade
......................................................................
engine: Test host connectivity after upgrade
After host upgrade, the VDSM service is restarted. The engine should
attempt to connect to the host before passing the responsibilty back
to the host monitoring to prevent unwanted monitoring connectivity
errors which might result in moving the host to non-reponsive state.
Change-Id: I30e81a0d338201de01d4a58dd0168ff6a2633119
Bug-Url: http://bugzilla.redhat.com/1382691
Bug-Url: http://bugzilla.redhat.com/1383229
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostConnectivityChecker.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
4 files changed, 52 insertions(+), 18 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Verified
--
To view, visit https://gerrit.ovirt.org/67409
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30e81a0d338201de01d4a58dd0168ff6a2633119
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months