November 2016 - Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Add default-hooks directories
by Code Review 29 Nov '16

29 Nov '16

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Add default-hooks directories ...................................................................... Add default-hooks directories In the current configuration every project has a 'hook' directory with links to the custom_hooks directory. - It is hard to maintain the hooks in this way - The hooks order isn't correct (not running in the right order) Now we will have: - One structured directory (default-hooks) that is separated to the following directories: + check (hooks that checks patches vs bugs in bugzilla) + update (hooks that update [modify] bugs in bugzilla) + all (holds both check and update hooks) - The hooks are running in the correct order - All the hooks are labeled (i.e [hook-type].[bz].[number].[hook-name]) - If we want to set hooks for a specific project we just need to create a symbolic link inside the project directory to point to one of the directories (check,update,all) in the default-hooks directory. Change-Id: Ic1afdbf4d6a103e0c6d3c42053fe6880e4fc7ed1 Fixes: OVIRT-760 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- A hooks/default-hooks/all/change-abandoned.bz.99.update_tracker A hooks/default-hooks/all/change-merged.bz.98.set_modified A hooks/default-hooks/all/change-merged.bz.99.update_tracker A hooks/default-hooks/all/patchset-created.bz.1.check_bug_url A hooks/default-hooks/all/patchset-created.bz.2.check_product A hooks/default-hooks/all/patchset-created.bz.3.check_target_milestone A hooks/default-hooks/all/patchset-created.bz.98.set_post A hooks/default-hooks/all/patchset-created.bz.99.update_tracker A hooks/default-hooks/check/patchset-created.bz.1.check_bug_url A hooks/default-hooks/check/patchset-created.bz.2.check_product A hooks/default-hooks/check/patchset-created.bz.3.check_target_milestone A hooks/default-hooks/update/change-abandoned.bz.99.update_tracker A hooks/default-hooks/update/change-merged.bz.98.set_modified A hooks/default-hooks/update/change-merged.bz.99.update_tracker A hooks/default-hooks/update/patchset-created.bz.98.set_post A hooks/default-hooks/update/patchset-created.bz.99.update_tracker 16 files changed, 16 insertions(+), 0 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1afdbf4d6a103e0c6d3c42053fe6880e4fc7ed1 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in jenkins[master]: OVIRT-645 remove repoproxy for CentOS 7 x86_64
by Code Review 29 Nov '16

29 Nov '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: OVIRT-645 remove repoproxy for CentOS 7 x86_64 ...................................................................... OVIRT-645 remove repoproxy for CentOS 7 x86_64 This patch removes repoproxy from CentOS 7 mock config in favour of usning a trimmed down mirrorlist via SQUID. Tested on a test mock environment. Change-Id: Ie445a8e6c7583cf52b8c7abd10b8524c3fc4f858 Signed-off-by: Evgheni Dereveanchin <ederevea(a)redhat.com> --- M mock_configs/epel-7-x86_64_proxied.cfg 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Nadav Goldin: Looks good to me Eyal Edri: Looks good to me; Passed CI tests; Ready for merge Anton Marchukov: Looks good to me Evgheni Dereveanchin: Verified -- To view, visit https://gerrit.ovirt.org/67444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie445a8e6c7583cf52b8c7abd10b8524c3fc4f858 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: core: Add Hosted Engine OVF writer
by Code Review 28 Nov '16

28 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add Hosted Engine OVF writer ...................................................................... core: Add Hosted Engine OVF writer Add this special writer for specific hosted engine needs. Hosted Engine uses the OVF to start the VM and is missing the cluster information (like regular VM have when starting them). This patch adds spcifically the cluster information, such as cpu type and emulated machine. Change-Id: I22568b4a2a5976100b62153706f5ae84692886bd Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmTemplatesQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetUnregisteredVmsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/HostedEngineOvfWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/HostedEngineOvfWriterTest.java 9 files changed, 204 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/67443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22568b4a2a5976100b62153706f5ae84692886bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: core: Move OvfManager to bll
by Code Review 28 Nov '16

28 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Move OvfManager to bll ...................................................................... core: Move OvfManager to bll OvfManager is a tool used by the bll layer and adds abstraction and exposes an API to export VM and Templates. Moving it to bll will allow extending and enriching the information added to the OVF without constantly expending the structures and arguments. The following patch is adding a specialized OVF writer for hosted engine and will use the OvfManager access to the DAL layer. Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/67442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: core: cleanup unnecessary modifiers in IOvfBuilder
by Code Review 28 Nov '16

28 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: cleanup unnecessary modifiers in IOvfBuilder ...................................................................... core: cleanup unnecessary modifiers in IOvfBuilder Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5 Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/67441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b494e3220e49704bab184f241a8acb63cacef5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: setup: more severe el6 hosts check
by Code Review 28 Nov '16

28 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: more severe el6 hosts check ...................................................................... packaging: setup: more severe el6 hosts check Due to other changes, upgrading the engine to 3.6 with hosts still running hosted-engine from 3.5 on el6 could be by far more problematic than in the past. In the past we were advising but the user could eventually ignore and continue from the interactive setup. Now the user can only force to skip that check via answerfile; the interacive upgrade will always abort if we have el6 based hosted-engine hosts. Change-Id: Ib78a6347f458d715f79f0247de5f3c744c810813 Bug-Url: https://bugzilla.redhat.com/1395357 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/hosted_engine.py 2 files changed, 24 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib78a6347f458d715f79f0247de5f3c744c810813 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marina Kalinin <mkalinin(a)redhat.com> Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add arbiter support for gluster volume
by Code Review 28 Nov '16

28 Nov '16

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: add arbiter support for gluster volume ...................................................................... webadmin: add arbiter support for gluster volume Adding support for arbiter volume creation. Arbiter Volume check box will be added in new volume dialog and add brick dialog and it will be shown when user creates a replica volume. Arbiter volume should be a replica 3 volume and every third brick in the brick list will be treated as arbiter brick. Arbiter Count should be 1. Hence it is shown as a check box in UI and converted to 1 or 0 during volume creation. Change-Id: I7d24653a633b0ccc6b6676af24b985bdd3a0be8a Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 9 files changed, 59 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/52540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d24653a633b0ccc6b6676af24b985bdd3a0be8a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: rollback: correctly evaluate the space on the VM disk
by Code Review 28 Nov '16

28 Nov '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: rollback: correctly evaluate the space on the VM disk ...................................................................... rollback: correctly evaluate the space on the VM disk Evaluate the real maximum space on the VM disk using the capacity attribute instead of the apparentsize one. Change-Id: Ie33d7d29790011077e485904949917a04763558c Bug-Url: https://bugzilla.redhat.com/1397810 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-rollbackupgrade/core/misc.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie33d7d29790011077e485904949917a04763558c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: upgrade: fixing engine backup location if not /root
by Code Review 28 Nov '16

28 Nov '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: fixing engine backup location if not /root ...................................................................... upgrade: fixing engine backup location if not /root On upgrades, the engine backup file is always injected under /root on the appliance. Fixing if the user keeps on different location on the host. Using otopi's resolveFile to make it safe against relative paths. Making the destination path user configurable. Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34 Bug-Url: https://bugzilla.redhat.com/1394740 Bug-Url: https://bugzilla.redhat.com/1396193 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py 4 files changed, 16 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I864154043a545b8f4c3fa069c9ddfaef19280b34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: virtio-scsi support for iothreads
by Code Review 28 Nov '16

28 Nov '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: virtio-scsi support for iothreads ...................................................................... core: virtio-scsi support for iothreads Bug-Url: https://bugzilla.redhat.com/1366507 Change-Id: Iaa927b6d03d92b59f810fece17107ba4a5225001 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 37 insertions(+), 21 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa927b6d03d92b59f810fece17107ba4a5225001 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0