Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix parameters creating in DataCenterGuideModel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fix parameters creating in DataCenterGuideModel
......................................................................
webadmin: Fix parameters creating in DataCenterGuideModel
The fix the build failure.
Change-Id: I24b32d61bce2580f826cd3fabcc63fb9bf2581a3
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66049
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24b32d61bce2580f826cd3fabcc63fb9bf2581a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi: rsdl - added force param to update connection
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: rsdl - added force param to update connection
......................................................................
restapi: rsdl - added force param to update connection
Added force url param to update storage connection in rsdl_metadata.
Change-Id: I998eb3f284e1255bcd23b8ec1e599863029138f3
Bug-Url: https://bugzilla.redhat.com/1379771
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I998eb3f284e1255bcd23b8ec1e599863029138f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: jsonrpc: version bump
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: jsonrpc: version bump
......................................................................
jsonrpc: version bump
Bug-Url: https://bugzilla.redhat.com/1391370
Change-Id: Ia97fd54e13c9b7f8b9a6ae9e28a2c628e493d180
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Tal Nisan: Passed CI tests
Martin Peřina: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/66036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia97fd54e13c9b7f8b9a6ae9e28a2c628e493d180
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 5 months
Change in gerrit-admin[master]: Enable Verify -1 grade (check_bug_url hook)
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Enable Verify -1 grade (check_bug_url hook)
......................................................................
Enable Verify -1 grade (check_bug_url hook)
Currently we are not grading patches without bug url.
Now we are starting to grade (Verify -1) only 'stable' branch patches.
Example 1:
branch: master
has bug url: False
result: Verify 0
Example 2:
branch: stable
has bug url: False
result: Verify -1
Change-Id: I67aaeb39d4ca8e9247422906158149cf42bed48d
Fixes: OVIRT-809
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/check_bug_url
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66025
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67aaeb39d4ca8e9247422906158149cf42bed48d
Gerrit-PatchSet: 2
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[master]: restapi: Update to model 4.1.17
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.17
......................................................................
restapi: Update to model 4.1.17
The more relevant changes in this version of the model are the
following:
* Added `urandom` to the `RngSource` enumerated type.
* Added `migratable` flag to the `VnicProfile` type.
Change-Id: If420e271b46617a0c5a61058ae58d1212712b723
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If420e271b46617a0c5a61058ae58d1212712b723
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: core: Fix race between AutoStartVmsRunner and ProcessDownVmC...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix race between AutoStartVmsRunner and ProcessDownVmCommand
......................................................................
core: Fix race between AutoStartVmsRunner and ProcessDownVmCommand
Issue for killed HA VM:
AutoStartVmsRunner acquires lock and runs the HA VM if there's
no NEXT_RUN. It causes race condition between removing the NEXT_RUN
snapshot in ProcessDownVmCommand.applyNextRunConfiguration() and
calling UpdateVmCommand to apply it.
The UpdateVmCommand fails to acquire locks if the RunVm command
is executed right after the NEXT_RUN snapshot is removed.
Fixed by:
ProcessDownVmCommand.applyNextRunConfiguration() acquires
lock before removing the NEXT_RUN snapshot and passes it to
the UpdateVmCommand.
The AutoStartVmsRunner keeps failing to acquire the VM lock until
the NEXT_RUN is applied.
Change-Id: Ie2f1a4a1b114fd95c535f41191cd980311f35f6e
Bug-Url: https://bugzilla.redhat.com/1369521
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
2 files changed, 43 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Marek Libra: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2f1a4a1b114fd95c535f41191cd980311f35f6e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in gerrit-admin[master]: Add bug status check in set_post hook
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Add bug status check in set_post hook
......................................................................
Add bug status check in set_post hook
It updates bug status to POST only for NEW patches
and the bug status should be in NEW OR ASSIGNED state.
Example: 1
patch status: NEW
bug status: NEW or ASSIGNED
result: OK ==> change bug status to POST
Example: 2
patch status: MERGED
bug status: other (POST|MODIFIED)
result: IGNORE
Change-Id: I81b43f01a59dffc2cdc7d64722deb794642fd9c0
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/custom_hooks/set_post
1 file changed, 72 insertions(+), 36 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Gil Shinar: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65943
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81b43f01a59dffc2cdc7d64722deb794642fd9c0
Gerrit-PatchSet: 5
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[master]: aaa: Update user info after login
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Update user info after login
......................................................................
aaa: Update user info after login
Update the user info in users table on
user login if the information has changed.
Change-Id: I6d6ebc663f6c6caa603919b1fd38556c1ec6f6c5
Bug-Url: https://bugzilla.redhat.com/1389251
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java
1 file changed, 8 insertions(+), 10 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d6ebc663f6c6caa603919b1fd38556c1ec6f6c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-3.6]: restapi, core: add force member to StorageServerConnectionPar...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi,core: add force member to StorageServerConnectionParametersBase
......................................................................
restapi,core: add force member to StorageServerConnectionParametersBase
* Added 'force' member to StorageServerConnectionParametersBase.
* Used in order to enable updating a storage connection regardless
to storage domain's status (i.e. also when the domain is not in
status Maintenance).
Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Bug-Url: https://bugzilla.redhat.com/1386606
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
13 files changed, 44 insertions(+), 31 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Daniel Erez: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64531
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi, core: add force member to StorageServerConnectionPar...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi,core: add force member to StorageServerConnectionParametersBase
......................................................................
restapi,core: add force member to StorageServerConnectionParametersBase
* Added 'force' member to StorageServerConnectionParametersBase.
* Used in order to enable updating a storage connection regardless
to storage domain's status (i.e. also when the domain is not in
status Maintenance).
Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Bug-Url: https://bugzilla.redhat.com/1386610
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/BaseFsStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetUnregisteredBlockStorageDomainsQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageServerConnectionParametersBase.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
13 files changed, 42 insertions(+), 30 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Juan Hernandez: Looks good to me, but someone else must approve
Daniel Erez: Verified
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/64892
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8986e9f62096f3dadf57fca6a01bda622a9557d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months