November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fixed tests
by Code Review 02 Nov '16

02 Nov '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: core: fixed tests ...................................................................... core: fixed tests 1) these tests weren't run by maven. Not sure why, since there are different tests not ending with …Test, and those are run. However renaming them fixed the issue. 2) while these tests weren't run, some errors accumulated in them. This was fixed. 3) added toString method to ReportedConfiguration class for easier debugging. Change-Id: Ib49810bb6bcb9c80acdd777f72727c20301ef742 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsUsingBaseNicTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtilsUsingVlanNicTest.java 3 files changed, 23 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib49810bb6bcb9c80acdd777f72727c20301ef742 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix race between AutoStartVmsRunner and ProcessDownVmC...
by Code Review 02 Nov '16

02 Nov '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Fix race between AutoStartVmsRunner and ProcessDownVmCommand ...................................................................... core: Fix race between AutoStartVmsRunner and ProcessDownVmCommand Issue for killed HA VM: AutoStartVmsRunner acquires lock and runs the HA VM if there's no NEXT_RUN. It causes race condition between removing the NEXT_RUN snapshot in ProcessDownVmCommand.applyNextRunConfiguration() and calling UpdateVmCommand to apply it. The UpdateVmCommand fails to acquire locks if the RunVm command is executed right after the NEXT_RUN snapshot is removed. Fixed by: ProcessDownVmCommand.applyNextRunConfiguration() acquires lock before removing the NEXT_RUN snapshot and passes it to the UpdateVmCommand. The AutoStartVmsRunner keeps failing to acquire the VM lock until the NEXT_RUN is applied. Change-Id: Ie2f1a4a1b114fd95c535f41191cd980311f35f6e Bug-Url: https://bugzilla.redhat.com/1369521 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 43 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65906 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2f1a4a1b114fd95c535f41191cd980311f35f6e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: openstacknetworkproviders must return both openstac...
by Code Review 02 Nov '16

02 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: openstacknetworkproviders must return both openstack and external networks ...................................................................... restapi: openstacknetworkproviders must return both openstack and external networks Change-Id: I8039147b4f294a38a3010e3c962ced862a44b246 Bug-Url: https://bugzilla.redhat.com/1338685 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/openstack/BackendOpenStackNetworkProvidersResource.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8039147b4f294a38a3010e3c962ced862a44b246 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: add a warning if a proxy is in use
by Code Review 02 Nov '16

02 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: network: add a warning if a proxy is in use ...................................................................... network: add a warning if a proxy is in use Add a warning if a proxy is in use, since a not properly configured proxy could prevent the host to reach the engine VM. Change-Id: If40adbfd6e6e54162c750c8908b5e5e9bb586ca6 Bug-Url: https://bugzilla.redhat.com/1387146 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/network/gateway.py 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If40adbfd6e6e54162c750c8908b5e5e9bb586ca6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: timezone: set the VM timezone as the host one
by Code Review 02 Nov '16

02 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: timezone: set the VM timezone as the host one ...................................................................... timezone: set the VM timezone as the host one Change-Id: Iccbf0e3a54e42cfc3a667956f1a38b9834fb5dc9 Bug-Url: https://bugzilla.redhat.com/1318350 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-common/vm/cloud_init.py 2 files changed, 34 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccbf0e3a54e42cfc3a667956f1a38b9834fb5dc9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Use sha256 by default
by Code Review 02 Nov '16

02 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Use sha256 by default ...................................................................... packaging: setup: Use sha256 by default Change the default algorithm from sha1 to sha256. This only affects new certs. To change existing hosts, remove and reinstall them. This patch also does not deal with other existing internal certs, such as the engine's, vmconsole, etc. - for now, run engine-cleanup and engine-setup to have them recreated. Change-Id: I1baad08017774ddb7846100a62cd7e467ca3f785 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/pki/openssl.conf 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yaniv Kaul: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/65927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1baad08017774ddb7846100a62cd7e467ca3f785 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: cockpit-ovirt: add 4.1 jobs
by Code Review 02 Nov '16

02 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: cockpit-ovirt: add 4.1 jobs ...................................................................... cockpit-ovirt: add 4.1 jobs Add 4.1 jobs for cockpit-ovirt Change-Id: I5910249ccf7a65686e48a13dafa857f077eb478a Signed-off-by: Ryan Barry <rbarry(a)redhat.com> --- M jobs/confs/projects/cockpit-ovirt/cockpit-ovirt.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5910249ccf7a65686e48a13dafa857f077eb478a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: HibernateVmCommand#init()
by Code Review 01 Nov '16

01 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: HibernateVmCommand#init() ...................................................................... core: HibernateVmCommand#init() Move initialization logic from constructor to the init() method where it belongs (see 6188d4e for details). Change-Id: I2450a4e009fcdf2a5c2a99e0ee8fc5975c2915c0 Bug-Url: https://bugzilla.redhat.com/1389996 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2450a4e009fcdf2a5c2a99e0ee8fc5975c2915c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Don't run checkstyle on modules/dependencies
by Code Review 01 Nov '16

01 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Don't run checkstyle on modules/dependencies ...................................................................... core: Don't run checkstyle on modules/dependencies A recent patch changed the checstyle configuration so that it runs in all the sub-projectes inside the 'backend' directory. This means that it also runs for the 'backend/modules/dependecies' sub-project. But this sub-project doesn't contain source code, so running checkstyle doesn't help, and it actually prevents some usages of this sub-project. For example, we currently do the following from some CI jobs in order to analyze the dependencies of the project: $ mvn clean package --projects \ backend/manager/dependencies,\ backend/manager/dependencies/common,\ backend/manager/dependencies/tools \ -DskipTests Now this fails becaus it can't find the artifact that contains our custom checstyle rules. To avoid this failure this patch moves the configuration of the checstyle plugin to the sub-directories of the 'backend' directory that do contain source code, where running checstyle is useful. Change-Id: I3630e380b742d100801cb5a1c176ef8a52f3a46b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/extensions-tool/pom.xml M backend/manager/modules/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml 4 files changed, 19 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3630e380b742d100801cb5a1c176ef8a52f3a46b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: 'urandom' required RNG source ignored
by Code Review 01 Nov '16

01 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: 'urandom' required RNG source ignored ...................................................................... restapi: 'urandom' required RNG source ignored Similarly to 'random' RNG source, 'urandom' is next implicit RNG source and thus it is ignored by the mapper - can't be removed. Change-Id: Ifbf6704bd390b0752a12a420c6797616d816caa5 Bug-Url: https://bugzilla.redhat.com/1374227 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbf6704bd390b0752a12a420c6797616d816caa5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0