December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: names of not replugged nics as a variable
by Code Review 27 Dec '16

27 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: names of not replugged nics as a variable ...................................................................... core: names of not replugged nics as a variable ... rather than a class member. These names should not be part of the command's state. Change-Id: I9275e04be429f48f2b1c2e01961a541b2fdb2fe1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/69110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9275e04be429f48f2b1c2e01961a541b2fdb2fe1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FileStatsReturn enhanced for loop
by Code Review 27 Dec '16

27 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: FileStatsReturn enhanced for loop ...................................................................... core: FileStatsReturn enhanced for loop Change-Id: Ica6a8795280df29be4dc30abdc2c2ee7d31dd378 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturn.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/69119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica6a8795280df29be4dc30abdc2c2ee7d31dd378 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FileStatsReturn type inference
by Code Review 27 Dec '16

27 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: FileStatsReturn type inference ...................................................................... core: FileStatsReturn type inference Change-Id: I6e95acde6664823efa916d4bd0f2de47837d925b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/69118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e95acde6664823efa916d4bd0f2de47837d925b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: set a valid singleQxlPci value for v2v VMs
by Code Review 26 Dec '16

26 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: engine: set a valid singleQxlPci value for v2v VMs ...................................................................... engine: set a valid singleQxlPci value for v2v VMs In case of v2v from KVM, the singleQxlPci value of the imported VM was always set to 'true' without any validation (since it isn't read from OVF in case of KVM, it was set to a default value). The singleQxlPci is supported only when the VM's OS is Linux and the Video device type is QXL and only on those cases it should be set to 'true'. Since the singleQxlPci validation is done in updateVm command, in case of a none Linux VM or if video type is not QXL, each update operation via the APIs failed in validation phase. This is the exact senario occured in BZ 1408715. Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Bug-Url: https://bugzilla.redhat.com/1408715 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69147 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: import vm from external source cannot have space in di...
by Code Review 26 Dec '16

26 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: import vm from external source cannot have space in disk alias ...................................................................... core: import vm from external source cannot have space in disk alias AddDiskCommand validation deny having space in disk alias Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82 Bug-Url: https://bugzilla.redhat.com/1404400 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: import vm from external source cannot have space in di...
by Code Review 26 Dec '16

26 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: import vm from external source cannot have space in disk alias ...................................................................... core: import vm from external source cannot have space in disk alias AddDiskCommand validation deny having space in disk alias Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82 Bug-Url: https://bugzilla.redhat.com/1404400 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69125 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: proper handling on failure to unplug passthrough nics
by Code Review 26 Dec '16

26 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: proper handling on failure to unplug passthrough nics ...................................................................... core: proper handling on failure to unplug passthrough nics When we cannot unplug passthough network interfaces of a VM that is to be migrated, runningFailed should be executed to reduce pending resources, for example. Change-Id: I0a6a48cba5de6ea8616f07aa0a982fcbef59c4e0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Arik Hadas: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/69109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a6a48cba5de6ea8616f07aa0a982fcbef59c4e0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Allow raw Cinder disks on VM creation from template
by Code Review 26 Dec '16

26 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow raw Cinder disks on VM creation from template ...................................................................... core: Allow raw Cinder disks on VM creation from template The fix 1362464 blocked raw disk format when creating a VM thinly provisioned from a template as in that case the disks will always be in QCOW format as they are a snapshot on top of the base template image. Cinder disks, however, are selected as raw by design even when thinly provisioned from a template and given the blocking introduced by the bug fix it made it impossible to create VM thinly provisioned from a template with Cinder disks through the webadmin Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Bug-Url: https://bugzilla.redhat.com/1408600 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Allow raw Cinder disks on VM creation from template
by Code Review 26 Dec '16

26 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow raw Cinder disks on VM creation from template ...................................................................... core: Allow raw Cinder disks on VM creation from template The fix 1362464 blocked raw disk format when creating a VM thinly provisioned from a template as in that case the disks will always be in QCOW format as they are a snapshot on top of the base template image. Cinder disks, however, are selected as raw by design even when thinly provisioned from a template and given the blocking introduced by the bug fix it made it impossible to create VM thinly provisioned from a template with Cinder disks through the webadmin Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Bug-Url: https://bugzilla.redhat.com/1408600 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Allow raw Cinder disks on VM creation from template
by Code Review 26 Dec '16

26 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow raw Cinder disks on VM creation from template ...................................................................... core: Allow raw Cinder disks on VM creation from template The fix 1362464 blocked raw disk format when creating a VM thinly provisioned from a template as in that case the disks will always be in QCOW format as they are a snapshot on top of the base template image. Cinder disks, however, are selected as raw by design even when thinly provisioned from a template and given the blocking introduced by the bug fix it made it impossible to create VM thinly provisioned from a template with Cinder disks through the webadmin Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Bug-Url: https://bugzilla.redhat.com/1408600 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6cfcc6a95159bbb565f2bb122af7bc58d67f042 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0