Change in ovirt-engine[master]: packaging: Add a tool to perform vacuum on engine db
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: packaging: Add a tool to perform vacuum on engine db
......................................................................
packaging: Add a tool to perform vacuum on engine db
This tool can perform various vacuum operations without specifying the
engine db credentials.
>From the tool usage:
-a - analyze
-A - analyze only
-f - full vacuum
-t - table(s) to vacuum. Use multi -t table for multi tables
-v - verbose
Change-Id: Iff791f6fddaf729b99bbfea8292a734c6df7e719
Bug-Url: https://bugzilla.redhat.com/1388430
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
A packaging/bin/engine-vacuum.sh
A packaging/bin/generate-pgpass.sh
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/vacuum.py
7 files changed, 226 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68318
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff791f6fddaf729b99bbfea8292a734c6df7e719
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Mordechai Lehrer <mlehrer(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: Don't run vacuum in engine-setup
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Don't run vacuum in engine-setup
......................................................................
Don't run vacuum in engine-setup
Vaccum full is useless on CI - don't run it.
Change-Id: I09f17f2510593ee7d19a78e9fa754d5474aaae09
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M jobs/ovirt-engine_upgrade_to_master/setup.file.otopi
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Simone Tiraboschi: Looks good to me
Eyal Edri: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit https://gerrit.ovirt.org/68716
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09f17f2510593ee7d19a78e9fa754d5474aaae09
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: engine: Fix geo-rep session status
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Fix geo-rep session status
......................................................................
engine: Fix geo-rep session status
Fixing boolean parsing of checkpoint status
Change-Id: I1684a1a3a1b157f170db0fe4e46f606ad85146c5
Bug-Url: https://bugzilla.redhat.com/1398593
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeGeoRepStatusDetail.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69035
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1684a1a3a1b157f170db0fe4e46f606ad85146c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: high-availability is not set on edit template
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: high-availability is not set on edit template
......................................................................
webadmin: high-availability is not set on edit template
When editing a template of a highly-available VM the 'highly available'
property of the template is now set according to the value of the
selected template.
Change-Id: I72d7cc52d7c0f40498017b567227ea2e43bb3042
Bug-Url: https://bugzilla.redhat.com/1406336
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/68981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72d7cc52d7c0f40498017b567227ea2e43bb3042
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: engine : Make update manager also update collectd/fluentd an...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine : Make update manager also update collectd/fluentd and plugins
......................................................................
engine : Make update manager also update collectd/fluentd and plugins
Host upgrade should check for metrics packages
for cluster 4.1. The following packages are
checked and updated
collectd
collectd-disk
collectd-netlink
collectd-virt
collectd-write_http
fluentd
rubygem-fluent-plugin-rewrite-tag-filter
rubygem-fluent-plugin-secure-forward
Change-Id: I0ef9b92ef759d13e1f643eb6681760266f9b2992
Bug-Url: https://bugzilla.redhat.com/1405810
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/HostUpgradeManagerTest.java
A packaging/dbscripts/upgrade/04_01_0650_remove_PackageNamesForCheckUpdate_general_config_value.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
4 files changed, 14 insertions(+), 9 deletions(-)
Approvals:
Martin Peřina: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ef9b92ef759d13e1f643eb6681760266f9b2992
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: import vm from external source cannot have space in di...
by Code Review
>From Shahar Havivi <shavivi(a)redhat.com>:
Shahar Havivi has submitted this change and it was merged.
Change subject: core: import vm from external source cannot have space in disk alias
......................................................................
core: import vm from external source cannot have space in disk alias
AddDiskCommand validation deny having space in disk alias
Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82
Bug-Url: https://bugzilla.redhat.com/1404400
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ec5e80142d31ffa3710b171288637552fefde82
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: Fix some more issues with SDK jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Fix some more issues with SDK jobs
......................................................................
Fix some more issues with SDK jobs
There were two main bugs I hav efixed and added 4.1 to
build artifacts of the python sdk V4.
Bugs were:
- ovirt-engine-sdk repo has been added to gerrit trigger as a list
instead of a string (['ovirt-engine-sdk'] instead of ovirt-engine-sdk
- It was cloned into ovirt-engine-sdk folder and script changed folder
to python-ovirt-engine-sdk4
Change-Id: I4f9dd879f361a95a86aedc77687ccf3beceef7ed
---
M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9dd879f361a95a86aedc77687ccf3beceef7ed
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: ovirt-imageio_build-artifacts 4.1 explicit job info
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: ovirt-imageio_build-artifacts 4.1 explicit job info
......................................................................
ovirt-imageio_build-artifacts 4.1 explicit job info
adding the 4.1 explicit job info for ovirt-imageio_build-artifacts
also updating nightly publisher to take artifacgts from 4.1 job
Change-Id: I7d83720bc1b03f7dc30f14be224c7a743caa9cec
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69083
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d83720bc1b03f7dc30f14be224c7a743caa9cec
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Fix NPE on manage domains for unattached SD.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix NPE on manage domains for unattached SD.
......................................................................
core: Fix NPE on manage domains for unattached SD.
Since unattached SD has no storage pool there is no need to validate
DiscardAfterDeleteSupportedByDcVersion.
Change-Id: I1fc7fd99bfcb2eb387a31de68de75c901462cc24
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fc7fd99bfcb2eb387a31de68de75c901462cc24
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: When cannot move disk, point user to the exact cause
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: When cannot move disk, point user to the exact cause
......................................................................
webadmin: When cannot move disk, point user to the exact cause
When attempting to move a template dependant disk to a storage domain on
which the base image does not exist the specific cause can be seen by
hovering above the target domain box yet it is not trivial for the user
to look there so the general error message was changed to point this fact
Change-Id: If01677d32a78cc23e4514b2ac478000c4de1c03e
Bug-Url: https://bugzilla.redhat.com/1379153
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If01677d32a78cc23e4514b2ac478000c4de1c03e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months