December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: USB controller in osinfo
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: USB controller in osinfo ...................................................................... core: USB controller in osinfo This patch introduces new osinfo option "devices.usb.controller". It will allow to configure VM USB controller per operating system and cluster version when SPICE USB redirection is disabled (VM > Console > USB Support in Webadmin). This settings will not effect used USB controllers when SPICE USB redirection is enabled. Before this patchset engine didn't create any USB controller when SPICE USB redirection was disabled and thus no USB controller device was present in domain XML passed from VDSM to libvirt. Libvirt automatically adds defautl USB controller if domain xml doesn't specify otherwise. Motivation for this patchset is to * allow users to optionally use controllers compatible with new USB specifications (USB 3.1) * some controllers seems not to be compatible with ppc Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8 Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UsbControllerModel.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OsRepositoryImpl.java M backend/manager/modules/utils/src/main/javacc/org/ovirt/engine/core/utils/osinfo/osinfo.jj M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 5 files changed, 80 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfaf61f0695a4462adc35a5d3b24b8a4f652d5b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Default USB controller models
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Default USB controller models ...................................................................... core: Default USB controller models osinfo definitions of usb controller models used when spice usb redirection is disabled. * intel ~ ich9-ehci1 (usb 2.0) * ppc64 ~ nec-xhci (usb 3.0) Change-Id: I8dad734e285130ee283f7977a13af1d49857551a Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dad734e285130ee283f7977a13af1d49857551a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Configurable USB controllers
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Configurable USB controllers ...................................................................... core: Configurable USB controllers VmDeviceUtils.updateUsbSlots() refactored to allow switching between USB controllers for SPICE USB redirection (same as before) and USB controllers defined in osinfo (previously USB controllers were just removed if SPICE USB redirection was disabled). This change allows users to use new controllers compatible with USB 3 and avoid compatibility issues with ppc platform and some controllers. Change-Id: If803eef66a91b099f4b5f99a2f3d2b8b3c30ecc8 Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 171 insertions(+), 70 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68668 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If803eef66a91b099f4b5f99a2f3d2b8b3c30ecc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Populate V3 product_info.version.full_version
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Populate V3 product_info.version.full_version ...................................................................... core: Populate V3 product_info.version.full_version In version 3 of the API the full version of the product is potentially available in two places: product_info.version.full_version product_info.full_version Version 3 of the engine used to populate the second one, but the version 3 compatibility layer of version 4 of the engine populates only the second. This means that clients that still use version 3 of the API won't be able to get this information. To avoid that, this patch changes the V3 compatibility layer so that it populates both places with the same value. Change-Id: If8a60ba2ef333dc87cc113959f5bdb3f35426b09 Bug-Url: https://bugzilla.redhat.com/1405386 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 21ef0fba8779f51a10b6e811bfc55504353f590d) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ProductInfoOutAdapter.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8a60ba2ef333dc87cc113959f5bdb3f35426b09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused parameter 'force' in destroy vm
by Code Review 25 Dec '16

25 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused parameter 'force' in destroy vm ...................................................................... core: remove unused parameter 'force' in destroy vm This field is not used anywhere, therefore it is removed. Change-Id: I6b01fcf05efdbdf74b9b8472f208badd3aee8e63 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsVmsOperation.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyVmVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 6 files changed, 17 insertions(+), 24 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b01fcf05efdbdf74b9b8472f208badd3aee8e63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: add libcrypt-nss to fc25 mock configs
by Code Review 25 Dec '16

25 Dec '16

>From Nadav Goldin <ngoldin(a)redhat.com>: Nadav Goldin has submitted this change and it was merged. Change subject: add libcrypt-nss to fc25 mock configs ...................................................................... add libcrypt-nss to fc25 mock configs This is a work around to allow installing fc25 chroots with yum. Bug-Url: https://ovirt-jira.atlassian.net/browse/OVIRT-935 Change-Id: Icb0a2ac284d0db39e9e2a639175c387f9a7bfe20 Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M mock_configs/fedora-25-x86_64.cfg M mock_configs/fedora-25-x86_64_proxied.cfg 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Nadav Goldin: Verified; Looks good to me, approved; Ready for merge Eyal Edri: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb0a2ac284d0db39e9e2a639175c387f9a7bfe20 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix VM to hosts scheduling policies
by Code Review 25 Dec '16

25 Dec '16

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: core: Fix VM to hosts scheduling policies ...................................................................... core: Fix VM to hosts scheduling policies Fix VM to hosts affinity scheduling policies to calculate violations for hosts correctly. Change-Id: I7b8685531e30788ac9d47c34b18f3aa2be729455 Bug-Url: https://bugzilla.redhat.com/1392393 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/AffinityHostsResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmToHostAffinityFilterPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmToHostAffinityPolicyUnit.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmToHostAffinityWeightPolicyUnit.java 4 files changed, 47 insertions(+), 104 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b8685531e30788ac9d47c34b18f3aa2be729455 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: change the default usb model
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: change the default usb model ...................................................................... core: change the default usb model The default usb model should be piix3-uhci that as opposed to ich9-ehci1 is supposed to work properly with usb devices that require USB-1.0 like smartcard. Change-Id: Ibf9cd1f564cb8d1da8e4a996f37d97d210ced7f9 Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9cd1f564cb8d1da8e4a996f37d97d210ced7f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Use persistent HTTP connections between engine and SSO
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use persistent HTTP connections between engine and SSO ...................................................................... core: Use persistent HTTP connections between engine and SSO The SSO service and the engine authentication filters use HTTP to talk to each other. The implementation of this HTTP dialog is such that a new connection is created for each request. In production environments HTTPS is enabled by default, and that means that for each request new SSL socket and session are created and a new SSL handshake is performed. This is bad for performance, in general, but in certain situations is is also a potential trigger of engine crashes. For example, lets assume that the engine is running in a machine with 2 GiB of RAM and a heap size of 1 GiB, and consider a client that is continually sending authentication requests to the API, the following Python SDK script, for example: #!/usr/bin/python import sys from ovirtsdk.api import API from ovirtsdk.xml import params while True: # Connect to the API: api = API( url="https://engine40.local/ovirt-engine/api", username="admin@internal", password="redhat123", ca_file="/etc/pki/ovirt-engine/ca.pem", ) # Do something ... # Disconnect: api.disconnect() This script, alone, will trigger the creation of thousands of SSL sockets and sessions in the engine, and in the web server. But the SSL socket class is finalizable, and there is space enough in the heap, so those thousands of sockets, already closed, will still be in memory, in the finalizer queue. But those thousands of sockets also hold native resources, like socket buffers, which aren't acounted for in the heap. The result is that the Java virtual machine will consume much more memory than what you would expect, memory that isn't part of the heap. The result, in that 2 GiB machine, is that the out of memory killer of the kernel will trigger, and kill the engine, even if it isn't using all its heap space. This could be addressed with smarter handling of the SSL sockets, but that is well beyond the scope of our project. Alternatively we can try to reuse the HTTP connections, which should save sockets, SSL sessions, SSL handshakes and TCP connections. This patch tries to improve the use of connections, introducing a pool of HTTP connections, where connections are reused as much as possible. The effect is visible running the above Python SDK script and counting the number of SSL socketes that are created: # su -s /bin/sh ovirt # watch 'jmap -histo $(pidof ovirt-engine) | grep SSLSocketImpl' Without this patch the number of sockets is ever increasing, till there engine crashes or there is a garbage collection. In the 2 GiB environment it is in the order of thousands of instances. With the patch, the number is limited to a max of 20 sockets. In the 2 GiB environment it is usually 2 sockets. The patch also introduces two new configuration variables that can be used to adjust the size of the pools of HTTP connections: # The maximum size of the pool of HTTP connections that # the engine uses to communicate with the SSO service: ENGINE_SSO_SERVICE_CLIENT_POOL_SIZE=10 # The maximum size of the pool of HTTP connections that # the SSO service uses to communicate with the engine: SSO_CALLBACK_CLIENT_POOL_SIZE=10 Change-Id: Ifa686b9f73c693ec20e0e51f2c004b6eea9e21bc Related-To: https://bugzilla.redhat.com/1396833 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 88abb6e0f90858e422d249a7ccda7b6c5027aee5) Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/aaa/pom.xml M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/uutils/pom.xml A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpClientBuilder.java M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml M ear/src/main/application/META-INF/jboss-deployment-structure.xml M packaging/services/ovirt-engine/ovirt-engine.conf.in 12 files changed, 437 insertions(+), 224 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa686b9f73c693ec20e0e51f2c004b6eea9e21bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Align 'httpcomponents' version with WildFly
by Code Review 25 Dec '16

25 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Align 'httpcomponents' version with WildFly ...................................................................... core: Align 'httpcomponents' version with WildFly The different components of the 'httpcomponents' project are released indepedently. In particular the 'core' and 'client' parts are released independently and they have different version numbers. In particular the versions included in WildFly are 'httpcore-4.4.1' and 'httpclient-4.5'. But in our POM files we have a single 'httpcomponents.version' property and we assume that they have all the same version. To align with what is really used during runtime this patch removes that property and add the explicit version numbers to for each component. Change-Id: I9211e09b81af582eeb3b6a04fe4d526c699f0394 Related-To: https://bugzilla.redhat.com/1396833 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 7334c536e4ab9f8260b3aeb7cf28fbbf939766f1) Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9211e09b81af582eeb3b6a04fe4d526c699f0394 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0