December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove vm lease on remove vm
by Code Review 21 Dec '16

21 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove vm lease on remove vm ...................................................................... core: remove vm lease on remove vm VM lease should be removed when removing its VM. Note that this is a 'best effort' operation - we remove the VM even if we didn't manage to remove its lease. Change-Id: I0cc52f429d91748e759194baf84085a812bd6c59 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmLeaseVDSParameters.java 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68109 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cc52f429d91748e759194baf84085a812bd6c59 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add and remove vds commands for vm leases
by Code Review 21 Dec '16

21 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: add and remove vds commands for vm leases ...................................................................... core: add and remove vds commands for vm leases This patch adds the VDS commands for adding and removing VM leases as a synchronous operations. Change-Id: Ic5c5c22778cc2c31d0f8d27f2200fa728e91e53f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmLeaseVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddVmLeaseVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RemoveVmLeaseVDSCommand.java 6 files changed, 117 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/68108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5c5c22778cc2c31d0f8d27f2200fa728e91e53f Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sync version commons-collection with WildFly 10.1.0
by Code Review 21 Dec '16

21 Dec '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Sync version commons-collection with WildFly 10.1.0 ...................................................................... core: Sync version commons-collection with WildFly 10.1.0 This patch updates the commons-collections dependency to use the same that is provided by WildFly 10.1.0. Change-Id: If20e8250e6e2b59888a2f4368c84791099eb3b8a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/pom.xml M pom.xml 2 files changed, 1 insertion(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If20e8250e6e2b59888a2f4368c84791099eb3b8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1_beta2
by Code Review 21 Dec '16

21 Dec '16

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1_beta2 ...................................................................... build: ovirt-live-4.1_beta2 Change-Id: I065ed02c2883732ad5e3beed0ec3236823d78ed0 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I065ed02c2883732ad5e3beed0ec3236823d78ed0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Default USB controller models
by Code Review 21 Dec '16

21 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Default USB controller models ...................................................................... core: Default USB controller models osinfo definitions of usb controller models used when spice usb redirection is disabled. * intel ~ ich9-ehci1 (usb 2.0) * ppc64 ~ nec-xhci (usb 3.0) Change-Id: I8dad734e285130ee283f7977a13af1d49857551a Bug-Url: https://bugzilla.redhat.com/1373223 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dad734e285130ee283f7977a13af1d49857551a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: build: version bump for master
by Code Review 21 Dec '16

21 Dec '16

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: build: version bump for master ...................................................................... build: version bump for master Change-Id: Idd1090a5aba226bea474032a24ba70936d7bf4b3 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1090a5aba226bea474032a24ba70936d7bf4b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OsRepository.getOsUsbControllerModel tests
by Code Review 21 Dec '16

21 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: OsRepository.getOsUsbControllerModel tests ...................................................................... core: OsRepository.getOsUsbControllerModel tests Change-Id: I521c07ddf287e746c444f5b4404ab55b971b3ee6 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java 1 file changed, 38 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/68740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I521c07ddf287e746c444f5b4404ab55b971b3ee6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: hide "Read Only" checkbox when selecting the IDE i...
by Code Review 21 Dec '16

21 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: hide "Read Only" checkbox when selecting the IDE interface ...................................................................... webadmin: hide "Read Only" checkbox when selecting the IDE interface Change-Id: I85ecb559ca96e94fc7aa5c1f93c227da75931ba9 Bug-Url: https://bugzilla.redhat.com/1347113 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ecb559ca96e94fc7aa5c1f93c227da75931ba9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: create/attach disks from new VM does nothing
by Code Review 21 Dec '16

21 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: create/attach disks from new VM does nothing ...................................................................... userportal: create/attach disks from new VM does nothing Regression introduced by Ieb1f07fceeff0b7975dc8ab51eab625c38d77fdd It fixed the issue for webadmin but the userportal has been forgotten. This patch fixes it for user portal as well. This particular fix is only a hotfix, the proper solution is proposed to master (https://gerrit.ovirt.org/#/c/67532/) Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147 Bug-Url: https://bugzilla.redhat.com/1406042 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java 6 files changed, 98 insertions(+), 20 deletions(-) Approvals: Tomas Jelinek: Verified Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59b648ba9da627cd70b6a1d5d1dde8d3082c3147 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: Added release notes
by Code Review 21 Dec '16

21 Dec '16

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: packaging: Added release notes ...................................................................... packaging: Added release notes Change-Id: I0faca3df3679589332f1ae24f7d511f574b2a485 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0faca3df3679589332f1ae24f7d511f574b2a485 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0