Change in ovirt-engine[ovirt-engine-4.1]: core: minor refactoring in handling of vds network exceptions
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: minor refactoring in handling of vds network exceptions
......................................................................
core: minor refactoring in handling of vds network exceptions
Change-Id: Ib72d7bff8e16946d151bea712972b5337b9131af
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/…
[View More]modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68762
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib72d7bff8e16946d151bea712972b5337b9131af
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[ovirt-engine-4.1]: restapi: error fix-migratable could be updated independently…
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: error fix-migratable could be updated independently…
......................................................................
restapi: error fix-migratable could be updated independently…
error fix-migratable could be updated independently of passthrough.
Change-Id: Ibbc68b37835867fe7a129c1371f10168f4fb86dc
Bug-Url: https://bugzilla.redhat.com/1406337
Signed-off-…
[View More]by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbc68b37835867fe7a129c1371f10168f4fb86dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[ovirt-engine-4.1]: core: Default USB controller models
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Default USB controller models
......................................................................
core: Default USB controller models
osinfo definitions of usb controller models used when spice usb
redirection is disabled.
* intel ~ ich9-ehci1 (usb 2.0)
* ppc64 ~ nec-xhci (usb 3.0)
Change-Id: I8dad734e285130ee283f7977a13af1d49857551a
Bug-Url: https://bugzilla.…
[View More]redhat.com/1373223
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dad734e285130ee283f7977a13af1d49857551a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[ovirt-engine-4.1]: core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
......................................................................
core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
This patch handles cases when VmBase#clusterId is `null`, i.e. Blank
template and instance types.
Change-Id: Ie37f2708fd7d7d24e580d9533cd9be0e98b573f5
Bug-Url: https://bugzilla.redhat.com/…
[View More]1373223
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37f2708fd7d7d24e580d9533cd9be0e98b573f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[master]: webadmin: Correcting size of VfsNicLabelWidget.
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: Correcting size of VfsNicLabelWidget.
......................................................................
webadmin: Correcting size of VfsNicLabelWidget.
The VfsNicLabelWidget takes minimal to much width to be displayed
without a vertical scrollbar, but does not use all vertical space
available.
The width of the widget, but not it's content, is …
[View More]slightly decreased
to avoid the horizontal scrollbar. The height is increased to use the
available space.
Change-Id: If8ee2325163a64cda5bfa557dd2d71d87f6e088d
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/VfsNicLabelWidget.ui.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68772
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8ee2325163a64cda5bfa557dd2d71d87f6e088d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
[View Less]
8 years
Change in ovirt-engine[master]: webadmin: Correcting height in VfsConfigPopupView.
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: webadmin: Correcting height in VfsConfigPopupView.
......................................................................
webadmin: Correcting height in VfsConfigPopupView.
Since the relative height seems not to work like
expected, the internal height of a panel is hard coded.
This causes the vertical scrollbar is shown if needed.
To gain horizontal space for …
[View More]the scrollbar, the width of
the panel and the popup view is extended.
Change-Id: I017711d70444d7058da159654fedb798af597bd3
Bug-Url: https://bugzilla.redhat.com/1341162
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/VfsConfigPopupView.ui.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I017711d70444d7058da159654fedb798af597bd3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
[View Less]
8 years
Change in ovirt-engine[ovirt-engine-4.1]: Cold Merge: Fix action type
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: Cold Merge: Fix action type
......................................................................
Cold Merge: Fix action type
Fix action type used when running old clod merge flow, and add the task
Id to tasks list. The code probably removed after the refactor we did to
support new cold merge flow.
Change-Id: I2caf6bcad8d678b8d3bbc4e13b2d249ab83038ce
Bug-Url: https://…
[View More]bugzilla.redhat.com/1405817
Signed-off-by: Freddy Rolland <frolland(a)redhat.com>
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Ala Hino: Verified
--
To view, visit https://gerrit.ovirt.org/68841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2caf6bcad8d678b8d3bbc4e13b2d249ab83038ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[master]: core: Update to snmp4j 2.5
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: Update to snmp4j 2.5
......................................................................
core: Update to snmp4j 2.5
Version 2.5 of snmp4j is API compatible with version 2.4, and it has the
advantage that it is available in Maven Central, see the release notes:
http://oosnmp.net/pipermail/snmp4j/2016-May/005682.html
This patch updates to …
[View More]version 2.5.3, so we no longer need to include the
snmp4j Maven repository inside the root POM of the engine.
Change-Id: I6c9591dcfeff69f8baf3f425871434506c1cf14b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67412
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c9591dcfeff69f8baf3f425871434506c1cf14b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-hosted-engine-ha[master]: automation: fix repositories for Fedora
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: automation: fix repositories for Fedora
......................................................................
automation: fix repositories for Fedora
Fixed repositories for Fedora after changes in vdsm requirements.
Added virt preview repo.
Change-Id: Iefd53d876e6d448f640af3de67b18cbe4bbd8a43
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M …
[View More]automation/build-artifacts.repos
D automation/check-merged.repos
A automation/check-merged.repos
D automation/check-patch.repos
A automation/check-patch.repos
5 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefd53d876e6d448f640af3de67b18cbe4bbd8a43
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years
Change in ovirt-engine[master]: Cold Merge: Fix action type
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: Cold Merge: Fix action type
......................................................................
Cold Merge: Fix action type
Fix action type used when running old clod merge flow, and add the task
Id to tasks list. The code probably removed after the refactor we did to
support new cold merge flow.
Change-Id: I2caf6bcad8d678b8d3bbc4e13b2d249ab83038ce
Signed-off-by:…
[View More] Freddy Rolland <frolland(a)redhat.com>
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68757
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2caf6bcad8d678b8d3bbc4e13b2d249ab83038ce
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years