Change in ovirt-engine[ovirt-engine-4.0]: engine: Do not switch last HE node to maintenance mode
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Do not switch last HE node to maintenance mode
......................................................................
engine: Do not switch last HE node to maintenance mode
Prevents HE node from switching to Maintenance mode where there are no more hosts available capable to run the engine VM.
Change-Id: I13c20fba09e5faf9ed720b8758f4084707a59f62
Bug-Url: https://bugzilla.redhat.com/1394570
Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 60 insertions(+), 0 deletions(-)
Approvals:
Denis Chaplygin: Verified
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68444
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13c20fba09e5faf9ed720b8758f4084707a59f62
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Add links to disk storage domains
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Add links to disk storage domains
......................................................................
restapi: Add links to disk storage domains
Currently the server doesn't add links to the elements of the
'disk.storage_domains' list. This happens because the 'LinkHelper'
doesn't take into account that elements of lists may also need links. To
avoid that issue this patch changes the disks resource so that it adds
those links explicitly.
Change-Id: I1243ff5e164c807d06868de812a291cf2034c074
Bug-Url: https://bugzilla.redhat.com/1406064
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b639543c04ecf1d4a49a67d40c70a519e07c3adc)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
2 files changed, 28 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1243ff5e164c807d06868de812a291cf2034c074
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Use ids to calculate intersections
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Use ids to calculate intersections
......................................................................
restapi: Use ids to calculate intersections
Currently when the user uses together the 'filter' and 'search'
mechanisms, the server performs two queries: one with filter only, and
one with search only. Then the it calculates and returns the
intersection. But this intersection is calculated assuming that the
objects returned by both queries can be reliably compared using the
'equals' methods. This isn't true, in general. The net result is that
many times the intersection is empty, when it should't. To avoid that
issue this patch changes the server so that it compares the objects by
id, instead of using the 'equals' method.
Change-Id: Id6fd395ca3d3aea7ab2dcdcdf2438e4c487cfc1f
Bug-Url: https://bugzilla.redhat.com/1402799
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit b1040767587db36211115f156f6dd93ef3fcf2de)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
1 file changed, 49 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68775
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id6fd395ca3d3aea7ab2dcdcdf2438e4c487cfc1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[master]: Update version to 4.2
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Update version to 4.2
......................................................................
Update version to 4.2
A new branch 'sdk_4.1' for version 4.1 of the SDK has just been created
and a new 4.2.0 release of the model has been published. This patch
updates the 'master' branch of the SDK so that it uses the new version
of the model and updates the version number to 4.2.
Change-Id: I7a674e1bb68f7dac13b554e1e69e6005b76c4045
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68761
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a674e1bb68f7dac13b554e1e69e6005b76c4045
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add CHANGES.adoc to .gem and .rpm
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add CHANGES.adoc to .gem and .rpm
......................................................................
Add CHANGES.adoc to .gem and .rpm
This patch changes the SDK so that the CHANGES.adoc file is
automatically added to the generated .gem and .rpm files.
Change-Id: I5d5b0b07d0a36cbd5d350dcaf57c1990701f29cb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit bee3146baa5239084e1264613d988bfe68b760a7)
---
M packaging/spec.el7.in
M packaging/spec.fc23.in
M packaging/spec.fc24.in
M sdk/ovirt-engine-sdk.gemspec
4 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68886
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d5b0b07d0a36cbd5d350dcaf57c1990701f29cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[master]: Add CHANGES.adoc to .gem and .rpm
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add CHANGES.adoc to .gem and .rpm
......................................................................
Add CHANGES.adoc to .gem and .rpm
This patch changes the SDK so that the CHANGES.adoc file is
automatically added to the generated .gem and .rpm files.
Change-Id: I5d5b0b07d0a36cbd5d350dcaf57c1990701f29cb
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/spec.el7.in
M packaging/spec.fc23.in
M packaging/spec.fc24.in
M sdk/ovirt-engine-sdk.gemspec
4 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68884
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d5b0b07d0a36cbd5d350dcaf57c1990701f29cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[ovirt-engine-4.0]: engine-backup: using a flag to track a restored DB
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine-backup: using a flag to track a restored DB
......................................................................
engine-backup: using a flag to track a restored DB
Introducing a new vdcOption flag to track a DB
that has been just restored from a backup.
On a restored DB not all the assumptions are
alwayws valid; for instance we cannot check
HE global maintenance mode there since it
will just report the status at DB backup
creation time and not the actual status.
Change-Id: I8e99b3f2240f157b72051accc96f0114333ffcbd
Bug-Url: https://bugzilla.redhat.com/1403903
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
M packaging/setup/ovirt_engine_setup/engine/constants.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/he.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py
6 files changed, 71 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e99b3f2240f157b72051accc96f0114333ffcbd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: restapi: error fix-migratable could be updated independently…
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: error fix-migratable could be updated independently…
......................................................................
restapi: error fix-migratable could be updated independently…
error fix-migratable could be updated independently of passthrough.
Change-Id: Ibbc68b37835867fe7a129c1371f10168f4fb86dc
Bug-Url: https://bugzilla.redhat.com/1406337
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Martin Mucha: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68855
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbc68b37835867fe7a129c1371f10168f4fb86dc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine[master]: core: vm.vmStatic.maxMemorySizeMb is None
by Code Review
>From Shahar Havivi <shavivi(a)redhat.com>:
Shahar Havivi has submitted this change and it was merged.
Change subject: core: vm.vmStatic.maxMemorySizeMb is None
......................................................................
core: vm.vmStatic.maxMemorySizeMb is None
this is regression from patch:
https://gerrit.ovirt.org/#/c/67747
Change-Id: I3aef340a4dc9277aa26eb75b61111631b577ad1d
Bug-Url: https://bugzilla.redhat.com/1406304
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3aef340a4dc9277aa26eb75b61111631b577ad1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Update CHANGES.adoc for release 4.1.0-alpha1
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Update CHANGES.adoc for release 4.1.0-alpha1
......................................................................
Update CHANGES.adoc for release 4.1.0-alpha1
This patch updates the CHANGES.adoc file, documenting the relevant
changes in release 4.1.0-alpha1.
Change-Id: Icd663f6fc455a613658272dc5b183b46262d153f
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 21f4d63d65d63da640b0c72313876c106a0374a8)
---
M sdk/CHANGES.adoc
1 file changed, 65 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68878
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd663f6fc455a613658272dc5b183b46262d153f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
7 years, 5 months