Change in ovirt-release[virt-sig]: Add .gitreview
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add .gitreview
......................................................................
Add .gitreview
For easier setup, just run git-review -s and you are all set!
Change-Id: I5719d8840773988e9bd36ed5d44bfc1029e4c00f
Signed-off-by: Alan Pevec <alan.pevec(a)redhat.com>
---
A .gitreview
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5719d8840773988e9bd36ed5d44bfc1029e4c00f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: virt-sig
Gerrit-Owner: Alan Pevec <alan.pevec(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: Add new trigger 'on-comment-added'
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Add new trigger 'on-comment-added'
......................................................................
Add new trigger 'on-comment-added'
Added new trigger to standard CI
to run the 'build-artifacts' stage
on demand when adding the comment
'ci please build' to a patch.
The build won't be published to any
repo and can be used for testing.
Also added new template to support
this new trigger, mostly reusing
the standard template
Change-Id: I616f4bfc53135e68386acf7723af53410033c0f5
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/triggers/standard.yaml
2 files changed, 34 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68758
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I616f4bfc53135e68386acf7723af53410033c0f5
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-release[master]: automation: fix repos for fedora consumption
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: fix repos for fedora consumption
......................................................................
automation: fix repos for fedora consumption
recent changes in jenkins now run check-patch on both fedora and centos.
Added diffrentiated repos for the 2 distributions.
Change-Id: Ic23b046f2a4b5eb1a3e8652e7d74d403ee7bda8c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
R automation/check-patch.repos.el7
A automation/check-patch.repos.fc24
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic23b046f2a4b5eb1a3e8652e7d74d403ee7bda8c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: refactor engine yaml file
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: refactor engine yaml file
......................................................................
refactor engine yaml file
Created common engine template
to be used for all stages
Change-Id: I994db5fea1738ae0d81b359ceae805e3fac661ee
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
1 file changed, 41 insertions(+), 84 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68017
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I994db5fea1738ae0d81b359ceae805e3fac661ee
Gerrit-PatchSet: 49
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: formatter: Use formatter on validation
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: formatter: Use formatter on validation
......................................................................
formatter: Use formatter on validation
Change-Id: I1c9b162280a308b4191265a01850f9a869b64338
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c9b162280a308b4191265a01850f9a869b64338
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
......................................................................
core: Fix of NPE in VmDeviceUtils#getUsbControllerModel
This patch handles cases when VmBase#clusterId is `null`, i.e. Blank
template and instance types.
Change-Id: Ie37f2708fd7d7d24e580d9533cd9be0e98b573f5
Bug-Url: https://bugzilla.redhat.com/1373223
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie37f2708fd7d7d24e580d9533cd9be0e98b573f5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: adding 4.1 for system & experimenal flows
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: adding 4.1 for system & experimenal flows
......................................................................
adding 4.1 for system & experimenal flows
Change-Id: I8133db2bc3f2f916ab7aa71e432fa059561a9851
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/deploy_to_experimental.yaml
M jobs/confs/projects/ovirt/system-tests.yaml
M jobs/confs/projects/ovirt/test-experimental-latest-repo.yaml
3 files changed, 5 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68714
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8133db2bc3f2f916ab7aa71e432fa059561a9851
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <david(a)dcaro.es>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: DeactivateStorageDomainWithOvfUpdate - context passing
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: DeactivateStorageDomainWithOvfUpdate - context passing
......................................................................
core: DeactivateStorageDomainWithOvfUpdate - context passing
Currently DeactivateStorageDomainWithOvfUpdate passes its compensation
context to the executed DeactivateStorageDomain command.
When passing the compensation context along the hirerchy, it was decided
in BZ 1364804 that the reponsiblity to revert the compensation data is on
the parent command.
DeactivateStorageDomainWithOvfUpdate is always succesfull (so is its
end methods) - and therefore in case of error in the child command
execution the compensation context isn't reverted which causes the domain
to remain locked.
This patch solves that by not passing the context to the executed
command - so it will have a compensation context of its own.
Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Bug-Url: https://bugzilla.redhat.com/1405772
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/68746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebbb3084d52c7744d1f92a98c31d3a3c916e6e03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in otopi[refs/meta/config]: Update permissions to be inherited from All-Projects
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Update permissions to be inherited from All-Projects
......................................................................
Update permissions to be inherited from All-Projects
Change-Id: Ia79e2f24f01b7904812f8f24b3173ec0c567b026
---
M project.config
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/66195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia79e2f24f01b7904812f8f24b3173ec0c567b026
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[refs/meta/config]: Update permissions for ovirt-engine project
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Update permissions for ovirt-engine project
......................................................................
Update permissions for ovirt-engine project
Remove ovirt-engine-master-maintainers permissions from stable branches
(They still have permissions to push, code-review and verify patches)
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
Change-Id: I4d7f0c7ca64f8307bb829af0ab9575e38a25ae31
---
M project.config
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests
Gil Shinar: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67440
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d7f0c7ca64f8307bb829af0ab9575e38a25ae31
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years