December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SshHostRebootCommand generics
by Code Review 19 Dec '16

19 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: SshHostRebootCommand generics ...................................................................... core: SshHostRebootCommand generics Fix the class declaration to extend VdsCommand<T> instead of the raw VdsCommand as per Java's best practices. Change-Id: I571d5edc56173b814b954ec03be5397aa70ebddd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I571d5edc56173b814b954ec03be5397aa70ebddd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: centos-7: kickstart: drop licacard-ev
by Code Review 19 Dec '16

19 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: centos-7: kickstart: drop licacard-ev ...................................................................... centos-7: kickstart: drop licacard-ev licacard-ev is not needed anymore by qemu-kvm-ev 2.6 and is not available within the repositories. Dropping it to avaoid build failure. Change-Id: I07896ac4bf1bd98efc5f2fd502816818294a7e5e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/centos-7-livecd.cfg 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07896ac4bf1bd98efc5f2fd502816818294a7e5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Build for Fedora 24 instead of Fedora 23
by Code Review 19 Dec '16

19 Dec '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Build for Fedora 24 instead of Fedora 23 ...................................................................... Build for Fedora 24 instead of Fedora 23 The build for Fedora 23 is currently failing. As Fedora 23 isn't a supported platform we don't need to build it. This patch changes the job so that it builds for Fedora 24 instead. Change-Id: I8d8a7e4dbe106d719037649cc64ae422003b2f41 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-api-explorer/ovirt-engine-api-explorer_build-artifacts.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d8a7e4dbe106d719037649cc64ae422003b2f41 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: log if luns break DAD support when synced
by Code Review 18 Dec '16

18 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: log if luns break DAD support when synced ...................................................................... backend: log if luns break DAD support when synced This patch adds an audit log when SyncLunsInfoForBlockStorageDomainCommand finds about existing luns that break their storage domain's discard after delete support. Change-Id: I079f213dba60d0e09a353dfcf7cda16316b06fc2 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 98 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/68523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I079f213dba60d0e09a353dfcf7cda16316b06fc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFr...
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFromDb ...................................................................... core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFromDb Replaced a boiler-plate loops and calls with a leaner and nicer streaming call. Change-Id: I1217f9e51f18317936ab190459e4fe69933c6432 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 8 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1217f9e51f18317936ab190459e4fe69933c6432 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyncLunsInfoForBlockStorageDomainCommand forEach
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: SyncLunsInfoForBlockStorageDomainCommand forEach ...................................................................... core: SyncLunsInfoForBlockStorageDomainCommand forEach Use forEach directly instead of streaming and creating redundant temporary objects. Change-Id: Ie619ef8285adb33e62bc9ef2f8f249e6aa0f1e9e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie619ef8285adb33e62bc9ef2f8f249e6aa0f1e9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFr...
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFromDb ...................................................................... core: SyncLunsInfoForBlockStorageDomainCommand#cleanupLunsFromDb Improved the method performance to collect the IDs of the LUNs from the VG to a single Set once and then use it for searching existing LUNs. Given M luns from the VG and N luns in the DB, this technique does O(N) comparisons instead of O(M*N). Change-Id: Id7dfc76cb7781d6286161b050b4093411269682d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7dfc76cb7781d6286161b050b4093411269682d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove LUNs in batch when syncing
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove LUNs in batch when syncing ...................................................................... core: Remove LUNs in batch when syncing Replaced N calls to LUNDao.remove with a single LUNDao.removeAllInBatch in order to improve performance. Change-Id: I48bedb597bb3631ffb6740f77ed0b8293805d2f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 6 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48bedb597bb3631ffb6740f77ed0b8293805d2f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused ImageTranferDao#getAllIds
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused ImageTranferDao#getAllIds ...................................................................... core: Remove unused ImageTranferDao#getAllIds ImageTransferDao#getAllIds was never used since the day it was introduced, and it doesn't seem as though there are any plans to ever use it, not to mention the fact the same functionality can easily be obtained by existing methods: imageTransferDao.getAll() .stream() .map(BusinessEntity::getId) .collect(Collectors.toList()); This patch removes this unused method from the interface, its implementation and the underlying stored procedure that implements its logic. Change-Id: Iedd95a5377dad641bb908c216201cc638fc3c6cf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageTransferDaoImpl.java M packaging/dbscripts/image_transfers_sp.sql 3 files changed, 0 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd95a5377dad641bb908c216201cc638fc3c6cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RestoreStatelessVmCommand DAO usage
by Code Review 18 Dec '16

18 Dec '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: RestoreStatelessVmCommand DAO usage ...................................................................... core: RestoreStatelessVmCommand DAO usage The DAOs methods that return Lists guarantee that if they don't retrieve any data they return an empty List, not a null. Checking such a DAO call's result for nullability is redundant at best and confusing at worst. Change-Id: I84702bf5ee82c1f55aa2886d839b228b69b3242c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/68675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84702bf5ee82c1f55aa2886d839b228b69b3242c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0