Change in ovirt-engine-sdk[sdk_4.0]: Add examples of how to work with tags
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ied84d6e82210f81c891cfc03a2328060b43f08d7
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 1417b18b4ca74b2400a3910a0afbdff2bd4258ec)
---
A sdk/examples/add_tag.py
A sdk/examples/assign_tag_to_vm.py
A sdk/examples/list_tags.py
A sdk/examples/list_tags_of_vm.py
A sdk/examples/remove_tag.py
A sdk/examples/unassign_tag_to_vm.py
6 files changed, 329 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied84d6e82210f81c891cfc03a2328060b43f08d7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-java[sdk_4.0]: Add examples of how to work with tags
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ibb68a2e86a65c73b5b22fd3a39a2b83bd75c70f8
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 2b722b5b212333396d53c309b613f07f527c9f29)
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddTag.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignTagToVm.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListTags.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmTags.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/RemoveTag.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/UnassignTagToVm.java
6 files changed, 350 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb68a2e86a65c73b5b22fd3a39a2b83bd75c70f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-java[master]: Add examples of how to work with tags
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ibb68a2e86a65c73b5b22fd3a39a2b83bd75c70f8
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddTag.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignTagToVm.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListTags.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmTags.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/RemoveTag.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/UnassignTagToVm.java
6 files changed, 350 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68344
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb68a2e86a65c73b5b22fd3a39a2b83bd75c70f8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk[master]: Add examples of how to work with tags
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ied84d6e82210f81c891cfc03a2328060b43f08d7
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/examples/add_tag.py
A sdk/examples/assign_tag_to_vm.py
A sdk/examples/list_tags.py
A sdk/examples/list_tags_of_vm.py
A sdk/examples/remove_tag.py
A sdk/examples/unassign_tag_to_vm.py
6 files changed, 329 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied84d6e82210f81c891cfc03a2328060b43f08d7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: repoclosure: fedora: add virt-preview repository
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: repoclosure: fedora: add virt-preview repository
......................................................................
repoclosure: fedora: add virt-preview repository
Added virt-preview repository as fedora dependencies provider.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1398321
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Change-Id: I87e29934fa3f87ff4b02f2c7ebc91b575ff14a92
---
M jobs/packaging/repo_closure_check.sh
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for review
Eyal Edri: Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67814
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87e29934fa3f87ff4b02f2c7ebc91b575ff14a92
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: refactoring fixes
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: refactoring fixes
......................................................................
core: refactoring fixes
• used @Inject
• moved vfScheduler.getVnicToVfMap into markVfsAsUsedByVm where it
belongs
• removed inconsistency between getName and getDeviceName
Change-Id: I81ce3f24badfdd60021d04b6db8944137c416005
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VfSchedulerImpl.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PlugAction.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnplugNicVDSCommand.java
7 files changed, 36 insertions(+), 31 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81ce3f24badfdd60021d04b6db8944137c416005
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: ovirt-vmconsole-helper: more debug logs
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: ovirt-vmconsole-helper: more debug logs
......................................................................
ovirt-vmconsole-helper: more debug logs
Investigating rhbz#1388244 demonstrated that we could use a bit more
logs.
Change-Id: I32a80f85d10938c0293bfb76265c8fb6f7bab030
Related-To: https://bugzilla.redhat.com/1388244
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
Francesco Romani: Verified
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32a80f85d10938c0293bfb76265c8fb6f7bab030
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: refactored overgrown method
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: refactored overgrown method
......................................................................
core: refactored overgrown method
as command itself is named: Activate[or]Deactivate … ~ this is
overgrown. Method executeVmCommand is repeatedly asking over and over,
what it actually should do, plug or unplug. So it's quite clear, that
this method should be split, which is very easy to do.
work process:
1. implement new method with switch.
2. duplicate original method, one for plug, one for unplug.
3. since swith already made decision, we might re-set variables
isNicToBePlugged and isNicToBeUnplugged to constants, true/false.
4. fix all static analysis problems. Example "if (null != null) {}"
can be removed.
both method should be much easier to grasp, since both methods now
fit PC screen, lost of conditions simply disappeared, and we are
solving one usecase at time. Unplug method became very short and easy.
Change-Id: Ifbce80c40105e1ac41529752eac099125a9ca1bc
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 42 insertions(+), 29 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbce80c40105e1ac41529752eac099125a9ca1bc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: removed conditioning upon transitive data
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: removed conditioning upon transitive data
......................................................................
core: removed conditioning upon transitive data
• removed conditioning upon variable, which value is implied by
something else. That something else is what we should test.
• unified usage of comparing PlugAction enum values
Change-Id: If638952c9fc595e304a426209efcc8b2fe520258
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 11 insertions(+), 10 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If638952c9fc595e304a426209efcc8b2fe520258
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: removed duplicity + potential NPE
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: removed duplicity + potential NPE
......................................................................
core: removed duplicity + potential NPE
IIUC vmDevice.getHostDevice() shouldn't be null, because if it is, it
will throw NPE latter in process. If that's true, we can remove this
duplicity and simplify code.
Change-Id: Iea7fc8d86173b94702df1a7b1781670dc01c6a76
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea7fc8d86173b94702df1a7b1781670dc01c6a76
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years