Change in ovirt-engine[master]: core: extracted method for acquiring VF
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: extracted method for acquiring VF
......................................................................
core: extracted method for acquiring VF
method acquiring VF was extracted from executeVmCommand. I need to
reuse that method and executeVmCommand is badly overgrown, so this
will help it as well.
Change-Id: I417c263ad6e5bda5b87fa4c61c889cf61ba33f9b
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 21 insertions(+), 19 deletions(-)
Approvals:
Marcin Mirecki: Looks good to me, but someone else must approve
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I417c263ad6e5bda5b87fa4c61c889cf61ba33f9b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add examples of how to work with tags
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ie480fdd05ddd7e11dddb7bd487d193e16734a440
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 039db24fd75aea377b46a5e833425b9d99a3e5c0)
---
A sdk/examples/add_tag.rb
A sdk/examples/assign_tag_to_vm.rb
A sdk/examples/list_tags.rb
A sdk/examples/list_tags_of_vm.rb
A sdk/examples/remove_tag.rb
A sdk/examples/unassign_tag_to_vm.rb
6 files changed, 305 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68343
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie480fdd05ddd7e11dddb7bd487d193e16734a440
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine-sdk-ruby[master]: Add examples of how to work with tags
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add examples of how to work with tags
......................................................................
Add examples of how to work with tags
This patch adds an examples of how to work with tags.
Change-Id: Ie480fdd05ddd7e11dddb7bd487d193e16734a440
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
A sdk/examples/add_tag.rb
A sdk/examples/assign_tag_to_vm.rb
A sdk/examples/list_tags.rb
A sdk/examples/list_tags_of_vm.rb
A sdk/examples/remove_tag.rb
A sdk/examples/unassign_tag_to_vm.rb
6 files changed, 305 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie480fdd05ddd7e11dddb7bd487d193e16734a440
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: publishers: added 4.1 nightly publisher
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publishers: added 4.1 nightly publisher
......................................................................
publishers: added 4.1 nightly publisher
Change-Id: Ied1e984eede38ff3385c13b355f4d6763d5ac34c
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
M jobs/confs/yaml/builders/copy-create-job-artifact.yaml
2 files changed, 261 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Barak Korren: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied1e984eede38ff3385c13b355f4d6763d5ac34c
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: Make the "No filter" option available in the vNIC profile ne...
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: Make the "No filter" option available in the vNIC profile network filter dialog
......................................................................
Make the "No filter" option available in the vNIC profile network filter dialog
The 'vnicProfileNoFilter' message is displayed in two different ways.
One is as plain text, the other is as HTML. As HTML it can not contain < or >,
or it will not be displayed correctly.
Change-Id: Iade7c971beccf3197a605aa52815dbeb225e8075
Bug-Url: https://bugzilla.redhat.com/1388957
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68071
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iade7c971beccf3197a605aa52815dbeb225e8075
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: improve handling of 3.6 hosts in 4.x clusters
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: improve handling of 3.6 hosts in 4.x clusters
......................................................................
engine: improve handling of 3.6 hosts in 4.x clusters
Hosts not supporting cluster versions >= 4.0 does not report their
switch type. Such hosts to a cluster versions >= 4.0 get in a blocked
state, because their capabilities could not parsed because of the
missing switch type.
This patch makes the switch type required only for hosts, which claim
to support a cluster version >= 4.0, independently of the used
compatibility version of the cluster. This enables hosts to fail nicely by the
HandleVdsVersionCommand when added to a cluster of an unsupported
version.
Change-Id: I6e44f2650daf509216435e2d8f92310486cd9864
Bug-Url: https://bugzilla.redhat.com/1375573
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e44f2650daf509216435e2d8f92310486cd9864
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Use persistent HTTP connections between engine and SSO
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Use persistent HTTP connections between engine and SSO
......................................................................
core: Use persistent HTTP connections between engine and SSO
The SSO service and the engine authentication filters use HTTP
to talk to each other. The implementation of this HTTP dialog
is such that a new connection is created for each request. In
production environments HTTPS is enabled by default, and that
means that for each request new SSL socket and session are
created and a new SSL handshake is performed. This is bad for
performance, in general, but in certain situations is is also
a potential trigger of engine crashes. For example, lets
assume that the engine is running in a machine with 2 GiB of
RAM and a heap size of 1 GiB, and consider a client that is
continually sending authentication requests to the API, the
following Python SDK script, for example:
#!/usr/bin/python
import sys
from ovirtsdk.api import API
from ovirtsdk.xml import params
while True:
# Connect to the API:
api = API(
url="https://engine40.local/ovirt-engine/api",
username="admin@internal",
password="redhat123",
ca_file="/etc/pki/ovirt-engine/ca.pem",
)
# Do something ...
# Disconnect:
api.disconnect()
This script, alone, will trigger the creation of thousands of
SSL sockets and sessions in the engine, and in the web server.
But the SSL socket class is finalizable, and there is space
enough in the heap, so those thousands of sockets, already
closed, will still be in memory, in the finalizer queue. But
those thousands of sockets also hold native resources, like
socket buffers, which aren't acounted for in the heap. The
result is that the Java virtual machine will consume much more
memory than what you would expect, memory that isn't part of
the heap. The result, in that 2 GiB machine, is that the out
of memory killer of the kernel will trigger, and kill the
engine, even if it isn't using all its heap space.
This could be addressed with smarter handling of the SSL
sockets, but that is well beyond the scope of our project.
Alternatively we can try to reuse the HTTP connections, which
should save sockets, SSL sessions, SSL handshakes and TCP
connections.
This patch tries to improve the use of connections,
introducing a pool of HTTP connections, where connections are
reused as much as possible.
The effect is visible running the above Python SDK script and
counting the number of SSL socketes that are created:
# su -s /bin/sh ovirt
# watch 'jmap -histo $(pidof ovirt-engine) | grep SSLSocketImpl'
Without this patch the number of sockets is ever increasing,
till there engine crashes or there is a garbage collection.
In the 2 GiB environment it is in the order of thousands of
instances.
With the patch, the number is limited to a max of 20 sockets.
In the 2 GiB environment it is usually 2 sockets.
The patch also introduces two new configuration variables that can be
used to adjust the size of the pools of HTTP connections:
# The maximum size of the pool of HTTP connections that
# the engine uses to communicate with the SSO service:
ENGINE_SSO_SERVICE_CLIENT_POOL_SIZE=10
# The maximum size of the pool of HTTP connections that
# the SSO service uses to communicate with the engine:
SSO_CALLBACK_CLIENT_POOL_SIZE=10
Change-Id: Ifa686b9f73c693ec20e0e51f2c004b6eea9e21bc
Related-To: https://bugzilla.redhat.com/1396833
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/aaa/pom.xml
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java
M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java
M backend/manager/modules/aaa/src/main/modules/org/ovirt/engine/core/aaa/main/module.xml
M backend/manager/modules/enginesso/pom.xml
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/InteractiveChangePasswdServlet.java
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java
M backend/manager/modules/uutils/pom.xml
A backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpClientBuilder.java
M backend/manager/modules/uutils/src/main/modules/org/ovirt/engine/core/uutils/main/module.xml
M ear/src/main/application/META-INF/jboss-deployment-structure.xml
M packaging/services/ovirt-engine/ovirt-engine.conf.in
12 files changed, 421 insertions(+), 222 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa686b9f73c693ec20e0e51f2c004b6eea9e21bc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Align 'httpcomponents' version with WildFly
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Align 'httpcomponents' version with WildFly
......................................................................
core: Align 'httpcomponents' version with WildFly
The different components of the 'httpcomponents'
project are released indepedently. In particular
the 'core' and 'client' parts are released
independently and they have different version
numbers. In particular the versions included in
WildFly are 'httpcore-4.4.1' and 'httpclient-4.5'.
But in our POM files we have a single
'httpcomponents.version' property and we assume
that they have all the same version. To align
with what is really used during runtime this
patch removes that property and add the explicit
version numbers to for each component.
Change-Id: I9211e09b81af582eeb3b6a04fe4d526c699f0394
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9211e09b81af582eeb3b6a04fe4d526c699f0394
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-hosted-engine-setup[master]: core: prepend action-specific readme file to initial prompt ...
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: core: prepend action-specific readme file to initial prompt text
......................................................................
core: prepend action-specific readme file to initial prompt text
Change-Id: Iccce5e8aeb5ecc4e591d544a9e0225bf34b19d39
Bug-Url: https://bugzilla.redhat.com/1370041
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M Makefile.am
M ovirt-hosted-engine-setup.spec.in
A readme.appliance
A readme.rollback
M src/ovirt_hosted_engine_setup/Makefile.am
M src/ovirt_hosted_engine_setup/config.py.in
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/gr-he-rollbackupgrade/core/misc.py
M src/plugins/gr-he-upgradeappliance/core/misc.py
10 files changed, 48 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccce5e8aeb5ecc4e591d544a9e0225bf34b19d39
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: extract creation of failing message from inappropriate...
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: extract creation of failing message from inappropriate method
......................................................................
core: extract creation of failing message from inappropriate method
Change-Id: I50ce3f034093f4dab386beb3f0c2b340055c0554
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 10 insertions(+), 11 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67309
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50ce3f034093f4dab386beb3f0c2b340055c0554
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years