Change in jenkins[master]: Revert "qemu: use 7.3 beta repo"
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: Revert "qemu: use 7.3 beta repo"
......................................................................
Revert "qemu: use 7.3 beta repo"
This reverts commit ecc8458f4751e3afc320d33b01351564c67cc775.
dropping beta repo since 7.3 is now publicly available
Change-Id: I21c109955dd6094dbb9a8c6cec7a1a8d6e548581
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M …
[View More]jobs/confs/projects/qemu/qemu_create-rpms.yaml
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Ready for review
Eyal Edri: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68279
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21c109955dd6094dbb9a8c6cec7a1a8d6e548581
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: packaging: Fix systemd dependencies for engine and notifier
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: Fix systemd dependencies for engine and notifier
......................................................................
packaging: Fix systemd dependencies for engine and notifier
Replaces network.service systemd dependency for ovirt-engine and
ovirt-engine-notifier with network.target as networks.service has been
deprecated.
Change-Id: …
[View More]Iecce56fdc2a157ce4a5c49244e3d6c7363ca50c8
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.systemd.in
M packaging/services/ovirt-engine/ovirt-engine.systemd.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecce56fdc2a157ce4a5c49244e3d6c7363ca50c8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: packaging: Fix systemd service deps for websocket-proxy
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: Fix systemd service deps for websocket-proxy
......................................................................
packaging: Fix systemd service deps for websocket-proxy
Adds dependency on network.target for ovirt-websocket-proxy
service, so it's started when network services are available.
Change-Id: I1970e1ea4988cc1655d0972260088d4577fa65b4
Signed-…
[View More]off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.systemd.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68061
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1970e1ea4988cc1655d0972260088d4577fa65b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: packaging: Fix systemd service deps for fence-kdump listener
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: packaging: Fix systemd service deps for fence-kdump listener
......................................................................
packaging: Fix systemd service deps for fence-kdump listener
Adds dependency on network.target and postgresql service for
ovirt-fence-kdump-listener service, so it's started after those
services.
Change-Id: …
[View More]I157d98d3fc7be61ed9371bbf04fac22dc7b7782c
Bug-Url: https://bugzilla.redhat.com/1393345
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.systemd.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I157d98d3fc7be61ed9371bbf04fac22dc7b7782c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: webadmin: Add icon showing if a VM is Hosted Engine
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Add icon showing if a VM is Hosted Engine
......................................................................
webadmin: Add icon showing if a VM is Hosted Engine
Extend VmTypeColumn to show multiple icons.
Change-Id: I95436d6c59b03c31b21ea88d57380bfdc57c9728
Bug-Url: https://bugzilla.redhat.com/1392389
Signed-off-by: Andrej Krejcir <akrejcir(a)…
[View More]redhat.com>
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmTypeColumn.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
11 files changed, 67 insertions(+), 25 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
Vojtech Szocs: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66250
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95436d6c59b03c31b21ea88d57380bfdc57c9728
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: branding: Add New User Portal to welcome page
by Code Review
>From Vojtech Szocs <vszocs(a)redhat.com>:
Vojtech Szocs has submitted this change and it was merged.
Change subject: branding: Add New User Portal to welcome page
......................................................................
branding: Add New User Portal to welcome page
Technical Preview of new User portal called "Web UI"
is added to the welcome page.
Project: https://github.com/mareklibra/userportal
Trello: https://trello.com/c/blwDpjcJ/24-poc-userportal-replacement
…
[View More]Change-Id: Iaa7d5fffbb83171bb29e26a38dba41ef3d4fc56f
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
M packaging/branding/ovirt.brand/messages.properties
M packaging/branding/ovirt.brand/welcome_page.template
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Marek Libra: Verified
Vojtech Szocs: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/67255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa7d5fffbb83171bb29e26a38dba41ef3d4fc56f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: core: Remove ChangeFloppy functionality
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove ChangeFloppy functionality
......................................................................
core: Remove ChangeFloppy functionality
The ChangeFloppy functionality is not used anywhere in the code, and
could (should) therefore be removed to make the codebase easier to
maintain.
This claim is confirmed by the fact the ChangeFloppyCommand's
…
[View More]constructor calls getVm(), which, in turn calls VmDao. Commit
f0dc3d (merged on 25/10/2016) introduced injection for this Dao in
AuditLoggableBase, meaning that the DAO would not yet be initialized in
the constructor, and calling it would fail with a NullPointerException,
making this command unusable.
This patch removes the following:
1. The ChangeFloppyCommand and its corresponding enum constant in
VdcActionType.
2. The ChangeFloppyVDSCommand it calls, its corresponding enum
constant in VDSCommandType, the IVdsServer method it calls and its
implementation in JsonRpcVdsServer.
3. AuditLog constants and messages only used by this command.
Change-Id: I2ef2972e120a357bd13511b502ce0db8b35711fe
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ChangeFloppyVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
8 files changed, 0 insertions(+), 78 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ef2972e120a357bd13511b502ce0db8b35711fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-live[ovirt-live-4.0]: fix nautilus-open-terminal package issue
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged.
Change subject: fix nautilus-open-terminal package issue
......................................................................
fix nautilus-open-terminal package issue
In RHEL/CentOS 7.3 the package was replaced with
the package named gnome-terminal-nautilus.
This patch updates the kickstart file.
Change-Id: I7123a1821939a9d4f699eadc600187118d155f23
Signed-off-by: Lev Veyde <lveyde(a)…
[View More]redhat.com>
---
M centos-7/kickstart/centos-7-livecd.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/68212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7123a1821939a9d4f699eadc600187118d155f23
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.0
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: backend: rename PostZero to PostDeleteAction
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: rename PostZero to PostDeleteAction
......................................................................
backend: rename PostZero to PostDeleteAction
This patch renames PostZero and PostZeroHandler to PostDeleteAction and
PostDeleteActionHandler as there may be more things than posting zeros
on the storage that we would like to do right before removing a disk or
…
[View More]a snapshot, like discard their blocks for example.
Therefore, the name should be more general.
Change-Id: Icadbfdaf2f02bb107e5960fc7dbda95de4ca608a
Related-To: https://bugzilla.redhat.com/1342919
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemoverFromExportDomain.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveTemplateSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateImageTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/DestroyImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandler.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostDeleteActionHandlerTest.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/PostZeroHandlerTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyImageVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeleteImageGroupVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/PostDeleteAction.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/PostZero.java
19 files changed, 112 insertions(+), 112 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/67845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icadbfdaf2f02bb107e5960fc7dbda95de4ca608a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month
Change in ovirt-engine[master]: backend: generalize method names in BlockStorageDiscardFunct...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: backend: generalize method names in BlockStorageDiscardFunctionalityHelper
......................................................................
backend: generalize method names in BlockStorageDiscardFunctionalityHelper
This patch distinguishes between pass discard functionality, discard
after delete functionality and general discard functionality (that
includes both). …
[View More]Thus, it:
1. Renames methods in BlockStorageDiscardFunctionalityHelper to be more
informative.
2. Moves the generation of validation results from
ExtendStorageDomainCommand::validate to
BlockStorageDiscardFunctionalityHelper as there may be other
validation results that may be returned from
isExistingDiscardFunctionalityPreserved in
BlockStorageDiscardFunctionalityHelper (will be done in the next
patch).
Change-Id: Iac82b8a792daa6300f6e6f68c306fe8f0fc182aa
Related-To: https://bugzilla.redhat.com/1342919
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ExtendSANStorageDomainCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelperTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 50 insertions(+), 37 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/67846
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac82b8a792daa6300f6e6f68c306fe8f0fc182aa
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
8 years, 1 month