December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: migration progress events
by Code Review 08 Dec '16

08 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: migration progress events ...................................................................... core: migration progress events Since 4.1 we receive migration progress via events rather than by polling VmStats. Change-Id: I057b70fad8525b2a111fe1ac80a403ab33ea6c47 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmMigrationProgressMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 8 files changed, 119 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/67579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I057b70fad8525b2a111fe1ac80a403ab33ea6c47 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: various fixes in sysprep XML templates
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: various fixes in sysprep XML templates ...................................................................... engine: various fixes in sysprep XML templates The commit performs several commits: 1) Reorder elements in the template The order of elements is arbitrary to some degree. The commit reorders the elements so that the order is same between 32-bit and 64-bit version of the XML. This leads to nicer diffs and makes it easier to spot errors. In the process some useless comments were removed. 2) Change x86 sections to amd64 in 64-bit templates Each component block in the sysprep template is tied to the architecture. We have had mistakenly some of the blocks marked as x86 in templates for 64-bit systems. 3) Fix messed up locales in sysprep templates There were following problems with locales: - some locales were expanded from wrong variables - some locales had value en-US hardcoded - some input locales used hardcoded 0409:00000409 (that is US keyboard) Bug-Url: https://bugzilla.redhat.com/1402817 Change-Id: I33840d74d157efddeb280a52318517d8b15db29f Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w10 M packaging/conf/sysprep/sysprep.w10x64 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8 M packaging/conf/sysprep/sysprep.w8x64 8 files changed, 148 insertions(+), 167 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/67988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33840d74d157efddeb280a52318517d8b15db29f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : sdm create VM from template
by Code Review 08 Dec '16

08 Dec '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: engine : sdm create VM from template ...................................................................... engine : sdm create VM from template When creating a VM from template as Clone/Independent, the template disks are copied. This operation can consume a lot of time and resources. Until now data operations on the hosts were performed only on the elected SPM, causing a potential bottleneck. In this patch, the copy operation of the disks can be performed also on other hosts, not only the SPM. Change-Id: I9358478d9f76804ea6a71c2a8895dcc512e6b52c Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java 8 files changed, 126 insertions(+), 62 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9358478d9f76804ea6a71c2a8895dcc512e6b52c Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: jsonrpc: version bump
by Code Review 08 Dec '16

08 Dec '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-url: https://bugzilla.redhat.com/1401585 Change-Id: Ib2321df1c2adf3fa66a2bb7a77d1fd4543f91b39 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67883 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2321df1c2adf3fa66a2bb7a77d1fd4543f91b39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused injections of HostedEngineHelper in stor...
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remove unused injections of HostedEngineHelper in storage classses ...................................................................... core: Remove unused injections of HostedEngineHelper in storage classses Change-Id: Id84c56d7b2c10028f848c3570cfa8e72fa89fd08 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 3 files changed, 0 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id84c56d7b2c10028f848c3570cfa8e72fa89fd08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: reorder elements in sysprep XML templates
by Code Review 08 Dec '16

08 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: engine: reorder elements in sysprep XML templates ...................................................................... engine: reorder elements in sysprep XML templates The order of elements is arbitrary to some degree. The commit reorders the elements so that the order is same between 32-bit and 64-bit version of the XML. This leads to nicer diffs and makes it easier to spot errors. In the process some useless comments were removed. Apart from this the commit does not introduce any changes to the elements themselves. Change-Id: Ide66a00cc64a653828a8ca4d376e139811aa6574 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w10x64 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8x64 4 files changed, 107 insertions(+), 126 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/67948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide66a00cc64a653828a8ca4d376e139811aa6574 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix messed up locales in sysprep templates
by Code Review 08 Dec '16

08 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: engine: fix messed up locales in sysprep templates ...................................................................... engine: fix messed up locales in sysprep templates There were following problems with locales: - some locales were expanded from wrong variables - some locales had value en-US hardcoded - some input locales used hardcoded 0409:00000409 (that is US keyboard) Change-Id: I5db8c7370e740c88351dae1c7bce22ebe4db7792 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.2k8 M packaging/conf/sysprep/sysprep.2k8x64 M packaging/conf/sysprep/sysprep.w10 M packaging/conf/sysprep/sysprep.w8 5 files changed, 19 insertions(+), 19 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/67950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5db8c7370e740c88351dae1c7bce22ebe4db7792 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: change x86 sections to amd64 in 64-bit templates
by Code Review 08 Dec '16

08 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: engine: change x86 sections to amd64 in 64-bit templates ...................................................................... engine: change x86 sections to amd64 in 64-bit templates Each component block in the sysprep template is tied to the architecture. We have had mistakenly some of the blocks marked as x86 in templates for 64-bit systems. Change-Id: Iabcf8a26c123b6fa0995231be4db41bb21261084 Bug-Url: https://bugzilla.redhat.com/1387699 Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com> --- M packaging/conf/sysprep/sysprep.2k12x64 M packaging/conf/sysprep/sysprep.w10x64 M packaging/conf/sysprep/sysprep.w7x64 M packaging/conf/sysprep/sysprep.w8x64 4 files changed, 22 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve Tomas Golembiovsky: Verified -- To view, visit https://gerrit.ovirt.org/67949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabcf8a26c123b6fa0995231be4db41bb21261084 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Update cloud-init example with custom script
by Code Review 08 Dec '16

08 Dec '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update cloud-init example with custom script ...................................................................... Update cloud-init example with custom script This patch updates run vm with cloud-init example, with custom script, which will be executed when VM is deployed. Change-Id: I9de04e90187fe001f63378b22631cfc6f7278d8a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit e5a1889f1d5dd228f7014dedbac663653223b400) --- M sdk/examples/start_vm_with_cloud_init.rb 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9de04e90187fe001f63378b22631cfc6f7278d8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: jsonrpc: version bump
by Code Review 08 Dec '16

08 Dec '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: jsonrpc: version bump ...................................................................... jsonrpc: version bump Bug-url: https://bugzilla.redhat.com/1401585 Change-Id: Ib2321df1c2adf3fa66a2bb7a77d1fd4543f91b39 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2321df1c2adf3fa66a2bb7a77d1fd4543f91b39 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0