December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.6]: core: Fix CloneVmCommand when the VM is based on template
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix CloneVmCommand when the VM is based on template ...................................................................... core: Fix CloneVmCommand when the VM is based on template In case of a VM based on template the decision whether the command is using a callback or not is determined in the superclass AddVmCommand wrongly, the decision was moved to CloneVmCommand itself and is determined according to whether the VM has disks or not Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Bug-Url: https://bugzilla.redhat.com/1395793 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix CloneVmCommand when the VM is based on template
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix CloneVmCommand when the VM is based on template ...................................................................... core: Fix CloneVmCommand when the VM is based on template In case of a VM based on template the decision whether the command is using a callback or not is determined in the superclass AddVmCommand wrongly, the decision was moved to CloneVmCommand itself and is determined according to whether the VM has disks or not Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Bug-Url: https://bugzilla.redhat.com/1395793 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: altered VnicProfileMapper to pass 'migratable' prop...
by Code Review 08 Dec '16

08 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: altered VnicProfileMapper to pass 'migratable' property ...................................................................... restapi: altered VnicProfileMapper to pass 'migratable' property Change-Id: Ib7eee5299419effc83dfd1c4b53c291a2f4fa125 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VnicProfileMapper.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7eee5299419effc83dfd1c4b53c291a2f4fa125 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: add `migratable` property to new/edit vNicProfile ...
by Code Review 08 Dec '16

08 Dec '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: add `migratable` property to new/edit vNicProfile popup. ...................................................................... webadmin: add `migratable` property to new/edit vNicProfile popup. Change-Id: Ied957d9246a488c3a841ddec3d60792745503174 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 7 files changed, 39 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied957d9246a488c3a841ddec3d60792745503174 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: force updating file storage server connection
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: force updating file storage server connection ...................................................................... core: force updating file storage server connection When force flag is passed to UpdateStorageServerConnectionCommand, updating file storage server connection regardless to storage domain's status. Change-Id: I089f53a8efad43d6de76f9a662a3e5a44d8802a6 Bug-Url: https://bugzilla.redhat.com/1386610 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Verified -- To view, visit https://gerrit.ovirt.org/67971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I089f53a8efad43d6de76f9a662a3e5a44d8802a6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Lazily initialize disks in CloneVmCommand
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Lazily initialize disks in CloneVmCommand ...................................................................... core: Lazily initialize disks in CloneVmCommand Each call to getAdjustedDiskImagesFromConfiguration resulted an invocation of a query, after the first load of the disks the query results were not used and resulted in a useless dao call. This patch fixes the lazy initializtion to run correctly. Change-Id: I78cc9ecfa5916972ad06fc85c3054c703e322108 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78cc9ecfa5916972ad06fc85c3054c703e322108 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix CloneVmCommand when the VM is based on template
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix CloneVmCommand when the VM is based on template ...................................................................... core: Fix CloneVmCommand when the VM is based on template In case of a VM based on template the decision whether the command is using a callback or not is determined in the superclass AddVmCommand wrongly, the decision was moved to CloneVmCommand itself and is determined according to whether the VM has disks or not Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Bug-Url: https://bugzilla.redhat.com/1395793 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ed9e67923a3379c9bf061546249f3966af7b52 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Post-copy migration policy
by Code Review 08 Dec '16

08 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Post-copy migration policy ...................................................................... core: Post-copy migration policy Added new migration policy to Engine configuration that includes switching to post-copy migration if migration is stalled. Change-Id: Id85573f779a20e26f61db1791ad12a7e954bb1a1 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0590_remove_MigrationPolicies_general_config_value.sql M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Arik Hadas: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/67633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85573f779a20e26f61db1791ad12a7e954bb1a1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add http_proxy env var to proxied mock envs
by Code Review 08 Dec '16

08 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Add http_proxy env var to proxied mock envs ...................................................................... Add http_proxy env var to proxied mock envs This will hopefully allow tools running inside the mock env to take advantage of the proxy (Perhaps even with no extra conf needed for some) Also improved CI for this repo by making it run on more platforms and not do unnecessary tests Change-Id: I91e4b99acc05f78fc2d4cee01348553fa299e01c Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M automation/check-patch.packages A automation/check-patch.packages.el7 M automation/check-patch.sh M jobs/confs/projects/jenkins/jenkins_standard.yaml M mock_configs/epel-6-x86_64_proxied.cfg M mock_configs/epel-7-ppc64le_proxied.cfg M mock_configs/epel-7-x86_64_proxied.cfg M mock_configs/fedora-24-ppc64le_proxied.cfg M mock_configs/fedora-24-x86_64_proxied.cfg M mock_configs/fedora-25-x86_64_proxied.cfg 10 files changed, 60 insertions(+), 5 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91e4b99acc05f78fc2d4cee01348553fa299e01c Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateDiskCommandTest: Remove redundant mocking
by Code Review 08 Dec '16

08 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateDiskCommandTest: Remove redundant mocking ...................................................................... core: UpdateDiskCommandTest: Remove redundant mocking Remove redundant mocking that has no use in the test and just makes it harder to read and understand. Change-Id: I685f9dd55bed08cf8fb71485128896d1503a7bc9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java 1 file changed, 0 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67967 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I685f9dd55bed08cf8fb71485128896d1503a7bc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0