February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: avoid asking about storage domain and storage pool ...
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: avoid asking about storage domain and storage pool name ...................................................................... storage: avoid asking about storage domain and storage pool name Avoid asking about storage domain and storage pool name, directly use their default values. Change-Id: I1605e1cd235b810b781c247fe503af204cc87104 Bug-Url: https://bugzilla.redhat.com/1303716 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 2 insertions(+), 95 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/53223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1605e1cd235b810b781c247fe503af204cc87104 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: networking: set VLAN on top level network object
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: networking: set VLAN on top level network object ...................................................................... networking: set VLAN on top level network object The /cluster/{cluster:id}/networks/{network:id} resource only supports updates of the cluster itself, which is weird. For any other update, like the VLAN, you need to sue the top level /networks/{network:id} resource which can be addressed only by id. Pooling to check network status and vlan id since setting vlan id is async. Detecting the interface name if the management bridge was created in the past by a previous attempt. Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 117 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/53064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: networking: enforcing unique match between hostname and mgmt...
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: networking: enforcing unique match between hostname and mgmt interface ...................................................................... networking: enforcing unique match between hostname and mgmt interface hosted-engine-setup has to create the management bridge before starting the engine VM otherwise it will have no connectivity. Then it will trigger host-deploy calling hosts.add on the engine API passing just an address parameter to identify the host; the address should be the host name (cfg rhbz#1178535) On host-deploy, VDSM will try to re-create the management bridge on the interface where address resolves to. This can randomly lead to a wrong network configuration if address can be resolved to more than one interface. Enforcing unique match between address and the IP of the management interface to avoid this. This is compatible with the current version of oVirt node since it let the user to configure just one interface and so there is no ambiguity by construction there but it should be re.tested with node.next. Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 4 files changed, 58 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/53209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: networking: set VLAN on top level network object
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: networking: set VLAN on top level network object ...................................................................... networking: set VLAN on top level network object The /cluster/{cluster:id}/networks/{network:id} resource only supports updates of the cluster itself, which is weird. For any other update, like the VLAN, you need to sue the top level /networks/{network:id} resource which can be addressed only by id. Pooling to check network status and vlan id since setting vlan id is async. Detecting the interface name if the management bridge was created in the past by a previous attempt. Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 117 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcff652ef28e6b912514df2dd2daac2b07eca61e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: avoid asking about storage domain and storage pool ...
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: avoid asking about storage domain and storage pool name ...................................................................... storage: avoid asking about storage domain and storage pool name Avoid asking about storage domain and storage pool name, directly use their default values. Change-Id: I1605e1cd235b810b781c247fe503af204cc87104 Bug-Url: https://bugzilla.redhat.com/1303716 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 1 file changed, 2 insertions(+), 95 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1605e1cd235b810b781c247fe503af204cc87104 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: create_rpms:Added bzip support for source tarballs
by dcaro＠redhat.com 08 Feb '16

08 Feb '16

David Caro has submitted this change and it was merged. Change subject: create_rpms:Added bzip support for source tarballs ...................................................................... create_rpms:Added bzip support for source tarballs Change-Id: I2b755b32f58987da990fec88a398325e8d8a14c7 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/shell-scripts/build_mock_srcrpm.sh 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/53225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b755b32f58987da990fec88a398325e8d8a14c7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: network: enforce NetworkManager is not active
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: enforce NetworkManager is not active ...................................................................... network: enforce NetworkManager is not active hosted-engine-setup will create the network bridge before calling host.add() and then host-deploy will stop NetworkManager: stopping NetworkManager in the middle of the deployment can modify the bridge so it's safer to ask the user to explictly stop and disable it before. Change-Id: If8df5187ed6ffc82a5d97140399fa5def022447c Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8df5187ed6ffc82a5d97140399fa5def022447c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: networking: enforcing unique match between hostname and mgmt...
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: networking: enforcing unique match between hostname and mgmt interface ...................................................................... networking: enforcing unique match between hostname and mgmt interface hosted-engine-setup has to create the management bridge before starting the engine VM otherwise it will have no connectivity. Then it will trigger host-deploy calling hosts.add on the engine API passing just an address parameter to identify the host; the address should be the host name (cfg rhbz#1178535) On host-deploy, VDSM will try to re-create the management bridge on the interface where address resolves to. This can randomly lead to a wrong network configuration if address can be resolved to more than one interface. Enforcing unique match between address and the IP of the management interface to avoid this. This is compatible with the current version of oVirt node since it let the user to configure just one interface and so there is no ambiguity by construction there but it should be re.tested with node.next. Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 4 files changed, 58 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I478b499c6e1b3a6160822f4c58966c6d29f4e42d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Set default boot order if absent in OVF
by tnisan＠redhat.com 08 Feb '16

08 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Set default boot order if absent in OVF ...................................................................... core: Set default boot order if absent in OVF Set a default boot order if <BootOrder> elements are absent from OVF. The default boot order includes all bootable disks in the order the appear in OVF. Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1297202 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add the ImageTickets errors
by tnisan＠redhat.com 08 Feb '16

08 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Add the ImageTickets errors ...................................................................... engine: Add the ImageTickets errors The ImageTickets errors was added to VDSM in commit 8ec8e74cd3264d13ef3e474c7836ba7e2db331f1. This patch finishes the job by adding a mapping in the engine. Change-Id: I3499f96147c5e5e2e65f28d765c3936d440b84b2 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 4 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/53204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3499f96147c5e5e2e65f28d765c3936d440b84b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0