February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: ImagesHandler.removeDiskImage log message
by amureini＠redhat.com 17 Feb '16

17 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler.removeDiskImage log message ...................................................................... core: ImagesHandler.removeDiskImage log message Fix log message wording in ImagesHandler.removeDiskImage(). Change-Id: Ib66469b3ebfd79e1dc28134556aa874476fbecb5 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53625 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib66469b3ebfd79e1dc28134556aa874476fbecb5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: post ovirt-hosted-engine-setup-1.3.3.3
by sbonazzo＠redhat.com 17 Feb '16

17 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-1.3.3.3 ...................................................................... build: post ovirt-hosted-engine-setup-1.3.3.3 Change-Id: I39e1115864ab0d2cc915da4e57cc9713d7553765 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53628 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39e1115864ab0d2cc915da4e57cc9713d7553765 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: build: ovirt-hosted-engine-setup-1.3.3.3
by sbonazzo＠redhat.com 17 Feb '16

17 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.3.3.3 ...................................................................... build: ovirt-hosted-engine-setup-1.3.3.3 Change-Id: I72cd515e8245b6c8806fbcd240d8f7672b384e04 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72cd515e8245b6c8806fbcd240d8f7672b384e04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: nit: fixed pep8
by sbonazzo＠redhat.com 17 Feb '16

17 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: nit: fixed pep8 ...................................................................... nit: fixed pep8 Change-Id: I19c0bcb3a73720f5102d2d94584d8cdd13cb0815 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19c0bcb3a73720f5102d2d94584d8cdd13cb0815 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: network: getting the IP addr from the bridge if it already e...
by sbonazzo＠redhat.com 17 Feb '16

17 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: getting the IP addr from the bridge if it already exists ...................................................................... network: getting the IP addr from the bridge if it already exists If the management bridge has been already configured on the system by a previous unsuccessful run of hosted-engine-setup, the address should be acquired directly from that. Bug-Url: https://bugzilla.redhat.com/1308333 Change-Id: Ie8cfa88277d0ad52735ae048d1b5325368bb6367 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 43 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8cfa88277d0ad52735ae048d1b5325368bb6367 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: getting the IP addr from the bridge if it already e...
by sbonazzo＠redhat.com 17 Feb '16

17 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: getting the IP addr from the bridge if it already exists ...................................................................... network: getting the IP addr from the bridge if it already exists If the management bridge has been already configured on the system by a previous unsuccessful run of hosted-engine-setup, the address should be acquired directly from that. Bug-Url: https://bugzilla.redhat.com/1308333 Change-Id: Ie8cfa88277d0ad52735ae048d1b5325368bb6367 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 43 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8cfa88277d0ad52735ae048d1b5325368bb6367 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LiveMerge - avoid unneeded endAction() run
by laravot＠redhat.com 16 Feb '16

16 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: LiveMerge - avoid unneeded endAction() run ...................................................................... core: LiveMerge - avoid unneeded endAction() run When running the live merge flow, the endAction() of RemoveSnapshotSingleDiskLiveCommand shouldn't run as currently the logic is contained within the onFailed()/onSucceeded() methods (that should be changed in a separate change). Furthermore, in this change the end methods are overriden to clarify that the logic in the parent command shouldn't be executed ever. Change-Id: I562d07d713cba53c0ca1a2c2a14f05d65d98ab8d Bug-Url: https://bugzilla.redhat.com/1306743 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/53566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I562d07d713cba53c0ca1a2c2a14f05d65d98ab8d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Linq methods return types
by amureini＠redhat.com 16 Feb '16

16 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Linq methods return types ...................................................................... webadmin: Linq methods return types Changed return type to Collection in order to facilitate further refactoring in the next patch(es) in the series. These methods are only used once and in that place only its size is checked, so the Collection return type is appropriate in an API level. Change-Id: Idb7d11aafa5848dc73e5c339730406f271206643 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb7d11aafa5848dc73e5c339730406f271206643 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: use List where possible
by amureini＠redhat.com 16 Feb '16

16 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: use List where possible ...................................................................... webadmin: use List where possible Use List instead of ArrayList where it's trivially possible as per Java's best practices. Change-Id: I2a0e7b41cf80094cd9704582666472face374e78 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 25 insertions(+), 25 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a0e7b41cf80094cd9704582666472face374e78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove spam comment
by amureini＠redhat.com 16 Feb '16

16 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove spam comment ...................................................................... webadmin: Remove spam comment Probably left there by a careless copy-paste, these lines of the comment should be removed. Change-Id: Ic35f097e2a26f7b854bdb98a02fc2074977beced Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic35f097e2a26f7b854bdb98a02fc2074977beced Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0